OMAP: McBSP: tx_irq_completion used in rx_irq_handler
Subsystems (2)
PATCH 1/1 OMAP: McBSP: tx_irq_completion used in rx_irq_handler
Looks like a typo from commit d6d834b010.
Signed-off-by Scott Ellis <[email protected]>
--- arch/arm/plat-omap/mcbsp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/mcbsp.c +1 -1
@@ -156,7 +156,7 @@ static irqreturn_t omap_mcbsp_rx_irq_handler(int irq, void *dev_id)/* Writing zero to RSYNC_ERR clears the IRQ */ MCBSP_WRITE (mcbsp_rx,SPCR1 ,MCBSP_READ_CACHE (mcbsp_rx,SPCR1 )); }else { -complete (&mcbsp_rx->tx_irq_completion); +complete (&mcbsp_rx->rx_irq_completion); }return IRQ_HANDLED ;
PATCH 1/1 OMAP: McBSP: tx_irq_completion used in rx_irq_handler
Quoted 7 lines · ext Scott Ellis
Looks like a typo from commit
d6d834b010.Signed-off-by Scott Ellis <[email protected]>--- arch/arm/plat-omap/mcbsp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Indeed my typo.
Acked-by Eero Nurkkala <[email protected]>
Quoted 15 lines
arch/arm/plat-omap/mcbsp.c +1
-1@@ -156,7 +156,7 @@ static irqreturn_t omap_mcbsp_rx_irq_handler(int irq, void *dev_id)/* Writing zero to RSYNC_ERR clears the IRQ */ MCBSP_WRITE (mcbsp_rx,SPCR1 ,MCBSP_READ_CACHE (mcbsp_rx,SPCR1 )); }else { -complete (&mcbsp_rx->tx_irq_completion); +complete (&mcbsp_rx->rx_irq_completion); }return IRQ_HANDLED ;
PATCH 1/1 OMAP: McBSP: tx_irq_completion used in rx_irq_handler
In reply to Scott EllisQuoted 12 lines · On Wed, 08 Sep 2010 13:29:01 -0400 Scott Ellis <[email protected]> wrote:
Looks like a typo from commit
d6d834b010.Signed-off-by Scott Ellis <[email protected]>--- arch/arm/plat-omap/mcbsp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/plat-omap/mcbsp.c +0
-0
arch/arm/plat-omap/mcbsp.c static irqreturn_t omap_mcbsp_rx_irq_handler(int irq, void *dev_id) · line 161
Quoted 7 lines
arch/arm/plat-omap/mcbsp.c +1
-1@@ -156,7 +156,7 @@ static irqreturn_t omap_mcbsp_rx_irq_handler(int irq, void *dev_id)/* Writing zero to RSYNC_ERR clears the IRQ */ MCBSP_WRITE (mcbsp_rx,SPCR1 ,MCBSP_READ_CACHE (mcbsp_rx,SPCR1 )); }else { -complete (&mcbsp_rx->tx_irq_completion); +complete (&mcbsp_rx->rx_irq_completion); }
It looks so.
Acked-by Jarkko Nikula <[email protected]>
PATCH 1/1 OMAP: McBSP: tx_irq_completion used in rx_irq_handler
In reply to Scott EllisQuoted 13 lines · On Wednesday 08 September 2010 20:29:01 ext Scott Ellis wrote:
Looks like a typo from commit
d6d834b010.Signed-off-by Scott Ellis <[email protected]>--- arch/arm/plat-omap/mcbsp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/plat-omap/mcbsp.c +0
-0@@ -156,7 +156,7 @@ static irqreturn_t omap_mcbsp_rx_irq_handler(int irq,void
*dev_id) /* Writing zero toRSYNC_ERRclears the IRQ */
arch/arm/plat-omap/mcbsp.c static irqreturn_t omap_mcbsp_rx_irq_handler(int irq, void *dev_id) · line 162
Quoted 7 lines
arch/arm/plat-omap/mcbsp.c +1
-1MCBSP_WRITE (mcbsp_rx,SPCR1 ,MCBSP_READ_CACHE (mcbsp_rx,SPCR1 )); }else { -complete (&mcbsp_rx->tx_irq_completion); +complete (&mcbsp_rx->rx_irq_completion); }return IRQ_HANDLED ;
Acked-by Peter Ujfalusi <[email protected]>