Skip to contentSkip to conversation

backlight: add low threshold to pwm backlight

PATCH In review Arun Murthy 2 participants 4 messages Sep 9, 2010 – Sep 28, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 backlight: add low threshold to pwm backlight

The intensity of the backlight can be varied from a range of max_brightness to zero. Though most, if not all the pwm based backlight devices start flickering at lower brightness value. And also for each device there exists a brightness value below which the backlight appears to be turned off though the value is not equal to zero.

If the range of brightness for a device is from zero to max_brightness. A graph is plotted for brightness Vs intensity fo the pwm based backlight device has to be a linear graph.

intensity

	  |   /
	  |  /
	  | /
	  |/
	  ---------
	 0	max_brightness

But pratically on measuring the above we note that the intensity of backlight goes to zero(OFF) when the value in not zero almost nearing to zero(some x%). so the graph looks like

intensity

	  |    /
	  |   /
	  |  /
	  |  |
	  ------------
	 0   x	 max_brightness

In order to overcome this drawback knowing this x% i.e nothing but the low threshold beyond which the backlight is off and will have no effect, the brightness value is being offset by the low threshold value(retaining the linearity of the graph). Now the graph becomes

intensity

	  |     /
	  |    /
	  |   /
	  |  /
	  -------------
	   0	  max_brightness

With this for each and every digit increment in the brightness from zero there is a change in the intensity of backlight.
Devices having this behaviour can set the low threshold brightness(lth_brightness) and pass the same as platform data else can have it as zero.

---
 drivers/video/backlight/pwm_bl.c |    7 ++++++-
 include/linux/pwm_backlight.h    |    1 +
 2 files changed, 7 insertions(+), 1 deletions(-)
drivers/video/backlight/pwm_bl.c +6 -1
index 5504435..1f958ce 100644
@@ -25,6 +25,7 @@ struct pwm_bl_data {
 	struct pwm_device	*pwm;
 	struct device		*dev;
 	unsigned int		period;
+	unsigned int		lth_brightness;
 	int			(*notify)(struct device *,
 					  int brightness);
 };
@@ -48,7 +49,9 @@ static int pwm_backlight_update_status(struct backlight_device *bl)
 		pwm_config(pb->pwm, 0, pb->period);
 		pwm_disable(pb->pwm);
 	} else {
-		pwm_config(pb->pwm, brightness * pb->period / max, pb->period);
+		brightness = pb->lth_brightness +
+			(brightness * (pb->period - pb->lth_brightness)/ max);
+		pwm_config(pb->pwm, brightness, pb->period);
 		pwm_enable(pb->pwm);
 	}
 	return 0;
@@ -92,6 +95,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
 
 	pb->period = data->pwm_period_ns;
 	pb->notify = data->notify;
+	pb->lth_brightness = data->lth_brightness *
+		(data->pwm_period_ns / data->max_brightness);
 	pb->dev = &pdev->dev;
 
 	pb->pwm = pwm_request(data->pwm_id, "backlight");
include/linux/pwm_backlight.h +1 -0
index 01b3d75..e031e1a 100644
@@ -8,6 +8,7 @@ struct platform_pwm_backlight_data {
 	int pwm_id;
 	unsigned int max_brightness;
 	unsigned int dft_brightness;
+	unsigned int lth_brightness;
 	unsigned int pwm_period_ns;
 	int (*init)(struct device *dev);
 	int (*notify)(struct device *dev, int brightness);
Signature · 1 line
1.7.2.dirty
#1 lore raw

Any comments?

Quoted 118 lines

-----Original Message-----
From: Arun MURTHY
Sent: Thursday, September 09, 2010 5:00 PM
To: [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; STEricsson_nomadik_linux; Arun MURTHY
Subject: [PATCH] backlight: add low threshold to pwm backlight

The intensity of the backlight can be varied from a range of max_brightness to zero. Though most, if not all the pwm based backlight devices start flickering at lower brightness value. And also for each device there exists a brightness value below which the backlight appears
to be turned off though the value is not equal to zero.

If the range of brightness for a device is from zero to max_brightness. A graph is plotted for brightness Vs intensity fo the pwm based backlight device has to be a linear graph.

intensity

	  |   /
	  |  /
	  | /
	  |/
	  ---------
	 0	max_brightness

But pratically on measuring the above we note that the intensity of backlight goes to zero(OFF) when the value in not zero almost nearing to
zero(some x%). so the graph looks like

intensity

	  |    /
	  |   /
	  |  /
	  |  |
	  ------------
	 0   x	 max_brightness

In order to overcome this drawback knowing this x% i.e nothing but the low threshold beyond which the backlight is off and will have no effect,
the brightness value is being offset by the low threshold value(retaining the linearity of the graph). Now the graph becomes

intensity

	  |     /
	  |    /
	  |   /
	  |  /
	  -------------
	   0	  max_brightness

With this for each and every digit increment in the brightness from zero
there is a change in the intensity of backlight.
Devices having this behaviour can set the low threshold brightness(lth_brightness) and pass the same as platform data else can have it as zero.

---
 drivers/video/backlight/pwm_bl.c |    7 ++++++-
 include/linux/pwm_backlight.h    |    1 +
 2 files changed, 7 insertions(+), 1 deletions(-)
drivers/video/backlight/pwm_bl.c +4 -1
index 5504435..1f958ce 100644
@@ -25,6 +25,7 @@ struct pwm_bl_data {
 	struct pwm_device	*pwm;
 	struct device		*dev;
 	unsigned int		period;
+	unsigned int		lth_brightness;
 	int			(*notify)(struct device *,
 					  int brightness);
 };
@@ -48,7 +49,9 @@ static int pwm_backlight_update_status(struct
 backlight_device *bl)
 		pwm_config(pb->pwm, 0, pb->period);
 		pwm_disable(pb->pwm);
 	} else {
-		pwm_config(pb->pwm, brightness * pb->period / max, pb-
 >period);
+		brightness = pb->lth_brightness +
+			(brightness * (pb->period - pb->lth_brightness)/
 max);
+		pwm_config(pb->pwm, brightness, pb->period);
drivers/video/backlight/pwm_bl.c +2 -0
 		pwm_enable(pb->pwm);
 	}
 	return 0;
@@ -92,6 +95,8 @@ static int pwm_backlight_probe(struct platform_device
 *pdev)
 
 	pb->period = data->pwm_period_ns;
 	pb->notify = data->notify;
+	pb->lth_brightness = data->lth_brightness *
+		(data->pwm_period_ns / data->max_brightness);
 	pb->dev = &pdev->dev;
 
drivers/video/backlight/pwm_bl.c +0 -0
 	pb->pwm = pwm_request(data->pwm_id, "backlight");
include/linux/pwm_backlight.h +1 -1
index 01b3d75..e031e1a 100644
@@ -8,6 +8,7 @@ struct platform_pwm_backlight_data {
 	int pwm_id;
 	unsigned int max_brightness;
 	unsigned int dft_brightness;
+	unsigned int lth_brightness;
 	unsigned int pwm_period_ns;
 	int (*init)(struct device *dev);
 	int (*notify)(struct device *dev, int brightness);
--

1.7.2.dirty

#2 lore raw

If there are no comments, can you please pick this patch?

Thanks and Regards,
Arun R Murthy
-------------

Quoted 133 lines

-----Original Message-----
From: Arun MURTHY
Sent: Tuesday, September 14, 2010 12:36 PM
To: Arun MURTHY; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; STEricsson_nomadik_linux
Subject: RE: [PATCH] backlight: add low threshold to pwm backlight

Any comments?

Quoted 6 lines

-----Original Message-----
From: Arun MURTHY
Sent: Thursday, September 09, 2010 5:00 PM
To: [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; STEricsson_nomadik_linux; Arun

MURTHY

Quoted 4 lines

Subject: [PATCH] backlight: add low threshold to pwm backlight

The intensity of the backlight can be varied from a range of max_brightness to zero. Though most, if not all the pwm based

backlight

Quoted 22 lines

devices start flickering at lower brightness value. And also for each device there exists a brightness value below which the backlight appears
to be turned off though the value is not equal to zero.

If the range of brightness for a device is from zero to max_brightness. A graph is plotted for brightness Vs intensity fo the pwm based backlight device has to be a linear graph.

intensity

	  |   /
	  |  /
	  | /
	  |/
	  ---------
	 0	max_brightness

But pratically on measuring the above we note that the intensity of backlight goes to zero(OFF) when the value in not zero almost nearing to
zero(some x%). so the graph looks like

intensity

Quoted 8 lines
	  |    /
	  |   /
	  |  /
	  |  |
	  ------------
	 0   x	 max_brightness

In order to overcome this drawback knowing this x% i.e nothing but

the

Quoted 12 lines

low threshold beyond which the backlight is off and will have no effect,
the brightness value is being offset by the low threshold value(retaining the linearity of the graph). Now the graph becomes

intensity

	  |     /
	  |    /
	  |   /
	  |  /
	  -------------
	   0	  max_brightness
Quoted 5 lines

With this for each and every digit increment in the brightness from zero
there is a change in the intensity of backlight.
Devices having this behaviour can set the low threshold brightness(lth_brightness) and pass the same as platform data else

can

drivers/video/backlight/pwm_bl.c static int pwm_backlight_probe(struct

Quoted 37 lines

have it as zero.

---
 drivers/video/backlight/pwm_bl.c |    7 ++++++-
 include/linux/pwm_backlight.h    |    1 +
 2 files changed, 7 insertions(+), 1 deletions(-)
drivers/video/backlight/pwm_bl.c +4 -1
index 5504435..1f958ce 100644
@@ -25,6 +25,7 @@ struct pwm_bl_data {
 	struct pwm_device	*pwm;
 	struct device		*dev;
 	unsigned int		period;
+	unsigned int		lth_brightness;
 	int			(*notify)(struct device *,
 					  int brightness);
 };
@@ -48,7 +49,9 @@ static int pwm_backlight_update_status(struct
 backlight_device *bl)
 		pwm_config(pb->pwm, 0, pb->period);
 		pwm_disable(pb->pwm);
 	} else {
-		pwm_config(pb->pwm, brightness * pb->period / max, pb-
 >period);
+		brightness = pb->lth_brightness +
+			(brightness * (pb->period - pb->lth_brightness)/
 max);
+		pwm_config(pb->pwm, brightness, pb->period);
drivers/video/backlight/pwm_bl.c +0 -0
 		pwm_enable(pb->pwm);
 	}
 	return 0;
@@ -92,6 +95,8 @@ static int pwm_backlight_probe(struct

platform_device

Quoted 24 lines
drivers/video/backlight/pwm_bl.c +2 -0
 *pdev)
 
 	pb->period = data->pwm_period_ns;
 	pb->notify = data->notify;
+	pb->lth_brightness = data->lth_brightness *
+		(data->pwm_period_ns / data->max_brightness);
 	pb->dev = &pdev->dev;
 
drivers/video/backlight/pwm_bl.c +0 -0
 	pb->pwm = pwm_request(data->pwm_id, "backlight");
include/linux/pwm_backlight.h +1 -1
index 01b3d75..e031e1a 100644
@@ -8,6 +8,7 @@ struct platform_pwm_backlight_data {
 	int pwm_id;
 	unsigned int max_brightness;
 	unsigned int dft_brightness;
+	unsigned int lth_brightness;
 	unsigned int pwm_period_ns;
 	int (*init)(struct device *dev);
 	int (*notify)(struct device *dev, int brightness);
--

1.7.2.dirty

#3 lore raw

2010/9/28 Arun MURTHY <[email protected]>:

Quoted 1 line

If there are no comments, can you please pick this patch?

Hm, no Sign-offs or mails to be seen from Purdie since May or June... :-(

Andrew would you mind queuing this one too in his absence?

We have some other backlight related stuff making rounds at the moment and when I just search the archive for "purdie" there seems to be a pile of stuff pending for Leds/Backlight actually.

Yours,
Linus Walleij