drivers/net/eql.c: prevent reading uninitialized stack memory
Subsystems (2)
PATCH v2 1/1 drivers/net/eql.c: prevent reading uninitialized stack memory
Fixed formatting (tabs and line breaks).
The EQL_GETMASTRCFG device ioctl allows unprivileged users to read 16 bytes of uninitialized stack memory, because the "master_name" member of the master_config_t struct declared on the stack in eql_g_master_cfg() is not altered or zeroed before being copied back to the user. This patch takes care of it.
drivers/net/eql.c +2 -0
@@ -555,6 +555,8 @@ static int eql_g_master_cfg(struct net_dequalizer_t *eql;master_config_t mc; +memset (&mc,0 ,sizeof (master_config_t)); +if (eql_is_master (dev)) { eql =netdev_priv (dev); mc.max_slaves = eql->max_slaves;
From: Dan Rosenberg <[email protected]>
Date: Wed, 15 Sep 2010 17:43:04 -0400
Quoted 9 lines
Fixed formatting (tabs and line breaks).
The
EQL_GETMASTRCFGdevice ioctl allows unprivileged users to read 16 bytes of uninitialized stack memory, because the "master_name" member of themaster_config_tstruct declared on the stack ineql_g_master_cfg()is not altered or zeroed before being copied back to the user. This patch takes care of it.Signed-off-by Dan Rosenberg <[email protected]>
Applied.