Skip to contentSkip to conversation

drivers/char/nozomi.c: prevent reading uninitialized stack memory

PATCH New Dan Rosenberg 1 participant 1 message Sep 15, 2010 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/char/nozomi.c: prevent reading uninitialized stack memory

The TIOCGICOUNT device ioctl allows unprivileged users to read uninitialized stack memory, because the "reserved" member of the serial_icounter_struct struct declared on the stack is not altered or zeroed before being copied back to the user. This patch takes care of it.

drivers/char/nozomi.c +2 -0
@@ -1810,6 +1810,8 @@ static int ntty_ioctl_tiocgicount(struct
 	const struct async_icount cnow = port->tty_icount;
 	struct serial_icounter_struct icount;
 
+	memset(&icount, 0, sizeof(struct serial_icounter_struct));
+
 	icount.cts = cnow.cts;
 	icount.dsr = cnow.dsr;
 	icount.rng = cnow.rng;