drivers/char/amiserial.c: prevent reading uninitialized stack memory
PATCH 1/1 drivers/char/amiserial.c: prevent reading uninitialized stack memory
The TIOCGICOUNT device ioctl allows unprivileged users to read uninitialized stack memory, because the "reserved" member of the serial_icounter_struct struct declared on the stack is not altered or zeroed before being copied back to the user. This patch takes care of it.
Signed-off-by Dan Rosenberg <[email protected]>
drivers/char/amiserial.c +3 -0
@@ -1342,6 +1342,9 @@ static int rs_ioctl(struct tty_struct *tlocal_irq_save (flags); cnow = info->state->icount;local_irq_restore (flags); + +memset (&icount,0 ,sizeof (struct serial_icounter_struct )); + icount.cts = cnow.cts; icount.dsr = cnow.dsr; icount.rng = cnow.rng;