Skip to contentSkip to conversation

drivers/serial/serial_core.c: prevent reading uninitialized stack memory

PATCH New Dan Rosenberg 1 participant 1 message Sep 15, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/serial/serial_core.c: prevent reading uninitialized stack memory

The TIOCGICOUNT device ioctl allows unprivileged users to read uninitialized stack memory, because the "reserved" member of the serial_icounter_struct struct declared on the stack is not altered or zeroed before being copied back to the user. This patch takes care of it.

drivers/serial/serial_core.c +2 -0
@@ -1081,6 +1081,8 @@ static int uart_get_count(struct uart_st
 	struct uart_icount cnow;
 	struct uart_port *uport = state->uart_port;
 
+	memset(&icount, 0, sizeof(struct serial_icounter_struct));
+
 	spin_lock_irq(&uport->lock);
 	memcpy(&cnow, &uport->icount, sizeof(struct uart_icount));
 	spin_unlock_irq(&uport->lock);