Skip to contentSkip to conversation

drivers/video/via/ioctl.c: prevent reading uninitialized stack memory

PATCH In review Dan Rosenberg 3 participants 3 messages Sep 15, 2010 – Sep 16, 2010 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/video/via/ioctl.c: prevent reading uninitialized stack memory

The VIAFB_GET_INFO device ioctl allows unprivileged users to read 1968 bytes of uninitialized stack memory, because the "reserved" member of the viafb_ioctl_info struct declared on the stack is not altered or zeroed before being copied back to the user. This patch takes care of it.

drivers/video/via/ioctl.c +2 -0
@@ -25,6 +25,8 @@ int viafb_ioctl_get_viafb_info(u_long ar
 {
 	struct viafb_ioctl_info viainfo;
 
+	memset(&viainfo, 0, sizeof(struct viafb_ioctl));
+
 	viainfo.viafb_id = VIAID;
 	viainfo.vendor_id = PCI_VIA_VENDOR_ID;
 
#1 lore raw

Hi,

Quoted 5 lines · Dan Rosenberg

The VIAFB_GET_INFO device ioctl allows unprivileged users to read 1968 bytes of uninitialized stack memory, because the "reserved" member of the viafb_ioctl_info struct declared on the stack is not altered or zeroed before being copied back to the user. This patch takes care of it.

I am wondering about the number of bytes as sizeof(struct viafb_ioctl_info) = 256 so it should be a bit less. But that's just nitpicking, the issue is certainly real. Your patch does the right thing but there is a bug in it:

drivers/video/via/ioctl.c int viafb_ioctl_get_viafb_info(u_long ar · line 28

Quoted 9 lines
drivers/video/via/ioctl.c +1 -0
@@ -25,6 +25,8 @@ int viafb_ioctl_get_viafb_info(u_long ar
 {
 	struct viafb_ioctl_info viainfo;
 
+	memset(&viainfo, 0, sizeof(struct viafb_ioctl));

Shouldn't it be sizeof(struct viafb_ioctl_info) or sizeof(viainfo) ? At least here it does not even compile otherwise....

Thanks,

Florian Tobias Schandinat

#2 lore raw
In reply to Dan Rosenberg
Quoted 11 lines · Dan Rosenberg

The VIAFB_GET_INFO device ioctl allows unprivileged users to read 1968 bytes of uninitialized stack memory, because the "reserved" member of the viafb_ioctl_info struct declared on the stack is not altered or zeroed before being copied back to the user. This patch takes care of it.

drivers/video/via/ioctl.c int viafb_ioctl_get_viafb_info(u_long ar · line 29

Quoted 5 lines
drivers/video/via/ioctl.c +2 -0
@@ -25,6 +25,8 @@ int viafb_ioctl_get_viafb_info(u_long ar
 {
 	struct viafb_ioctl_info viainfo;
 
+	memset(&viainfo, 0, sizeof(struct viafb_ioctl));
+

Again, this could probably be better off as:

-  	struct viafb_ioctl_info viainfo;
+  	struct viafb_ioctl_info viainfo = {
+  		.viafb_id = VIAID,

+ .vendor_id = PCI_VIA_VENDOR_ID,
+ };

- viainfo.viafb_id = VIAID;
- viainfo.vendor_id = PCI_VIA_VENDOR_ID;

-- Steve

Quoted 11 lines
drivers/video/via/ioctl.c +0 -1
 	viainfo.viafb_id = VIAID;
 	viainfo.vendor_id = PCI_VIA_VENDOR_ID;
 
 
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/