Skip to contentSkip to conversation

drivers/video/via/ioctl.c: prevent reading uninitialized stack memory

PATCH In review Dan Rosenberg 2 participants 2 messages Sep 15, 2010 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drivers/video/via/ioctl.c: prevent reading uninitialized stack memory

Disregard previous version, which had a typo and wouldn't compile. Also, math is fun: the ioctl allows reading of 1968 BITS = 246 bytes, not 1968 bytes as previously reported.

The VIAFB_GET_INFO device ioctl allows unprivileged users to read 246 bytes of uninitialized stack memory, because the "reserved" member of the viafb_ioctl_info struct declared on the stack is not altered or zeroed before being copied back to the user. This patch takes care of it.

drivers/video/via/ioctl.c +2 -0
@@ -25,6 +25,8 @@ int viafb_ioctl_get_viafb_info(u_long ar
 {
 	struct viafb_ioctl_info viainfo;
 
+	memset(&viainfo, 0, sizeof(struct viafb_ioctl_info));
+
 	viainfo.viafb_id = VIAID;
 	viainfo.vendor_id = PCI_VIA_VENDOR_ID;
 
#1 lore raw
Quoted 3 lines · Dan Rosenberg

Disregard previous version, which had a typo and wouldn't compile. Also, math is fun: the ioctl allows reading of 1968 BITS = 246 bytes, not 1968 bytes as previously reported.

Thanks, I will take care of getting it in mainline as soon as possible,

Florian Tobias Schandinat

Quoted 27 lines

The VIAFB_GET_INFO device ioctl allows unprivileged users to read 246 bytes of uninitialized stack memory, because the "reserved" member of the viafb_ioctl_info struct declared on the stack is not altered or zeroed before being copied back to the user. This patch takes care of it.

drivers/video/via/ioctl.c +2 -1
@@ -25,6 +25,8 @@ int viafb_ioctl_get_viafb_info(u_long ar
 {
 	struct viafb_ioctl_info viainfo;
 
+	memset(&viainfo, 0, sizeof(struct viafb_ioctl_info));
+
 	viainfo.viafb_id = VIAID;
 	viainfo.vendor_id = PCI_VIA_VENDOR_ID;
 
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html