Skip to contentSkip to conversation

drivers:staging:ti-st: mv headers to ti_wilink_st

PATCH In review [email protected] 2 participants 2 messages Sep 16, 2010 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers:staging:ti-st: mv headers to ti_wilink_st

From: Pavan Savoy <[email protected]>

move all the header information to ti_wilink_st.h.
This header would then not only serve the local modules like the st_core.c, st_kim.c and st_ll.c but also the external modules/protocol drivers that are dependent on the shared transport driver.
Also modify the structures to use cleaner u8/u16 types for data coming in from chip and data parsed out of firmware.

---
 drivers/staging/ti-st/bt_drv.c       |    2 +-
 drivers/staging/ti-st/fm.h           |   13 -
 drivers/staging/ti-st/st.h           |   83 -------
 drivers/staging/ti-st/st_core.c      |   10 +-
 drivers/staging/ti-st/st_core.h      |  128 -----------
 drivers/staging/ti-st/st_kim.c       |    5 +-
 drivers/staging/ti-st/st_kim.h       |  180 ---------------
 drivers/staging/ti-st/st_ll.c        |    4 +-
 drivers/staging/ti-st/st_ll.h        |   69 ------
 drivers/staging/ti-st/ti_wilink_st.h |  413 ++++++++++++++++++++++++++++++++++
 10 files changed, 421 insertions(+), 486 deletions(-)
 delete mode 100644 drivers/staging/ti-st/fm.h
 delete mode 100644 drivers/staging/ti-st/st.h
 delete mode 100644 drivers/staging/ti-st/st_core.h
 delete mode 100644 drivers/staging/ti-st/st_kim.h
 delete mode 100644 drivers/staging/ti-st/st_ll.h
 create mode 100644 drivers/staging/ti-st/ti_wilink_st.h
drivers/staging/ti-st/bt_drv.c +1 -1
index 61ae988..50da66d 100644
@@ -24,7 +24,7 @@
 #include <net/bluetooth/bluetooth.h>
 #include <net/bluetooth/hci_core.h>
 
-#include "st.h"
+#include "ti_wilink_st.h"
 #include "bt_drv.h"
 
 /* Define this macro to get debug msg */
drivers/staging/ti-st/fm.h deleted +0 -13
deleted file mode 100644
index be41453..0000000
@@ -1,13 +0,0 @@
-struct fm_event_hdr {
-	unsigned char plen;
-} __attribute__ ((packed));
-
-#define FM_MAX_FRAME_SIZE 0xFF	/* TODO: */
-#define FM_EVENT_HDR_SIZE 1	/* size of fm_event_hdr */
-#define ST_FM_CH8_PKT 0x8
-
-/* gps stuff */
-struct gps_event_hdr {
-unsigned char opcode;
-unsigned short plen;
-} __attribute__ ((packed));
drivers/staging/ti-st/st.h deleted +0 -83

83 lines not on this page · raw message

drivers/staging/ti-st/st_core.c +1 -9
index fad97d7..03397be 100644
@@ -28,15 +28,7 @@
 #include <net/bluetooth/bluetooth.h>
 #include <net/bluetooth/hci_core.h>
 #include <net/bluetooth/hci.h>
-#include "fm.h"
-/*
- * packet formats for fm and gps
- * #include "gps.h"
- */
-#include "st_core.h"
-#include "st_kim.h"
-#include "st_ll.h"
-#include "st.h"
+#include "ti_wilink_st.h"
 
 /* strings to be used for rfkill entries and by
  * ST Core to be used for sysfs debug entry
drivers/staging/ti-st/st_core.h deleted +0 -128

128 lines not on this page · raw message

drivers/staging/ti-st/st_kim.c +3 -2
index be18c7a..09e2c97 100644
@@ -28,15 +28,16 @@
 #include <linux/gpio.h>
 #include <linux/debugfs.h>
 #include <linux/seq_file.h>
-
 #include <linux/sched.h>
+#include <linux/rfkill.h>
 
-#include "st_kim.h"
 /* understand BT events for fw response */
 #include <net/bluetooth/bluetooth.h>
 #include <net/bluetooth/hci_core.h>
 #include <net/bluetooth/hci.h>
 
+#include "ti_wilink_st.h"
+
 
 static int kim_probe(struct platform_device *pdev);
 static int kim_remove(struct platform_device *pdev);
drivers/staging/ti-st/st_kim.h deleted +0 -180

180 lines not on this page · raw message

drivers/staging/ti-st/st_ll.c +3 -1
index 7a1fb6d..d08b58e 100644
@@ -19,7 +19,9 @@
  */
 
 #define pr_fmt(fmt) "(stll) :" fmt
-#include "st_ll.h"
+#include <linux/skbuff.h>
+#include <linux/module.h>
+#include "ti_wilink_st.h"
 
 /**********************************************************************/
 /* internal functions */
drivers/staging/ti-st/st_ll.h deleted +0 -69

69 lines not on this page · raw message

drivers/staging/ti-st/ti_wilink_st.h new file +413 -0

413 lines not on this page · raw message

Signature · 1 line
1.6.5
#1 lore raw
Quoted 8 lines · On Thu, Sep 16, 2010 at 06:34:04PM -0400, [email protected] wrote:

From: Pavan Savoy <[email protected]>

move all the header information to ti_wilink_st.h.
This header would then not only serve the local modules like the st_core.c, st_kim.c and st_ll.c but also the external modules/protocol drivers that are dependent on the shared transport driver.
Also modify the structures to use cleaner u8/u16 types for data coming in from chip and data parsed out of firmware.

No!

Don't do more than one thing at once please, do one thing at a time.

One patch to modify the structures.

And one patch to move things together.

thanks,

greg k-h