qla2xxx: Remove host_lock unlock() + lock() from qla2xxx_queuecommand()

PATCH In review Nicholas A. Bellinger 1 participant 1 message Sep 17, 2010

Subsystems (2)

SCSI QLogic QLA2XXX FC-SCSI driver

lore

Share & tools

lore

Nicholas A. Bellinger

author

2010-09-17 18:23 UTC #0 lore raw

PATCH v2 9/11 qla2xxx: Remove host_lock unlock() + lock() from qla2xxx_queuecommand()

From: Nicholas Bellinger <[email protected]>

This patch removes the now legacy host_lock unlock() + lock() optimization from qla_os.c:qla2xxx_queuecommand()

Signed-off-by Nicholas A. Bellinger <[email protected]>

---
 drivers/scsi/qla2xxx/qla_os.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

drivers/scsi/qla2xxx/qla_os.c +2 -5

index 8c80b49..45c3d28 100644
@@ -574,11 +574,9 @@ qla2xxx_queuecommand(struct scsi_cmnd *cmd, void (*done)(struct scsi_cmnd *))
 		goto qc24_target_busy;
 	}
 
-	spin_unlock_irq(vha->host->host_lock);
-
 	sp = qla2x00_get_new_sp(base_vha, fcport, cmd, done);
 	if (!sp)
-		goto qc24_host_busy_lock;
+		goto qc24_host_busy;
 
 	rval = ha->isp_ops->start_scsi(sp);
 	if (rval != QLA_SUCCESS)

@@ -592,8 +590,7 @@ qc24_host_busy_free_sp:
 	qla2x00_sp_free_dma(sp);
 	mempool_free(sp, ha->srb_mempool);
 
-qc24_host_busy_lock:
-	spin_lock_irq(vha->host->host_lock);
+qc24_host_busy:
 	return SCSI_MLQUEUE_HOST_BUSY;
 
 qc24_target_busy:

Signature · 1 line

1.7.2.3