Skip to contentSkip to conversation

cfq-iosched: don't idle if a deep seek queue is slow

PATCH In review Shaohua Li 2 participants 3 messages Sep 20, 2010 Block layer

lore
Share & tools
lore

Shaohua Li

author
#0 lore raw

PATCH 1/1 cfq-iosched: don't idle if a deep seek queue is slow

If a deep seek queue slowly deliver requests but disk is much faster, idle for the queue just wastes disk throughput. If the queue delevers all requests before half its slice is used, the patch disable idle for it.
In my test, application delivers 32 requests one time, the disk can accept 128 requests at maxium and disk is fast. without the patch, the throughput is just around 30m/s, while with it, the speed is about 80m/s. The disk is a SSD, but is detected as a rotational disk. I can configure it as SSD, but I thought the deep seek queue logic should be fixed too, for example, considering a fast raid.

---
 block/cfq-iosched.c |   11 +++++++++++
 1 file changed, 11 insertions(+)
block/cfq-iosched.c +11 -0
Index: linux-2.6/block/cfq-iosched.c
===================================================================
@@ -2275,6 +2275,17 @@
 		goto keep_queue;
 	}
 
+	/*
+	 * This is a deep seek queue, but the device is much faster than
+	 * the queue can deliver, don't idle
+	 **/
+	if (CFQQ_SEEKY(cfqq) && cfq_cfqq_idle_window(cfqq) &&
+	    (cfq_cfqq_slice_new(cfqq) ||
+	    (cfqq->slice_end - jiffies > jiffies - cfqq->slice_start))) {
+		cfq_clear_cfqq_deep(cfqq);
+		cfq_clear_cfqq_idle_window(cfqq);
+	}
+
 	if (cfqq->dispatched && cfq_should_idle(cfqd, cfqq)) {
 		cfqq = NULL;
 		goto keep_queue;
#1 lore raw
Quoted 10 lines · Shaohua Li

If a deep seek queue slowly deliver requests but disk is much faster, idle for the queue just wastes disk throughput. If the queue delevers all requests before half its slice is used, the patch disable idle for it.
In my test, application delivers 32 requests one time, the disk can accept 128 requests at maxium and disk is fast. without the patch, the throughput is just around 30m/s, while with it, the speed is about 80m/s. The disk is a SSD, but is detected as a rotational disk. I can configure it as SSD, but I thought the deep seek queue logic should be fixed too, for example, considering a fast raid.

Hi Shaohua,

So you seem to be addressing the issue of storage being fast enough and a single queue not being able to keep the storage busy.

But we have the same issue for non-deep queues for a fast storage. This patch will not solve that.

I think CFQ idling in general is a problem on faster storage. For SSDs we can statically detect non-rotational media and disable idling. For faster RAIDs we need to find an intellligent way of detection and disable idling.

One of the suggestions at this year's LSF was to keep idling on only for SATA disks and for any SCSI disks we can think of disabling idling by default. May be with the help of udev rule.

Thanks
Vivek

Quoted 29 lines
---
 block/cfq-iosched.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

Index: linux-2.6/block/cfq-iosched.c
===================================================================

block/cfq-iosched.c +11 -0
@@ -2275,6 +2275,17 @@
 		goto keep_queue;
 	}
 
+	/*
+	 * This is a deep seek queue, but the device is much faster than
+	 * the queue can deliver, don't idle
+	 **/
+	if (CFQQ_SEEKY(cfqq) && cfq_cfqq_idle_window(cfqq) &&
+	    (cfq_cfqq_slice_new(cfqq) ||
+	    (cfqq->slice_end - jiffies > jiffies - cfqq->slice_start))) {
+		cfq_clear_cfqq_deep(cfqq);
+		cfq_clear_cfqq_idle_window(cfqq);
+	}
+
 	if (cfqq->dispatched && cfq_should_idle(cfqd, cfqq)) {
 		cfqq = NULL;
 		goto keep_queue;
author
#2 lore raw
Quoted 12 lines · Vivek Goyal
Quoted 10 lines · Shaohua Li

If a deep seek queue slowly deliver requests but disk is much faster, idle for the queue just wastes disk throughput. If the queue delevers all requests before half its slice is used, the patch disable idle for it.
In my test, application delivers 32 requests one time, the disk can accept 128 requests at maxium and disk is fast. without the patch, the throughput is just around 30m/s, while with it, the speed is about 80m/s. The disk is a SSD, but is detected as a rotational disk. I can configure it as SSD, but I thought the deep seek queue logic should be fixed too, for example, considering a fast raid.

Quoted 7 lines

Hi Shaohua,

So you seem to be addressing the issue of storage being fast enough and a single queue not being able to keep the storage busy.

But we have the same issue for non-deep queues for a fast storage. This patch will not solve that.

right.

Quoted 7 lines

I think CFQ idling in general is a problem on faster storage. For SSDs we can statically detect non-rotational media and disable idling. For faster RAIDs we need to find an intellligent way of detection and disable idling.

One of the suggestions at this year's LSF was to keep idling on only for SATA disks and for any SCSI disks we can think of disabling idling by default. May be with the help of udev rule.

That makes sense, but shouldn't kernel has some reasonable setting? completely depending on userspace isn't reliable.

Thanks,
Shaohua