Skip to contentSkip to conversation

ASoC: Report error code when failing to add controls

PATCH In review Mark Brown 2 participants 2 messages Sep 20, 2010 – Sep 21, 2010

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: Report error code when failing to add controls

Helps with diagnostics.

---
 sound/soc/soc-core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
sound/soc/soc-core.c +2 -2
index 8d8c5cd..7c64e03 100644
@@ -1983,8 +1983,8 @@ int snd_soc_add_controls(struct snd_soc_codec *codec,
 		const struct snd_kcontrol_new *control = &controls[i];
 		err = snd_ctl_add(card, snd_soc_cnew(control, codec, NULL));
 		if (err < 0) {
-			dev_err(codec->dev, "%s: Failed to add %s\n",
-				codec->name, control->name);
+			dev_err(codec->dev, "%s: Failed to add %s: %d\n",
+				codec->name, control->name, err);
 			return err;
 		}
 	}
Signature · 1 line
1.7.1
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Mark Brown

Helps with diagnostics.

---
 sound/soc/soc-core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
sound/soc/soc-core.c +0 -0
index 8d8c5cd..7c64e03 100644

sound/soc/soc-core.c int snd_soc_add_controls(struct snd_soc_codec *codec, · line 1990

Quoted 10 lines
sound/soc/soc-core.c +2 -2
@@ -1983,8 +1983,8 @@ int snd_soc_add_controls(struct snd_soc_codec *codec,
 		const struct snd_kcontrol_new *control = &controls[i];
 		err = snd_ctl_add(card, snd_soc_cnew(control, codec, NULL));
 		if (err < 0) {
-			dev_err(codec->dev, "%s: Failed to add %s\n",
-				codec->name, control->name);
+			dev_err(codec->dev, "%s: Failed to add %s: %d\n",
+				codec->name, control->name, err);
 			return err;
 		}
 	}
Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk