usb: musb: Adding names for IRQs in resource structure
Subsystems (7)
PATCH v3 1/9 usb: musb: Adding names for IRQs in resource structure
Modified the Omap,Blackfin and Davinci board files to add the name of the IRQs in the resource structures and musb driver to use the get_irq_byname() api to get the mc and dma irq numbers instead of using the index as the order of resource definition need not be always in order of device interrupt and then dma interrupt
--- arch/arm/mach-davinci/usb.c | 2 ++ arch/arm/mach-omap2/usb-musb.c | 2 ++ arch/blackfin/mach-bf527/boards/cm_bf527.c | 2 ++ arch/blackfin/mach-bf527/boards/ezbrd.c | 2 ++ arch/blackfin/mach-bf527/boards/ezkit.c | 2 ++ arch/blackfin/mach-bf548/boards/cm_bf548.c | 2 ++ arch/blackfin/mach-bf548/boards/ezkit.c | 2 ++ drivers/usb/musb/cppi_dma.c | 2 +- drivers/usb/musb/musb_core.c | 2 +- drivers/usb/musb/musbhsdma.c | 2 +- 10 files changed, 17 insertions(+), 3 deletions(-)
arch/arm/mach-davinci/usb.c +2 -0
@@ -64,10 +64,12 @@ static struct resource usb_resources[] = { .start = IRQ_USBINT, .flags = IORESOURCE_IRQ, + .name = "mc" }, { /* placeholder for the dedicated CPPI IRQ */ .flags = IORESOURCE_IRQ, + .name = "dma" }, };
arch/arm/mach-omap2/usb-musb.c +2 -0
@@ -39,10 +39,12 @@ static struct resource musb_resources[] [1 ] = {/* general IRQ */ .start =INT_243X_HS_USB_MC , .flags =IORESOURCE_IRQ , + .name ="mc" , }, [2 ] = {/* DMA IRQ */ .start =INT_243X_HS_USB_DMA , .flags =IORESOURCE_IRQ , + .name ="dma" , }, };
arch/blackfin/mach-bf527/boards/cm_bf527.c +2 -0
@@ -82,11 +82,13 @@ static struct resource musb_resources[] .start = IRQ_USB_INT0, .end = IRQ_USB_INT0, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "mc" }, [2] = { /* DMA IRQ */ .start = IRQ_USB_DMA, .end = IRQ_USB_DMA, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "dma" }, };
arch/blackfin/mach-bf527/boards/ezbrd.c +2 -0
@@ -46,11 +46,13 @@ static struct resource musb_resources[] .start = IRQ_USB_INT0, .end = IRQ_USB_INT0, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "mc" }, [2] = { /* DMA IRQ */ .start = IRQ_USB_DMA, .end = IRQ_USB_DMA, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "dma" }, };
arch/blackfin/mach-bf527/boards/ezkit.c +2 -0
@@ -86,11 +86,13 @@ static struct resource musb_resources[] .start = IRQ_USB_INT0, .end = IRQ_USB_INT0, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "mc" }, [2] = { /* DMA IRQ */ .start = IRQ_USB_DMA, .end = IRQ_USB_DMA, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "dma" }, };
arch/blackfin/mach-bf548/boards/cm_bf548.c +2 -0
@@ -482,11 +482,13 @@ static struct resource musb_resources[] .start = IRQ_USB_INT0, .end = IRQ_USB_INT0, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "mc" }, [2] = { /* DMA IRQ */ .start = IRQ_USB_DMA, .end = IRQ_USB_DMA, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "dma" }, };
arch/blackfin/mach-bf548/boards/ezkit.c +2 -0
@@ -587,11 +587,13 @@ static struct resource musb_resources[] .start = IRQ_USB_INT0, .end = IRQ_USB_INT0, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "mc" }, [2] = { /* DMA IRQ */ .start = IRQ_USB_DMA, .end = IRQ_USB_DMA, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "dma" }, };
drivers/usb/musb/cppi_dma.c +1 -1
@@ -1307,7 +1307,7 @@ dma_controller_create(struct musb *musb,struct cppi *controller;struct device *dev = musb->controller;struct platform_device *pdev =to_platform_device (dev); -int irq =platform_get_irq (pdev,1 ); +int irq =platform_get_irq_byname (pdev,"dma" ); controller =kzalloc (sizeof *controller,GFP_KERNEL );if (!controller)
drivers/usb/musb/musb_core.c +1 -1
@@ -2203,7 +2203,7 @@ static u64 *orig_dma_mask;static int __init musb_probe (struct platform_device *pdev) {struct device *dev = &pdev->dev; -int irq =platform_get_irq (pdev,0 ); +int irq =platform_get_irq_byname (pdev,"mc" );int status;struct resource *iomem;void __iomem *base;
drivers/usb/musb/musbhsdma.c +1 -1
@@ -363,7 +363,7 @@ dma_controller_create(struct musb *musb,struct musb_dma_controller *controller;struct device *dev = musb->controller;struct platform_device *pdev =to_platform_device (dev); -int irq =platform_get_irq (pdev,1 ); +int irq =platform_get_irq_byname (pdev,"dma" );if (irq ==0 ) {dev_err (dev,"No DMA interrupt line!\n" );
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 1285201631-26266-1-git-send-email-hemahk-l0cyMroinI0@public.gmane.org
Quoted 6 lines · Hema
Modified the Omap,Blackfin and Davinci board files to add the name of the IRQs in the resource structures and musb driver to use the
get_irq_byname()api to get the mc and dma irq numbers instead of using the index as the order of resource definition need not be always in order of device interrupt and then dma interrupt
Quoted 6 lines
Signed-off-by Hema HK <[email protected]>Cc Felipe Balbi <[email protected]>Cc Tony Lindgren <[email protected]>Cc Kevin Hilman <[email protected]>Cc Cousson, Benoit <[email protected]>Cc Paul Walmsley <[email protected]>
this is fine by me, but you need to Cc the other ARCH maintainers, Tony can answer for OMAP and Kevin for DaVinci, but where's Blackfin's maintainer ? Without all theirs ACKs for the arch-specific part, I can't queue this to .37 and it's already quite late. If we don't get all needed Acks by tomorrow, I doubt Greg will accept these for .37 merge window.
Signature · 5 lines
balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20100923061022.GA2563-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org
Hi,
Quoted 28 lines
-----Original Message-----
From: Balbi, Felipe
Sent: Thursday, September 23, 2010 11:40 AM
To: Kalliguddi, Hema
Cc: [email protected]; [email protected]; Balbi, Felipe; Tony Lindgren; Kevin Hilman; Cousson, Benoit;
Paul Walmsley
Subject: Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs
in resource structureQuoted 1 line · Hema
Modified the Omap,Blackfin and Davinci board files to add the
name of the IRQs
Quoted 1 line
in the resource structures and musb driver to use the
get_irq_byname()api toQuoted 1 line
get the mc and dma irq numbers instead of using the index as
the order of
Quoted 1 line
resource definition need not be always in order of device
interrupt and
Quoted 8 lines
then dma interrupt
Signed-off-by Hema HK <[email protected]>Cc Felipe Balbi <[email protected]>Cc Tony Lindgren <[email protected]>Cc Kevin Hilman <[email protected]>Cc Cousson, Benoit <[email protected]>Cc Paul Walmsley <[email protected]>
Quoted 8 lines
this is fine by me, but you need to Cc the other ARCH maintainers, Tony can answer for OMAP and Kevin for DaVinci, but where's Blackfin's maintainer ? Without all theirs ACKs for the arch-specific part, I can't
queue this to .37 and it's already quite late. If we don't get all needed Acks by tomorrow, I doubt Greg will accept these for .37 merge window.
I understand that. I forgot to Cc Mike for blackfin arch files change. I will post it again today Cc ing him and try my luck :-)
~Hema
Quoted 3 lines
Signature · 2 lines
balbi --
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): E0D41E29EB0DAC4E9F3FF173962E9E94027863D94D-/tLxBxkBPtCIQmiDNMet8wC/[email protected]
Hi,
Quoted 2 lines · Hema
I understand that. I forgot to Cc Mike for blackfin arch files change. I will post it again today Cc ing him and try my luck :-)
let's hope for the best, but while at that, would you take care of the comments on the other patches ?
Signature · 5 lines
balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
Quoted 10 lines
-----Original Message-----
From: Balbi, Felipe
Sent: Thursday, September 23, 2010 12:21 PM
To: Kalliguddi, Hema
Cc: Balbi, Felipe; [email protected]; [email protected]; Tony Lindgren; Kevin Hilman; Cousson, Benoit; Paul Walmsley
Subject: Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure
Quoted 8 lines
Hi,
Quoted 2 lines · Hema
I understand that. I forgot to Cc Mike for blackfin arch files change. I will post it again today Cc ing him and try my luck :-)
let's hope for the best, but while at that, would you take care of the comments on the other patches ?
I am trying my level best to incorporate all the comments today and post them.
Quoted 4 lines
Signature · 2 lines
-- balbi
Hi Mike,
Quoted 195 lines
-----Original Message-----
From: Kalliguddi, Hema
Sent: Thursday, September 23, 2010 5:57 AM
To: [email protected]; [email protected]
Cc: Kalliguddi, Hema; Balbi, Felipe; Tony Lindgren; Kevin
Hilman; Cousson, Benoit; Paul Walmsley
Subject: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in
resource structureModified the Omap,Blackfin and Davinci board files to add the name of the IRQs
in the resource structures and musb driver to use theget_irq_byname()api to
get the mc and dma irq numbers instead of using the index as the order of
resource definition need not be always in order of device interrupt and then dma interruptSigned-off-by Hema HK <[email protected]>Cc Felipe Balbi <[email protected]>Cc Tony Lindgren <[email protected]>Cc Kevin Hilman <[email protected]>Cc Cousson, Benoit <[email protected]>Cc Paul Walmsley <[email protected]>---
arch/arm/mach-davinci/usb.c | 2 ++ arch/arm/mach-omap2/usb-musb.c | 2 ++ arch/blackfin/mach-bf527/boards/cm_bf527.c | 2 ++ arch/blackfin/mach-bf527/boards/ezbrd.c | 2 ++ arch/blackfin/mach-bf527/boards/ezkit.c | 2 ++ arch/blackfin/mach-bf548/boards/cm_bf548.c | 2 ++ arch/blackfin/mach-bf548/boards/ezkit.c | 2 ++ drivers/usb/musb/cppi_dma.c | 2 +- drivers/usb/musb/musb_core.c | 2 +- drivers/usb/musb/musbhsdma.c | 2 +- 10 files changed, 17 insertions(+), 3 deletions(-)Index:
linux-omap-pm/arch/arm/mach-davinci/usb.c
===================================================================arch/arm/mach-davinci/usb.c +2
-0@@ -64,10 +64,12 @@ static struct resource usb_resources[] = { .start = IRQ_USBINT, .flags = IORESOURCE_IRQ, + .name = "mc" }, { /* placeholder for the dedicated CPPI IRQ */ .flags = IORESOURCE_IRQ, + .name = "dma" }, };Index:
linux-omap-pm/arch/arm/mach-omap2/usb-musb.c
===================================================================arch/arm/mach-omap2/usb-musb.c +2
-0@@ -39,10 +39,12 @@ static struct resource musb_resources[] [1 ] = {/* general IRQ */ .start =INT_243X_HS_USB_MC , .flags =IORESOURCE_IRQ , + .name ="mc" , }, [2 ] = {/* DMA IRQ */ .start =INT_243X_HS_USB_DMA , .flags =IORESOURCE_IRQ , + .name ="dma" , }, };Index:
linux-omap-pm/arch/blackfin/mach-bf527/boards/cm_bf527.c
===================================================================arch/blackfin/mach-bf527/boards/cm_bf527.c +2
-0@@ -82,11 +82,13 @@ static struct resource musb_resources[] .start = IRQ_USB_INT0, .end = IRQ_USB_INT0, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "mc" }, [2] = { /* DMA IRQ */ .start = IRQ_USB_DMA, .end = IRQ_USB_DMA, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "dma" }, };Index:
linux-omap-pm/arch/blackfin/mach-bf527/boards/ezbrd.c
===================================================================arch/blackfin/mach-bf527/boards/ezbrd.c +2
-0@@ -46,11 +46,13 @@ static struct resource musb_resources[] .start = IRQ_USB_INT0, .end = IRQ_USB_INT0, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "mc" }, [2] = { /* DMA IRQ */ .start = IRQ_USB_DMA, .end = IRQ_USB_DMA, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "dma" }, };Index:
linux-omap-pm/arch/blackfin/mach-bf527/boards/ezkit.c
===================================================================arch/blackfin/mach-bf527/boards/ezkit.c +2
-0@@ -86,11 +86,13 @@ static struct resource musb_resources[] .start = IRQ_USB_INT0, .end = IRQ_USB_INT0, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "mc" }, [2] = { /* DMA IRQ */ .start = IRQ_USB_DMA, .end = IRQ_USB_DMA, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "dma" }, };Index:
linux-omap-pm/arch/blackfin/mach-bf548/boards/cm_bf548.c
===================================================================arch/blackfin/mach-bf548/boards/cm_bf548.c +2
-0@@ -482,11 +482,13 @@ static struct resource musb_resources[] .start = IRQ_USB_INT0, .end = IRQ_USB_INT0, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "mc" }, [2] = { /* DMA IRQ */ .start = IRQ_USB_DMA, .end = IRQ_USB_DMA, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "dma" }, };Index:
linux-omap-pm/arch/blackfin/mach-bf548/boards/ezkit.c
===================================================================arch/blackfin/mach-bf548/boards/ezkit.c +2
-0@@ -587,11 +587,13 @@ static struct resource musb_resources[] .start = IRQ_USB_INT0, .end = IRQ_USB_INT0, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "mc" }, [2] = { /* DMA IRQ */ .start = IRQ_USB_DMA, .end = IRQ_USB_DMA, .flags = IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL, + .name = "dma" }, };Index:
linux-omap-pm/drivers/usb/musb/cppi_dma.c
===================================================================drivers/usb/musb/cppi_dma.c +1
-1@@ -1307,7 +1307,7 @@ dma_controller_create(struct musb *musb,struct cppi *controller;struct device *dev = musb->controller;struct platform_device *pdev =to_platform_device (dev); -int irq =platform_get_irq (pdev,1 ); +int irq =platform_get_irq_byname (pdev,"dma" ); controller =kzalloc (sizeof *controller,GFP_KERNEL );if (!controller)
Index:linux-omap-pm/drivers/usb/musb/musb_core.c
===================================================================drivers/usb/musb/musb_core.c +1
-1@@ -2203,7 +2203,7 @@ static u64 *orig_dma_mask;static int __init musb_probe (struct platform_device *pdev) {struct device *dev = &pdev->dev; -int irq =platform_get_irq (pdev,0 ); +int irq =platform_get_irq_byname (pdev,"mc" );int status;struct resource *iomem;void __iomem *base;Index:
linux-omap-pm/drivers/usb/musb/musbhsdma.c
===================================================================
drivers/usb/musb/musbhsdma.c dma_controller_create(struct musb *musb, · line 369
Quoted 8 lines
drivers/usb/musb/musbhsdma.c +1
-1@@ -363,7 +363,7 @@ dma_controller_create(struct musb *musb,struct musb_dma_controller *controller;struct device *dev = musb->controller;struct platform_device *pdev =to_platform_device (dev); -int irq =platform_get_irq (pdev,1 ); +int irq =platform_get_irq_byname (pdev,"dma" );if (irq ==0 ) {dev_err (dev,"No DMA interrupt line!\n" );
I am sorry I forgot to Cc you when I posted the patch. Please provide your comments on the changes.
Regards,
Hema
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 7 lines · Hema
From: Kalliguddi, Hema
Quoted 6 lines
Modified the Omap,Blackfin and Davinci board files to add the name of the IRQs
in the resource structures and musb driver to use theget_irq_byname()api to
get the mc and dma irq numbers instead of using the index as the order of
i dont see a problem with the existing code (going by index #), but i dont really care either way
Quoted 2 lines
Quoted 2 lines
resource definition need not be always in order of device interrupt and then dma interrupt
well, currently, your resource definition must always be in the order of dev int and then dma int. if it isnt, then i dont think musb is going to work.
not sure why you wouldnt simply change your platform resources to match the what the driver expects ...
-mike
A message that is not in the archive (sent off-list or not yet received): AANLkTim=ARtDA99XWP+RuB5nBh5FNAJHfSV34fiwtAk8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Hello Mike,
Quoted 6 lines · Mike Frysinger
well, currently, your resource definition must always be in the order of dev int and then dma int. if it isnt, then i dont think musb is going to work.
not sure why you wouldnt simply change your platform resources to match the what the driver expects ...
The resource data is getting automatically populated from a set of data generated from TI's hardware database for the OMAP platform, at least. While we could hack in some exceptions to that tool to generate resources in a specific order, it seems less fragile to use the resource name instead. That way, no matter what order the resources are generated, the driver should still work.
- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · Paul Walmsley
Quoted 6 lines · Mike Frysinger
well, currently, your resource definition must always be in the order of dev int and then dma int. if it isnt, then i dont think musb is going to work.
not sure why you wouldnt simply change your platform resources to match the what the driver expects ...
Quoted 6 lines
The resource data is getting automatically populated from a set of data generated from TI's hardware database for the OMAP platform, at least. While we could hack in some exceptions to that tool to generate resources in a specific order, it seems less fragile to use the resource name instead. That way, no matter what order the resources are generated, the driver should still work.
guessing you're not referring to a device tree setup, but something even more convoluted ?
i'd highly suggest that this patch be resent with the info you've just provided in its changelog so people can get a better understanding of the "why" ... i'm not against the patch, it just seemed to be lacking any background info
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 16 lines · Mike Frysinger
Quoted 8 lines · Paul Walmsley
Quoted 6 lines · Mike Frysinger
well, currently, your resource definition must always be in the order of dev int and then dma int. if it isnt, then i dont think musb is going to work.
not sure why you wouldnt simply change your platform resources to match the what the driver expects ...
Quoted 6 lines
The resource data is getting automatically populated from a set of data generated from TI's hardware database for the OMAP platform, at least. While we could hack in some exceptions to that tool to generate resources in a specific order, it seems less fragile to use the resource name instead. That way, no matter what order the resources are generated, the driver should still work.
Quoted 2 lines
guessing you're not referring to a device tree setup, but something even more convoluted ?
No need to disparage it before you've seen it :-)
Quoted 4 lines
i'd highly suggest that this patch be resent with the info you've just provided in its changelog so people can get a better understanding of the "why" ... i'm not against the patch, it just seemed to be lacking any background info
Hema, would you care to update the patch changelog accordingly?
- Paul
A message that is not in the archive (sent off-list or not yet received): alpine.DEB.2.00.1009281543290.5439-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org
Quoted 17 lines · Paul Walmsley
Quoted 16 lines · Mike Frysinger
Quoted 14 lines · Paul Walmsley
Quoted 6 lines · Mike Frysinger
well, currently, your resource definition must always be in the order of dev int and then dma int. if it isnt, then i dont think musb is going to work.
not sure why you wouldnt simply change your platform resources to match the what the driver expects ...
The resource data is getting automatically populated from a set of data generated from TI's hardware database for the OMAP platform, at least. While we could hack in some exceptions to that tool to generate resources in a specific order, it seems less fragile to use the resource name instead. That way, no matter what order the resources are generated, the driver should still work.
Quoted 4 lines
Quoted 2 lines
guessing you're not referring to a device tree setup, but something even more convoluted ?
No need to disparage it before you've seen it :-)
ah, but that's when i do my best work
Quoted 6 lines
Quoted 4 lines
i'd highly suggest that this patch be resent with the info you've just provided in its changelog so people can get a better understanding of the "why" ... i'm not against the patch, it just seemed to be lacking any background info
Hema, would you care to update the patch changelog accordingly?
i'll pre-ack that for the Blackfin changes ... or, if you split those out, i can merge it separately for 2.6.37.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): AANLkTi=77B2ntuJG7=J-g9GrcrJsWKUy6YbW0gm=MUQJ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Hi,
Quoted 47 lines
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Mike Frysinger
Sent: Wednesday, September 29, 2010 3:18 AM
To: Paul Walmsley
Cc: Kalliguddi, Hema; [email protected]; [email protected]; Balbi, Felipe; Tony Lindgren; Kevin
Hilman; Cousson, Benoit
Subject: Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs
in resource structureQuoted 4 lines · Paul Walmsley
Quoted 3 lines · Mike Frysinger
Quoted 2 lines · Paul Walmsley
Quoted 1 line · Mike Frysinger
well, currently, your resource definition must always be
in the order
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
of dev int and then dma int. if it isnt, then i dont
think musb is
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
going to work.
not sure why you wouldnt simply change your platform resources to match the what the driver expects ...
The resource data is getting automatically populated from
a set of data
Quoted 1 line
Quoted 1 line
Quoted 1 line
generated from TI's hardware database for the OMAP
platform, at least.
Quoted 1 line
Quoted 1 line
Quoted 1 line
While we could hack in some exceptions to that tool to
generate resources
Quoted 1 line
Quoted 1 line
Quoted 1 line
in a specific order, it seems less fragile to use the
resource name
Quoted 1 line
Quoted 1 line
Quoted 1 line
instead. That way, no matter what order the resources
are generated, the
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
driver should still work.
guessing you're not referring to a device tree setup, but something even more convoluted ?
No need to disparage it before you've seen it :-)
ah, but that's when i do my best work
Quoted 1 line
Quoted 1 line
i'd highly suggest that this patch be resent with the info
you've just
Quoted 1 line
Quoted 1 line
provided in its changelog so people can get a better
understanding of
Quoted 8 lines
Quoted 1 line
Quoted 1 line
the "why" ... i'm not against the patch, it just seemed to
be lacking
Quoted 3 lines
Quoted 1 line
any background info
Hema, would you care to update the patch changelog accordingly?
i'll pre-ack that for the Blackfin changes ... or, if you split those out, i can merge it separately for 2.6.37.
I will repost the patches today for blackfin and omap changes with the changelog updated accordingly.
Quoted 2 lines
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): E0D41E29EB0DAC4E9F3FF173962E9E9402DB7FE166-/tLxBxkBPtCIQmiDNMet8wC/[email protected]
Hi,
Quoted 2 lines · Hema
I will repost the patches today for blackfin and omap changes with the changelog updated accordingly.
Have you re-sent the patches ? I just want to know if we're gonna merge it through Greg or the patch will be split and merged through ARCH trees.
Each way if fine by me, but 2.6.37 is getting really close.
Signature · 5 lines
balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Felipe,
Quoted 14 lines
-----Original Message-----
From: Balbi, Felipe
Sent: Wednesday, September 29, 2010 12:01 PM
To: Kalliguddi, Hema
Cc: Mike Frysinger; Paul Walmsley; [email protected]; [email protected]; Balbi, Felipe; Tony Lindgren; Kevin Hilman; Cousson, Benoit
Subject: Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structureHi,
Quoted 1 line · Hema
I will repost the patches today for blackfin and omap changes
Quoted 9 lines
with the changelog
Quoted 1 line
updated accordingly.
Have you re-sent the patches ? I just want to know if we're gonna merge it through Greg or the patch will be split and merged through ARCH trees.
Each way if fine by me, but 2.6.37 is getting really close.
Then I will send a patch with changelog updated soon.
Quoted 3 lines
Signature · 1 line
balbi