Skip to contentSkip to conversation

staging: tidspbridge: disable all peripherals at bridge_brd_stop

PATCH In review Ernesto Ramos 2 participants 2 messages Sep 24, 2010 – Sep 30, 2010 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: tidspbridge: disable all peripherals at bridge_brd_stop

DSP Bridge needs to disable the peripheral clocks when switches to BRD_STOPPED since that would prevent the domain to enter in OFF state.

---
 drivers/staging/tidspbridge/core/tiomap3430.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/staging/tidspbridge/core/tiomap3430.c +3 -2
index 0e3558a..8b73ac9 100644
@@ -552,7 +552,7 @@ static int bridge_brd_stop(struct bridge_dev_context *dev_ctxt)
 	int status = 0;
 	struct bridge_dev_context *dev_context = dev_ctxt;
 	u32 dsp_pwr_state;
-	int clk_status, i;
+	int i;
 	struct bridge_ioctl_extproc *tlb = dev_context->atlb_entry;
 	struct dspbridge_platform_data *pdata =
 				omap_dspbridge_dev->dev.platform_data;
@@ -621,7 +621,8 @@ static int bridge_brd_stop(struct bridge_dev_context *dev_ctxt)
 	(*pdata->dsp_prm_rmw_bits)(OMAP3430_RST2_IVA2_MASK,
 		OMAP3430_RST2_IVA2_MASK, OMAP3430_IVA2_MOD, OMAP2_RM_RSTCTRL);
 
-	clk_status = dsp_clk_disable(DSP_CLK_IVA2);
+	dsp_clock_disable_all(dev_context->dsp_per_clks);
+	dsp_clk_disable(DSP_CLK_IVA2);
 
 	return status;
 }
Signature · 1 line
1.5.4.5
#1 lore raw
Quoted 5 lines · Ernesto Ramos

DSP Bridge needs to disable the peripheral clocks when switches to BRD_STOPPED since that would prevent the domain to enter in OFF state.

This patch doesn't apply to the latest linux-next tree, what did you make it against?

Care to fix it up and resend it?

thanks,

greg k-h