KVM test: Make vm.serial_login() work

PATCH In review Lucas Meneghel Rodrigues 2 participants 2 messages Sep 27, 2010 KVM

Share & tools

Lucas Meneghel Rodrigues

author

2010-09-27 11:04 UTC #0 lore raw

PATCH 1/1 KVM test: Make vm.serial_login() work

We had our guests configured wrong with regards to serial port setup, in order to have a getty attached to the serial port the order of the kernel arguments has to be:

console=tty0 console=ttyS0,115200

instead of:

console=ttyS0,115200 console=tty0

Fixing it in all linux guests unattended files.

Signed-off-by Jason Wang <[email protected]>

---
 client/tests/kvm/unattended/Fedora-10.ks     |    2 +-
 client/tests/kvm/unattended/Fedora-11.ks     |    2 +-
 client/tests/kvm/unattended/Fedora-12.ks     |    2 +-
 client/tests/kvm/unattended/Fedora-13.ks     |    2 +-
 client/tests/kvm/unattended/Fedora-8.ks      |    2 +-
 client/tests/kvm/unattended/Fedora-9.ks      |    2 +-
 client/tests/kvm/unattended/OpenSUSE-11.xml  |    2 +-
 client/tests/kvm/unattended/RHEL-3-series.ks |    2 +-
 client/tests/kvm/unattended/RHEL-4-series.ks |    2 +-
 client/tests/kvm/unattended/RHEL-5-series.ks |    2 +-
 client/tests/kvm/unattended/SLES-11.xml      |    2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)

client/tests/kvm/unattended/Fedora-10.ks +1 -1

index 03163c3..26965af 100644
@@ -11,7 +11,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200 console=tty0"
+bootloader --location=mbr --append="console=tty0 console=ttyS0,115200"
 zerombr
 clearpart --all --initlabel
 autopart

client/tests/kvm/unattended/Fedora-11.ks +1 -1

index 443e2c3..861546b 100644
@@ -10,7 +10,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200 console=tty0"
+bootloader --location=mbr --append="console=tty0 console=ttyS0,115200"
 zerombr
 
 clearpart --all --initlabel

client/tests/kvm/unattended/Fedora-12.ks +1 -1

index 443e2c3..861546b 100644
@@ -10,7 +10,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200 console=tty0"
+bootloader --location=mbr --append="console=tty0 console=ttyS0,115200"
 zerombr
 
 clearpart --all --initlabel

client/tests/kvm/unattended/Fedora-13.ks +1 -1

index ef978e8..0949e40 100644
@@ -10,7 +10,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200 console=tty0"
+bootloader --location=mbr --append="console=tty0 console=ttyS0,115200"
 zerombr
 
 clearpart --all --initlabel

client/tests/kvm/unattended/Fedora-8.ks +1 -1

index 3e9d387..92ff727 100644
@@ -11,7 +11,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200 console=tty0"
+bootloader --location=mbr --append="console=tty0 console=ttyS0,115200"
 zerombr
 clearpart --all --initlabel
 autopart

client/tests/kvm/unattended/Fedora-9.ks +1 -1

index 3e9d387..92ff727 100644
@@ -11,7 +11,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200 console=tty0"
+bootloader --location=mbr --append="console=tty0 console=ttyS0,115200"
 zerombr
 clearpart --all --initlabel
 autopart

client/tests/kvm/unattended/OpenSUSE-11.xml +1 -1

index 64140bf..0ade836 100644
@@ -50,7 +50,7 @@
         <module>edd</module>
       </initrd_module>
     </initrd_modules>
-    <append>console=ttyS0,115200 console=tty0</append>
+    <append>console=tty0 console=ttyS0,115200</append>
     <loader_type>grub</loader_type>
     <sections config:type="list"/>
   </bootloader>

client/tests/kvm/unattended/RHEL-3-series.ks +1 -1

index 413890a..79d9605 100644
@@ -10,7 +10,7 @@ rootpw 123456
 firewall --enabled --ssh
 timezone America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200 console=tty0"
+bootloader --location=mbr --append="console=tty0 console=ttyS0,115200"
 clearpart --all --initlabel
 autopart
 reboot

client/tests/kvm/unattended/RHEL-4-series.ks +1 -1

index 213914d..d791e0f 100644
@@ -11,7 +11,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200 console=tty0"
+bootloader --location=mbr --append="console=tty0 console=ttyS0,115200"
 zerombr
 clearpart --all --initlabel
 autopart

client/tests/kvm/unattended/RHEL-5-series.ks +1 -1

index 3e9d387..92ff727 100644
@@ -11,7 +11,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200 console=tty0"
+bootloader --location=mbr --append="console=tty0 console=ttyS0,115200"
 zerombr
 clearpart --all --initlabel
 autopart

client/tests/kvm/unattended/SLES-11.xml +1 -1

index 61151d9..c694a31 100644
@@ -49,7 +49,7 @@
         <module>edd</module>
       </initrd_module>
     </initrd_modules>
-    <append>console=ttyS0,115200 console=tty0</append>
+    <append>console=tty0 console=ttyS0,115200</append>
     <loader_type>grub</loader_type>
     <sections config:type="list"/>
   </bootloader>

Signature · 1 line

1.7.2.3

Jason Wang

2010-09-27 13:11 UTC #1 lore raw

This bug was caused by a defect patch I sent previously. I would pay more attention in the future. Thanks lucas.

Quoted 202 lines · ----- "Lucas Meneghel Rodrigues

We had our guests configured wrong with regards to serial port setup, in order to have a getty attached to the serial port the order of the kernel arguments has to be:
console=tty0 console=ttyS0,115200
instead of:
console=ttyS0,115200 console=tty0
Fixing it in all linux guests unattended files.
Signed-off-by Jason Wang <[email protected]>
---
 client/tests/kvm/unattended/Fedora-10.ks     |    2 +-
 client/tests/kvm/unattended/Fedora-11.ks     |    2 +-
 client/tests/kvm/unattended/Fedora-12.ks     |    2 +-
 client/tests/kvm/unattended/Fedora-13.ks     |    2 +-
 client/tests/kvm/unattended/Fedora-8.ks      |    2 +-
 client/tests/kvm/unattended/Fedora-9.ks      |    2 +-
 client/tests/kvm/unattended/OpenSUSE-11.xml  |    2 +-
 client/tests/kvm/unattended/RHEL-3-series.ks |    2 +-
 client/tests/kvm/unattended/RHEL-4-series.ks |    2 +-
 client/tests/kvm/unattended/RHEL-5-series.ks |    2 +-
 client/tests/kvm/unattended/SLES-11.xml      |    2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)
client/tests/kvm/unattended/Fedora-10.ks +0 -1
index 03163c3..26965af 100644
@@ -11,7 +11,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200
console=tty0"
+bootloader --location=mbr --append="console=tty0
console=ttyS0,115200"
zerombr
clearpart --all --initlabel
autopart
client/tests/kvm/unattended/Fedora-11.ks +0 -1
index 443e2c3..861546b 100644
@@ -10,7 +10,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200
console=tty0"
+bootloader --location=mbr --append="console=tty0
console=ttyS0,115200"
zerombr
clearpart --all --initlabel
client/tests/kvm/unattended/Fedora-12.ks +0 -1
index 443e2c3..861546b 100644
@@ -10,7 +10,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200
console=tty0"
+bootloader --location=mbr --append="console=tty0
console=ttyS0,115200"
zerombr
clearpart --all --initlabel
client/tests/kvm/unattended/Fedora-13.ks +0 -1
index ef978e8..0949e40 100644
@@ -10,7 +10,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200
console=tty0"
+bootloader --location=mbr --append="console=tty0
console=ttyS0,115200"
zerombr
clearpart --all --initlabel
client/tests/kvm/unattended/Fedora-8.ks +0 -1
index 3e9d387..92ff727 100644
@@ -11,7 +11,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200
console=tty0"
+bootloader --location=mbr --append="console=tty0
console=ttyS0,115200"
zerombr
clearpart --all --initlabel
autopart
client/tests/kvm/unattended/Fedora-9.ks +0 -1
index 3e9d387..92ff727 100644
@@ -11,7 +11,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200
console=tty0"
+bootloader --location=mbr --append="console=tty0
console=ttyS0,115200"
zerombr
clearpart --all --initlabel
autopart
client/tests/kvm/unattended/OpenSUSE-11.xml +1 -1
index 64140bf..0ade836 100644
@@ -50,7 +50,7 @@
         <module>edd</module>
       </initrd_module>
     </initrd_modules>
-    <append>console=ttyS0,115200 console=tty0</append>
+    <append>console=tty0 console=ttyS0,115200</append>
     <loader_type>grub</loader_type>
     <sections config:type="list"/>
   </bootloader>
client/tests/kvm/unattended/RHEL-3-series.ks +0 -1
index 413890a..79d9605 100644
@@ -10,7 +10,7 @@ rootpw 123456
 firewall --enabled --ssh
 timezone America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200
console=tty0"
+bootloader --location=mbr --append="console=tty0
console=ttyS0,115200"
clearpart --all --initlabel
autopart
reboot
client/tests/kvm/unattended/RHEL-4-series.ks +0 -1
index 213914d..d791e0f 100644
@@ -11,7 +11,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200
console=tty0"
+bootloader --location=mbr --append="console=tty0
console=ttyS0,115200"
zerombr
clearpart --all --initlabel
autopart
client/tests/kvm/unattended/RHEL-5-series.ks +0 -1
index 3e9d387..92ff727 100644
@@ -11,7 +11,7 @@ firewall --enabled --ssh
 selinux --enforcing
 timezone --utc America/New_York
 firstboot --disable
-bootloader --location=mbr --append="console=ttyS0,115200
console=tty0"
+bootloader --location=mbr --append="console=tty0
console=ttyS0,115200"
zerombr
clearpart --all --initlabel
autopart
client/tests/kvm/unattended/SLES-11.xml +1 -1
index 61151d9..c694a31 100644
@@ -49,7 +49,7 @@
         <module>edd</module>
       </initrd_module>
     </initrd_modules>
-    <append>console=ttyS0,115200 console=tty0</append>
+    <append>console=tty0 console=ttyS0,115200</append>
     <loader_type>grub</loader_type>
     <sections config:type="list"/>
   </bootloader>
Signature · 1 line
1.7.2.3