Skip to contentSkip to conversation

staging: otus: use free_netdev(netdev) instead of kfree()

PATCH In review Vasiliy Kulikov 1 participant 1 message Sep 28, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 7/9 staging: otus: use free_netdev(netdev) instead of kfree()

Freeing netdev without free_netdev() leads to net, tx leaks. I might lead to dereferencing freed pointer.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

@@
struct net_device* dev;
@@

-kfree(dev)
+free_netdev(dev)

---
Compile tested.

 drivers/staging/otus/usbdrv.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/otus/usbdrv.c +1 -1
index 165a82b..9a5c415 100644
@@ -690,7 +690,7 @@ void usbdrv_clear_structs(struct net_device *dev)
 
     kfree(macp);
 
-    kfree(dev);
+    free_netdev(dev);
 
 }
 
Signature · 1 line
1.7.0.4