drivers:staging:ti-st: mv ti_wilink_st header
PATCH 1/1 drivers:staging:ti-st: mv ti_wilink_st header
From: Pavan Savoy <[email protected]>
Greg,
How is the movement of drivers done out of staging?
Should I submit patches like these, which move individual files without breaking the build during anytime of movement?
In few following days I plan to submit patches to move the ST headers sources out.ti_wilink_st.h -> include/linux/st_core.c, st_kim.c and st_ll.c -> drivers/misc/Makefile and Kconfig changes to drivers/misc/Kconfig and drivers/misc/Makefile bt_drv.c -> drivers/bluetooth/
Please suggest,
Alan,
I would be thrilled if you ack-ed this too.
Thanks & Regards,
Pavan Savoy
-- patch description --
Move the header to a standard linux device driver location. This should pave the way for other drivers to be moved into the relevant directories.
ti_wilink_st.h is a common header file used by the TI's shared transport device driver for WiLink chipsets. Each individual protocol drivers like bluetooth driver, FM V4L2 driver and GPS drivers will make use of this header.
--- drivers/staging/ti-st/bt_drv.c | 2 +- drivers/staging/ti-st/st_core.c | 2 +- drivers/staging/ti-st/st_kim.c | 2 +- drivers/staging/ti-st/st_ll.c | 2 +- drivers/staging/ti-st/ti_wilink_st.h | 409 ---------------------------------- include/linux/ti_wilink_st.h | 409 ++++++++++++++++++++++++++++++++++ 6 files changed, 413 insertions(+), 413 deletions(-) delete mode 100644 drivers/staging/ti-st/ti_wilink_st.h create mode 100644 include/linux/ti_wilink_st.h
drivers/staging/ti-st/bt_drv.c +1 -1
@@ -24,7 +24,7 @@#include <net/bluetooth/bluetooth.h> #include <net/bluetooth/hci_core.h> -#include "ti_wilink_st.h" +#include <linux/ti_wilink_st.h> #include "bt_drv.h" /* Define this macro to get debug msg */
drivers/staging/ti-st/st_core.c +1 -1
@@ -28,7 +28,7 @@#include <net/bluetooth/bluetooth.h> #include <net/bluetooth/hci_core.h> #include <net/bluetooth/hci.h> -#include "ti_wilink_st.h" +#include <linux/ti_wilink_st.h> /* strings to be used for rfkill entries and by * ST Core to be used for sysfs debug entry
drivers/staging/ti-st/st_kim.c +1 -1
@@ -36,7 +36,7 @@#include <net/bluetooth/hci_core.h> #include <net/bluetooth/hci.h> -#include "ti_wilink_st.h" +#include <linux/ti_wilink_st.h> static int kim_probe (struct platform_device *pdev);
drivers/staging/ti-st/st_ll.c +1 -1
@@ -21,7 +21,7 @@#define pr_fmt (fmt) "(stll) :" fmt#include <linux/skbuff.h> #include <linux/module.h> -#include "ti_wilink_st.h" +#include <linux/ti_wilink_st.h> /**********************************************************************/ /* internal functions */
drivers/staging/ti-st/ti_wilink_st.h deleted +0 -409
409 lines not on this page · raw message
include/linux/ti_wilink_st.h new file +409 -0
409 lines not on this page · raw message
Signature · 1 line
1.6.5
Quoted 7 lines · On Wed, Sep 29, 2010 at 12:25:22PM -0400, [email protected] wrote:
From: Pavan Savoy <[email protected]>
Greg,
How is the movement of drivers done out of staging?
Should I submit patches like these, which move individual files without breaking the build during anytime of movement?
Yes.
Quoted 6 lines
In few following days I plan to submit patches to move the ST headers sources out.
ti_wilink_st.h->include/linux/st_core.c,st_kim.candst_ll.c->drivers/misc/MakefileandKconfigchanges todrivers/misc/Kconfiganddrivers/misc/Makefilebt_drv.c->drivers/bluetooth/
Yes, that sounds great.
But, the bluetooth patch should go to the bluetooth maintainer for his review, I'll need the ack from him before I can apply it.
Oh, this patch looks nice, but I found one problem:
drivers/staging/ti-st/ti_wilink_st.h line 31
Quoted 9 lines
drivers/staging/ti-st/ti_wilink_st.h deleted +0
-7-#ifndef TI_WILINK_ST_H -#define TI_WILINK_ST_H - -/* TODO: -* Move the following to tty.h upon acceptance -*/ -#define N_TI_WL 22/* Ldisc for TI's WL BT, FM, GPS combo chips */
We need to do that now, before you move this file.
Then, you can drop this:
Quoted 1 line
-#ifdef
__KERNEL__
As it will not be needed, right?
Care to send me a patch that does this first?
thanks,
greg k-h
Greg,
Quoted 25 lines
-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Thursday, September 30, 2010 6:51 AM
To: Savoy, Pavan
Cc: [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] drivers:staging:ti-st: mvti_wilink_stheaderQuoted 7 lines · On Wed, Sep 29, 2010 at 12:25:22PM -0400, [email protected] wrote:
From: Pavan Savoy <[email protected]>
Greg,
How is the movement of drivers done out of staging?
Should I submit patches like these, which move individual files without breaking the build during anytime of movement?Yes.
Quoted 1 line
In few following days I plan to submit patches to move the ST headers
sources
Quoted 4 lines
out.
ti_wilink_st.h->include/linux/st_core.c,st_kim.candst_ll.c->drivers/misc/MakefileandKconfigchanges todrivers/misc/Kconfigand
Quoted 7 lines
drivers/misc/MakefileQuoted 1 line
bt_drv.c->drivers/bluetooth/Yes, that sounds great.
But, the bluetooth patch should go to the bluetooth maintainer for his review, I'll need the ack from him before I can apply it.
Yes, I will loop in linux-bluetooth and Marcel when I post the Bluetooth driver patch, he has been already introduced to ST, so hopefully the transition is smoother.
Quoted 14 lines
Oh, this patch looks nice, but I found one problem:
drivers/staging/ti-st/ti_wilink_st.h line 31
Quoted 9 lines
drivers/staging/ti-st/ti_wilink_st.h deleted +0
-7-#ifndef TI_WILINK_ST_H -#define TI_WILINK_ST_H - -/* TODO: -* Move the following to tty.h upon acceptance -*/ -#define N_TI_WL 22/* Ldisc for TI's WL BT, FM, GPS combo chips */ We need to do that now, before you move this file.
Quoted 7 lines
Then, you can drop this:
Quoted 1 line
-#ifdef
__KERNEL__As it will not be needed, right?
Care to send me a patch that does this first?
Yes, sending it right away.
Quoted 3 lines
thanks,
greg k-h