Skip to contentSkip to conversation

scsi.c - cache ID bug

PATCH In review Aleš Nesrsta 2 participants 3 messages Oct 1, 2010 – Oct 2, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi.c - cache ID bug

Hi,

I have problem with multi-lun devices in some cases.

I found small bug in "old" problem solution of SCSI cache ID in trunk - see attached patch which should solve it.

Regards
Ales

grub_patched/include/grub/scsi.h renamed from grub/include/grub/scsi.h +1 -1
@@ -40,7 +40,7 @@ static inline grub_uint32_t
 grub_make_scsi_id (int subsystem, int bus, int lun)
 {
   return (subsystem << GRUB_SCSI_ID_SUBSYSTEM_SHIFT)
-    | (bus << GRUB_SCSI_ID_BUS_SHIFT) | (lun << GRUB_SCSI_ID_BUS_SHIFT);
+    | (bus << GRUB_SCSI_ID_BUS_SHIFT) | (lun << GRUB_SCSI_ID_LUN_SHIFT);
 }
 
 struct grub_scsi_dev
#1 lore raw
Quoted 8 lines · Aleš Nesrsta

Hi,

I have problem with multi-lun devices in some cases.

I found small bug in "old" problem solution of SCSI cache ID in trunk - see attached patch which should solve it.

Go ahead

Quoted 11 lines

Regards
Ales

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

Signature · 2 lines
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
#2 lore raw
Quoted 5 lines · Vladimir 'φ-coder/phcoder' Serbinenko
Quoted 4 lines

I found small bug in "old" problem solution of SCSI cache ID in trunk - see attached patch which should solve it.

Go ahead

Done, revision 2874.