Skip to contentSkip to conversation

usb: gadget: amd5536udc: Fix error path

PATCH In review Rahul Ruikar 2 participants 2 messages Oct 2, 2010 – Oct 4, 2010 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: gadget: amd5536udc: Fix error path

In function udc_probe()
call put_device() when device_register() fails.

---
 drivers/usb/gadget/amd5536udc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/usb/gadget/amd5536udc.c +3 -1
index 731150d4..950ee33 100644
@@ -3382,8 +3382,10 @@ static int udc_probe(struct udc *dev)
 	udc = dev;
 
 	retval = device_register(&dev->gadget.dev);
-	if (retval)
+	if (retval) {
+		put_device(&dev->gadget.dev);
 		goto finished;
+	}
 
 	/* timer init */
 	init_timer(&udc_timer);
Signature · 1 line
1.7.2.3
#1 lore raw

ACK

Thanks for the fix!

Thomas

Quoted 25 lines · Rahul Ruikar

In function udc_probe()
call put_device() when device_register() fails.

---
  drivers/usb/gadget/amd5536udc.c |    4 +++-
  1 files changed, 3 insertions(+), 1 deletions(-)
drivers/usb/gadget/amd5536udc.c +3 -1
index 731150d4..950ee33 100644
@@ -3382,8 +3382,10 @@ static int udc_probe(struct udc *dev)
  	udc = dev;
 
  	retval = device_register(&dev->gadget.dev);
-	if (retval)
+	if (retval) {
+		put_device(&dev->gadget.dev);
  		goto finished;
+	}
 
  	/* timer init */
  	init_timer(&udc_timer);