MCE decoding on F14h
Subsystems (2)
cover MCE decoding on F14h
From: Borislav Petkov <[email protected]>
Hi,
continuing the EDAC series from last week
(http://marc.info/?l=linux-kernel&m=128584454524242&w=2), here's an add-on set which adds MCE decoding for AMD F14h, models 0x0-0xf CPUs on top of the previous patchqueue. Another change from last week is that we decided to turn-off building the MCE injection module by default so that it can be enabled explicitly by distro kernels only (or other curious individuals who have a lot of time on their hands).
Whole series at git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git for-next
Thanks,
Boris.
PATCH 1/8 EDAC, MCE: Rework MCE injection
From: Borislav Petkov <[email protected]>
Add sysfs injection facilities for testing of the MCE decoding code. Remove large parts of amd64_edac_dbg.c, as a result, which did only NB MCE injection anyway and the new injection code supports that functionality already.
Add an injection module so that MCE decoding code in production kernels like those in RHEL and SLES can be tested.
--- drivers/edac/Kconfig | 14 +++- drivers/edac/Makefile | 2 + drivers/edac/amd64_edac.h | 2 +- drivers/edac/amd64_edac_dbg.c | 213 +++-------------------------------------- drivers/edac/edac_mce_amd.c | 4 +- drivers/edac/edac_mce_amd.h | 4 +- drivers/edac/mce_amd_inj.c | 171 +++++++++++++++++++++++++++++++++ 7 files changed, 203 insertions(+), 207 deletions(-) create mode 100644 drivers/edac/mce_amd_inj.c
drivers/edac/Kconfig +12 -2
@@ -39,7 +39,7 @@ config EDAC_DEBUG there're four debug levels (x=0,1,2,3 from low to high). Usually you should select 'N'. - config EDAC_DECODE_MCE +config EDAC_DECODE_MCE tristate "Decode MCEs in human-readable form (only on AMD for now)" depends on CPU_SUP_AMD && X86_MCE default y
@@ -51,6 +51,16 @@ config EDAC_DEBUG which occur really early upon boot, before the module infrastructure has been initialized. +config EDAC_MCE_INJ + tristate "Simple MCE injection interface over /sysfs" + depends on EDAC_DECODE_MCE + default n + help + This is a simple interface to inject MCEs over /sysfs and test + the MCE decoding code in EDAC. + + This is currently AMD-only. + config EDAC_MM_EDAC tristate "Main Memory EDAC (Error Detection And Correction) reporting" help
@@ -72,7 +82,7 @@ config EDAC_AMD64 Families of Memory Controllers (K8, F10h and F11h) config EDAC_AMD64_ERROR_INJECTION - bool "Sysfs Error Injection facilities" + bool "Sysfs HW Error injection facilities" depends on EDAC_AMD64 help Recent Opterons (Family 10h and later) provide for Memory Error
drivers/edac/Makefile +2 -0
@@ -17,6 +17,8 @@ ifdef CONFIG_PCI edac_core-objs += edac_pci.o edac_pci_sysfs.o endif +obj-$(CONFIG_EDAC_MCE_INJ) += mce_amd_inj.o + obj-$(CONFIG_EDAC_DECODE_MCE) += edac_mce_amd.o obj-$(CONFIG_EDAC_AMD76X) += amd76x_edac.o
drivers/edac/amd64_edac.h +1 -1
@@ -486,7 +486,7 @@ extern const char *ext_msgs[32];extern const char *htlink_msgs[8 ];#ifdef CONFIG_EDAC_DEBUG -#define NUM_DBG_ATTRS 9 +#define NUM_DBG_ATTRS 5#else #define NUM_DBG_ATTRS 0#endif
drivers/edac/amd64_edac_dbg.c +12 -201
244 lines not on this page · raw message
drivers/edac/edac_mce_amd.c +2 -2
@@ -324,8 +324,7 @@ static inline void amd_decode_err_code(u16 ec)pr_emerg (HW_ERR "Huh? Unknown MCE error 0x%x\n" , ec); } -static int amd_decode_mce (struct notifier_block *nb,unsigned long val, -void *data) +int amd_decode_mce (struct notifier_block *nb,unsigned long val,void *data) {struct mce *m = (struct mce *)data;int node, ecc;
@@ -379,6 +378,7 @@ static int amd_decode_mce(struct notifier_block *nb, unsigned long val,return NOTIFY_STOP ; } +EXPORT_SYMBOL_GPL (amd_decode_mce);static struct notifier_block amd_mce_dec_nb = { .notifier_call = amd_decode_mce,
drivers/edac/edac_mce_amd.h +3 -1
@@ -1,6 +1,8 @@#ifndef _EDAC_MCE_AMD_H#define _EDAC_MCE_AMD_H +#include <linux/notifier.h> +#include <asm/mce.h> #define ERROR_CODE (x) ((x) & 0xffff)
@@ -61,10 +63,10 @@ struct err_regs { u32 nbeal; }; -void amd_report_gart_errors (bool );void amd_register_ecc_decoder (void (*f)(int ,struct mce *,u32 ));void amd_unregister_ecc_decoder (void (*f)(int ,struct mce *,u32 ));void amd_decode_nb_mce (int ,struct mce *,u32 ); +int amd_decode_mce (struct notifier_block *nb,unsigned long val,void *data);#endif /* _EDAC_MCE_AMD_H */
drivers/edac/mce_amd_inj.c new file +171 -0
171 lines not on this page · raw message
Signature · 1 line
1.7.3.1.50.g1e633
PATCH 2/8 EDAC, MCE: Rename files
In reply to Borislav PetkovFrom: Borislav Petkov <[email protected]>
Drop "edac_" string from the filenames since they're prefixed with edac/ in their pathname anyway.
--- drivers/edac/Makefile | 1 + drivers/edac/amd64_edac.h | 2 +- drivers/edac/edac_mce_amd.c | 414 ------------------------------------------- drivers/edac/edac_mce_amd.h | 72 -------- drivers/edac/mce_amd.c | 414 +++++++++++++++++++++++++++++++++++++++++++ drivers/edac/mce_amd.h | 72 ++++++++ drivers/edac/mce_amd_inj.c | 2 +- 7 files changed, 489 insertions(+), 488 deletions(-) delete mode 100644 drivers/edac/edac_mce_amd.c delete mode 100644 drivers/edac/edac_mce_amd.h create mode 100644 drivers/edac/mce_amd.c create mode 100644 drivers/edac/mce_amd.h
drivers/edac/Makefile +1 -0
@@ -19,6 +19,7 @@ endif obj-$(CONFIG_EDAC_MCE_INJ) += mce_amd_inj.o +edac_mce_amd-objs := mce_amd.o obj-$(CONFIG_EDAC_DECODE_MCE) += edac_mce_amd.o obj-$(CONFIG_EDAC_AMD76X) += amd76x_edac.o
drivers/edac/amd64_edac.h +1 -1
@@ -72,7 +72,7 @@#include <linux/edac.h> #include <asm/msr.h> #include "edac_core.h" -#include "edac_mce_amd.h" +#include "mce_amd.h" #define amd64_printk(level, fmt, arg...) \ edac_printk(level, "amd64", fmt, ##arg)
drivers/edac/edac_mce_amd.c deleted +0 -414
414 lines not on this page · raw message
drivers/edac/edac_mce_amd.h deleted +0 -72
72 lines not on this page · raw message
drivers/edac/mce_amd.c new file +414 -0
414 lines not on this page · raw message
drivers/edac/mce_amd.h new file +72 -0
72 lines not on this page · raw message
drivers/edac/mce_amd_inj.c +1 -1
@@ -15,7 +15,7 @@#include <linux/edac.h> #include <asm/mce.h> -#include "edac_mce_amd.h" +#include "mce_amd.h" struct edac_mce_attr {struct attribute attr;
Signature · 1 line
1.7.3.1.50.g1e633
PATCH 3/8 EDAC, MCE: Adjust DC decoders to F14h
In reply to Borislav PetkovFrom: Borislav Petkov <[email protected]>
Add a per-family data cache decoders. Since there is a certain overlap between the different DC MCE signatures, reuse functionality between the families as far as possible.
--- drivers/edac/mce_amd.c | 162 ++++++++++++++++++++++++++++++++++++++++-------- drivers/edac/mce_amd.h | 40 ++++++++++++ 2 files changed, 175 insertions(+), 27 deletions(-)
drivers/edac/mce_amd.c +135 -27
@@ -1,6 +1,10 @@#include <linux/module.h> +#include <linux/slab.h> +#include "mce_amd.h" +static struct amd_decoder_ops *fam_ops; +static bool report_gart_errors;static void (*nb_bus_decoder)(int node_id,struct mce *m,u32 nbcfg);
@@ -97,41 +101,120 @@ const char *ext_msgs[] = { };EXPORT_SYMBOL_GPL (ext_msgs); -static void amd_decode_dc_mce (struct mce *m) +static bool f10h_dc_mce (u16 ec) { -u32 ec = m->status &0xffff ; -u32 xec = (m->status >>16 ) &0xf ; +u8 r4 = (ec >>4 ) &0xf ; +bool ret = false; -pr_emerg (HW_ERR "Data Cache Error: " ); +if (r4 ==R4_GEN ) { +pr_cont ("during data scrub.\n" ); +return true; + } -if (xec ==1 &&TLB_ERROR (ec)) -pr_cont (": %s TLB multimatch.\n" ,LL_MSG (ec)); -else if (xec ==0 ) { -if (m->status & (1ULL <<40 )) -pr_cont (" during Data Scrub.\n" ); -else if (TLB_ERROR (ec)) -pr_cont (": %s TLB parity error.\n" ,LL_MSG (ec)); -else if (MEM_ERROR (ec)) { -u8 ll = ec &0x3 ; -u8 tt = (ec >>2 ) &0x3 ; -u8 rrrr = (ec >>4 ) &0xf ; +if (MEM_ERROR (ec)) { +u8 ll = ec &0x3 ; + ret = true; -/* see F10h BKDG (31116), Table 92. */ -if (ll ==0x1 ) { -if (tt !=0x1 ) - goto wrong_dc_mce; +if (ll ==LL_L2 ) +pr_cont ("during L1 linefill from L2.\n" ); +else if (ll ==LL_L1 ) +pr_cont ("Data/Tag %s error.\n" ,RRRR_MSG (ec)); +else + ret = false; + } +return ret; +} -pr_cont (": Data/Tag %s error.\n" ,RRRR_MSG (ec)); +static bool k8_dc_mce (u16 ec) +{ +if (BUS_ERROR (ec)) { +pr_cont ("during system linefill.\n" ); +return true; + } - }else if (ll ==0x2 && rrrr ==0x3 ) -pr_cont (" during L1 linefill from L2.\n" ); -else - goto wrong_dc_mce; - }else if (BUS_ERROR (ec) && boot_cpu_data.x86 ==0xf ) -pr_cont (" during system linefill.\n" ); +return f10h_dc_mce (ec); +} + +static bool f14h_dc_mce (u16 ec) +{ +u8 r4 = (ec >>4 ) &0xf ; +u8 ll = ec &0x3 ; +u8 tt = (ec >>2 ) &0x3 ; +u8 ii = tt; +bool ret = true; + +if (MEM_ERROR (ec)) { + +if (tt !=TT_DATA || ll !=LL_L1 ) +return false; + +switch (r4) { +case R4_DRD : +case R4_DWR : +pr_cont ("Data/Tag parity error due to %s.\n" , + (r4 ==R4_DRD ?"load/hw prf" :"store" )); +break ; +case R4_EVICT : +pr_cont ("Copyback parity error on a tag miss.\n" ); +break ; +case R4_SNOOP : +pr_cont ("Tag parity error during snoop.\n" ); +break ; +default : + ret = false; + } + }else if (BUS_ERROR (ec)) { + +if ((ii !=II_MEM && ii !=II_IO ) || ll !=LL_LG ) +return false; + +pr_cont ("System read data error on a " ); + +switch (r4) { +case R4_RD : +pr_cont ("TLB reload.\n" ); +break ; +case R4_DWR : +pr_cont ("store.\n" ); +break ; +case R4_DRD : +pr_cont ("load.\n" ); +break ; +default : + ret = false; + } + }else { + ret = false; + } + +return ret; +} + +static void amd_decode_dc_mce (struct mce *m) +{ +u16 ec = m->status &0xffff ; +u8 xec = (m->status >>16 ) &0xf ; + +pr_emerg (HW_ERR "Data Cache Error: " ); + +/* +* check this after F14h BKDG is updated +* +* TLB error signatures are the same across families +*/ +if (TLB_ERROR (ec)) { +u8 tt = (ec >>2 ) &0x3 ; + +if (tt ==TT_DATA ) { +pr_cont ("%s TLB %s.\n" ,LL_MSG (ec), + (xec ?"multimatch" :"parity error" )); +return ; + }else goto wrong_dc_mce; - }else + } + +if (!fam_ops->dc_mce (ec)) goto wrong_dc_mce;return ;
@@ -395,6 +478,30 @@ static int __init mce_amd_init(void)if (boot_cpu_data.x86 <0xf || boot_cpu_data.x86 >0x11 )return 0 ; + fam_ops =kzalloc (sizeof (struct amd_decoder_ops ),GFP_KERNEL ); +if (!fam_ops) +return -ENOMEM ; + +switch (boot_cpu_data.x86) { +case 0xf : + fam_ops->dc_mce = k8_dc_mce; +break ; + +case 0x10 : + fam_ops->dc_mce = f10h_dc_mce; +break ; + +case 0x14 : + fam_ops->dc_mce = f14h_dc_mce; +break ; + +default : +printk (KERN_WARNING "Huh? What family is that: %d?!\n" , + boot_cpu_data.x86); +kfree (fam_ops); +return -EINVAL ; + } +atomic_notifier_chain_register (&x86_mce_decoder_chain, &amd_mce_dec_nb);return 0 ;
@@ -405,6 +512,7 @@ early_initcall(mce_amd_init); static void __exit mce_amd_exit(void) {atomic_notifier_chain_unregister (&x86_mce_decoder_chain, &amd_mce_dec_nb); +kfree (fam_ops); }MODULE_DESCRIPTION ("AMD MCE decoder" );
drivers/edac/mce_amd.h +40 -0
@@ -44,6 +44,39 @@#define K8_NBSH_UECC BIT(13)#define K8_NBSH_ERR_SCRUBER BIT(8) +enum tt_ids { +TT_INSTR =0 , +TT_DATA , +TT_GEN , +TT_RESV , +}; + +enum ll_ids { +LL_RESV =0 , +LL_L1 , +LL_L2 , +LL_LG , +}; + +enum ii_ids { +II_MEM =0 , +II_RESV , +II_IO , +II_GEN , +}; + +enum rrrr_ids { +R4_GEN =0 , +R4_RD , +R4_WR , +R4_DRD , +R4_DWR , +R4_IRD , +R4_PREF , +R4_EVICT , +R4_SNOOP , +}; +extern const char *tt_msgs[];extern const char *ll_msgs[];extern const char *rrrr_msgs[];
@@ -63,6 +96,13 @@ struct err_regs {u32 nbeal; }; +/* +* per-family decoder ops +*/ +struct amd_decoder_ops { +bool (*dc_mce)(u16 ); +}; +void amd_report_gart_errors (bool );void amd_register_ecc_decoder (void (*f)(int ,struct mce *,u32 ));void amd_unregister_ecc_decoder (void (*f)(int ,struct mce *,u32 ));
Signature · 1 line
1.7.3.1.50.g1e633
PATCH 4/8 EDAC, MCE: Adjust IC decoders to F14h
In reply to Borislav PetkovFrom: Borislav Petkov <[email protected]>
Add support for IC MCEs for F14h CPUs. K8 and F10h are almost identical so use one function for both.
--- drivers/edac/mce_amd.c | 118 ++++++++++++++++++++++++++++------------------- drivers/edac/mce_amd.h | 1 + 2 files changed, 71 insertions(+), 48 deletions(-)
drivers/edac/mce_amd.c +70 -48
@@ -223,61 +223,80 @@ wrong_dc_mce:pr_emerg (HW_ERR "Corrupted DC MCE info?\n" ); } -static void amd_decode_ic_mce (struct mce *m) +static bool k8_ic_mce (u16 ec) { -u32 ec = m->status &0xffff ; -u32 xec = (m->status >>16 ) &0xf ; +u8 ll = ec &0x3 ; +u8 r4 = (ec >>4 ) &0xf ; +bool ret = true; -pr_emerg (HW_ERR "Instruction Cache Error" ); +if (!MEM_ERROR (ec)) +return false; -if (xec ==1 &&TLB_ERROR (ec)) -pr_cont (": %s TLB multimatch.\n" ,LL_MSG (ec)); -else if (xec ==0 ) { -if (TLB_ERROR (ec)) -pr_cont (": %s TLB Parity error.\n" ,LL_MSG (ec)); -else if (BUS_ERROR (ec)) { -if (boot_cpu_data.x86 ==0xf && - (m->status &BIT (58 ))) -pr_cont (" during system linefill.\n" ); -else -pr_cont (" during attempted NB data read.\n" ); - }else if (MEM_ERROR (ec)) { -u8 ll = ec &0x3 ; -u8 rrrr = (ec >>4 ) &0xf ; +if (ll ==0x2 ) +pr_cont ("during a linefill from L2.\n" ); +else if (ll ==0x1 ) { +switch (r4) { +case R4_IRD : +pr_cont ("Parity error during data load.\n" ); +break ; -if (ll ==0x2 ) -pr_cont (" during a linefill from L2.\n" ); -else if (ll ==0x1 ) { - -switch (rrrr) { -case 0x5 : -pr_cont (": Parity error during " -"data load.\n" ); -break ; - -case 0x7 : -pr_cont (": Copyback Parity/Victim" -" error.\n" ); -break ; - -case 0x8 : -pr_cont (": Tag Snoop error.\n" ); -break ; - -default : - goto wrong_ic_mce; -break ; - } - } - }else - goto wrong_ic_mce; +case R4_EVICT : +pr_cont ("Copyback Parity/Victim error.\n" ); +break ; + +case R4_SNOOP : +pr_cont ("Tag Snoop error.\n" ); +break ; + +default : + ret = false; +break ; + } }else - goto wrong_ic_mce; + ret = false; -return ; +return ret; +} + +static bool f14h_ic_mce (u16 ec) +{ +u8 ll = ec &0x3 ; +u8 tt = (ec >>2 ) &0x3 ; +u8 r4 = (ec >>4 ) &0xf ; +bool ret = true; -wrong_ic_mce: -pr_emerg (HW_ERR "Corrupted IC MCE info?\n" ); +if (MEM_ERROR (ec)) { +if (tt !=0 || ll !=1 ) + ret = false; + +if (r4 ==R4_IRD ) +pr_cont ("Data/tag array parity error for a tag hit.\n" ); +else if (r4 ==R4_SNOOP ) +pr_cont ("Tag error during snoop/victimization.\n" ); +else + ret = false; + } +return ret; +} + +static void amd_decode_ic_mce (struct mce *m) +{ +u16 ec = m->status &0xffff ; +u8 xec = (m->status >>16 ) &0xf ; + +pr_emerg (HW_ERR "Instruction Cache Error: " ); + +if (TLB_ERROR (ec)) +pr_cont ("%s TLB %s.\n" ,LL_MSG (ec), + (xec ?"multimatch" :"parity error" )); +else if (BUS_ERROR (ec)) { +bool k8 = (boot_cpu_data.x86 ==0xf && (m->status &BIT (58 ))); + +pr_cont ("during %s.\n" , (k8 ?"system linefill" :"NB data read" )); + }else if (fam_ops->ic_mce (ec)) + ; +else +pr_emerg (HW_ERR "Corrupted IC MCE info?\n" ); }static void amd_decode_bu_mce (struct mce *m)
@@ -485,14 +504,17 @@ static int __init mce_amd_init(void)switch (boot_cpu_data.x86) {case 0xf : fam_ops->dc_mce = k8_dc_mce; + fam_ops->ic_mce = k8_ic_mce;break ;case 0x10 : fam_ops->dc_mce = f10h_dc_mce; + fam_ops->ic_mce = k8_ic_mce;break ;case 0x14 : fam_ops->dc_mce = f14h_dc_mce; + fam_ops->ic_mce = f14h_ic_mce;break ;default :
drivers/edac/mce_amd.h +1 -0
@@ -101,6 +101,7 @@ struct err_regs {*/ struct amd_decoder_ops {bool (*dc_mce)(u16 ); +bool (*ic_mce)(u16 ); };void amd_report_gart_errors (bool );
Signature · 1 line
1.7.3.1.50.g1e633
PATCH 5/8 EDAC, MCE: Warn about LS MCEs on F14h
In reply to Borislav PetkovFrom: Borislav Petkov <[email protected]>
F14h CPUs do not generate LS MCEs so exit early and warn the user in case this path is ever hit that something else might be going haywire.
--- drivers/edac/mce_amd.c | 18 +++++++++++++----- 1 files changed, 13 insertions(+), 5 deletions(-)
drivers/edac/mce_amd.c +13 -5
@@ -343,19 +343,27 @@ wrong_bu_mce:static void amd_decode_ls_mce (struct mce *m) { -u32 ec = m->status &0xffff ; -u32 xec = (m->status >>16 ) &0xf ; +u16 ec = m->status &0xffff ; +u8 xec = (m->status >>16 ) &0xf ; + +if (boot_cpu_data.x86 ==0x14 ) { +pr_emerg ("You shouldn't be seeing an LS MCE on this cpu family," +" please report on LKML.\n" ); +return ; + }pr_emerg (HW_ERR "Load Store Error" );if (xec ==0x0 ) { -u8 rrrr = (ec >>4 ) &0xf ; +u8 r4 = (ec >>4 ) &0xf ; -if (!BUS_ERROR (ec) || (rrrr !=0x3 && rrrr !=0x4 )) +if (!BUS_ERROR (ec) || (r4 !=R4_DRD && r4 !=R4_DWR )) goto wrong_ls_mce;pr_cont (" during %s.\n" ,RRRR_MSG (ec)); - } + }else + goto wrong_ls_mce; +return ; wrong_ls_mce:
Signature · 1 line
1.7.3.1.50.g1e633
PATCH 6/8 EDAC, MCE: Complete NB MCE decoders
In reply to Borislav PetkovFrom: Borislav Petkov <[email protected]>
Add support for decoding F14h BU MCEs and improve decoding of the remaining families.
--- drivers/edac/amd64_edac.h | 1 - drivers/edac/mce_amd.c | 210 +++++++++++++++++++++++++++++++++----------- drivers/edac/mce_amd.h | 3 +- 3 files changed, 158 insertions(+), 56 deletions(-)
drivers/edac/amd64_edac.h +0 -1
@@ -482,7 +482,6 @@ extern const char *rrrr_msgs[16];extern const char *to_msgs[2 ];extern const char *pp_msgs[4 ];extern const char *ii_msgs[4 ]; -extern const char *ext_msgs[32 ];extern const char *htlink_msgs[8 ];#ifdef CONFIG_EDAC_DEBUG
drivers/edac/mce_amd.c +157 -53
274 lines not on this page · raw message
drivers/edac/mce_amd.h +1 -2
@@ -7,7 +7,6 @@#define ERROR_CODE (x) ((x) & 0xffff)#define EXT_ERROR_CODE (x) (((x) >> 16) & 0x1f) -#define EXT_ERR_MSG (x) ext_msgs[EXT_ERROR_CODE(x)]#define LOW_SYNDROME (x) (((x) >> 15) & 0xff)#define HIGH_SYNDROME (x) (((x) >> 24) & 0xff)
@@ -83,7 +82,6 @@ extern const char *rrrr_msgs[];extern const char *pp_msgs[];extern const char *to_msgs[];extern const char *ii_msgs[]; -extern const char *ext_msgs[];/* * relevant NB regs
@@ -102,6 +100,7 @@ struct err_regs {struct amd_decoder_ops {bool (*dc_mce)(u16 );bool (*ic_mce)(u16 ); +bool (*nb_mce)(u16 ,u8 ); };void amd_report_gart_errors (bool );
Signature · 1 line
1.7.3.1.50.g1e633
PATCH 7/8 EDAC, MCE: Fix FR MCEs decoding
In reply to Borislav PetkovFrom: Borislav Petkov <[email protected]>
Those are N/A on K8, so don't decode them there.
--- drivers/edac/mce_amd.c | 14 ++++++++++---- 1 files changed, 10 insertions(+), 4 deletions(-)
drivers/edac/mce_amd.c +10 -4
@@ -491,11 +491,17 @@ EXPORT_SYMBOL_GPL(amd_decode_nb_mce);static void amd_decode_fr_mce (struct mce *m) { +if (boot_cpu_data.x86 ==0xf ) + goto wrong_fr_mce; +/* we have only one error signature so match all fields at once. */ -if ((m->status &0xffff ) ==0x0f0f ) -pr_emerg (HW_ERR " FR Error: CPU Watchdog timer expire.\n" ); -else -pr_emerg (HW_ERR "Corrupted FR MCE info?\n" ); +if ((m->status &0xffff ) ==0x0f0f ) { +pr_emerg (HW_ERR "FR Error: CPU Watchdog timer expire.\n" ); +return ; + } + +wrong_fr_mce: +pr_emerg (HW_ERR "Corrupted FR MCE info?\n" ); }static inline void amd_decode_err_code (u16 ec)
Signature · 1 line
1.7.3.1.50.g1e633
PATCH 8/8 EDAC, MCE: Enable MCE decoding on F14h
In reply to Borislav PetkovFrom: Borislav Petkov <[email protected]>
Now that all decoders have been taught about F14h, models < 0x10 MCEs, enable decoding on this family of CPUs. Also, issue a short informational message upon boot that MCE decoding gets enabled.
--- drivers/edac/mce_amd.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
drivers/edac/mce_amd.c +5 -4
@@ -602,13 +602,12 @@ static struct notifier_block amd_mce_dec_nb = {static int __init mce_amd_init (void ) { -/* -* We can decode MCEs for K8, F10h and F11h CPUs: -*/ if (boot_cpu_data.x86_vendor !=X86_VENDOR_AMD )return 0 ; -if (boot_cpu_data.x86 <0xf || boot_cpu_data.x86 >0x11 ) +if (boot_cpu_data.x86 !=0xf && + boot_cpu_data.x86 !=0x10 && + (boot_cpu_data.x86 !=0x14 || boot_cpu_data.x86_model >0xf ))return 0 ; fam_ops =kzalloc (sizeof (struct amd_decoder_ops ),GFP_KERNEL );
@@ -642,6 +641,8 @@ static int __init mce_amd_init(void)return -EINVAL ; } +pr_info ("MCE: In-kernel MCE decoding enabled.\n" ); +atomic_notifier_chain_register (&x86_mce_decoder_chain, &amd_mce_dec_nb);return 0 ;
Signature · 1 line
1.7.3.1.50.g1e633