Skip to contentSkip to conversation

serial.c: Fix build breakage introduced with commit e3c78c9b

PATCH New Stefan Roese 2 participants 2 messages Oct 6, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 serial.c: Fix build breakage introduced with commit e3c78c9b

This patch fixes the compilation problem introduced with commit e3c78c9b [ppc4xx: Remove now unused CONFIG_UART1_CONSOLE]:

-> ./MAKEALL TB5200
Configuring for TB5200 board...
serial.c: In function '__default_serial_console':
serial.c:94: warning: no return statement in function returning non-void

I accidentally removed an "#else" line. This patch adds it back.

---
 common/serial.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
common/serial.c +1 -0
index 25b235a..7bebc12 100644
@@ -54,6 +54,7 @@ struct serial_device *__default_serial_console (void)
 #else
 #error "Bad CONFIG_CONS_INDEX."
 #endif
+#else
 	return &serial0_device;
 #endif
 #elif defined(CONFIG_MPC512X)
Signature · 1 line
1.7.3.1
#1 lore raw

PATCH 1/1 serial.c: Fix build breakage introduced with commit e3c78c9b

Dear Stefan Roese,

Quoted 8 lines · In message <[email protected]> you wrote:

This patch fixes the compilation problem introduced with commit e3c78c9b [ppc4xx: Remove now unused CONFIG_UART1_CONSOLE]:

-> ./MAKEALL TB5200
Configuring for TB5200 board...
serial.c: In function '__default_serial_console':
serial.c:94: warning: no return statement in function returning non-void

Quoted 6 lines

I accidentally removed an "#else" line. This patch adds it back.

---
 common/serial.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If anything can go wrong, it will."                   - Edsel Murphy