Skip to contentSkip to conversation

TCP: Fix setting of snd_ssthresh in tcp_mtu_probe_success

PATCH Applied John Heffner 2 participants 2 messages Oct 7, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 TCP: Fix setting of snd_ssthresh in tcp_mtu_probe_success

This looks like a simple typo that has gone unnoticed for some time. The impact is relatively low but it's clearly wrong.

---
 net/ipv4/tcp_input.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/ipv4/tcp_input.c +1 -1
index f6fdd72..e4fbdae 100644
@@ -2874,7 +2874,7 @@ static void tcp_mtup_probe_success(struct sock *sk)
 		       icsk->icsk_mtup.probe_size;
 	tp->snd_cwnd_cnt = 0;
 	tp->snd_cwnd_stamp = tcp_time_stamp;
-	tp->rcv_ssthresh = tcp_current_ssthresh(sk);
+	tp->snd_ssthresh = tcp_current_ssthresh(sk);
 
 	icsk->icsk_mtup.search_low = icsk->icsk_mtup.probe_size;
 	icsk->icsk_mtup.probe_size = 0;
Signature · 1 line
1.7.0.4
maintainer Applied
#1 lore raw

From: John Heffner <[email protected]>
Date: Wed, 6 Oct 2010 23:41:53 -0400

Quoted 4 lines

This looks like a simple typo that has gone unnoticed for some time. The impact is relatively low but it's clearly wrong.

Amazing how long something like this can survive :-)

Applied, thanks John.