Skip to contentSkip to conversation

mfd: jz4740-adc - fix jz4740_adc_set_enabled

PATCH In review Axel Lin 3 participants 3 messages Oct 7, 2010 – Oct 19, 2010 Multifunction devices (MFD)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 mfd: jz4740-adc - fix jz4740_adc_set_enabled

When enabled is false, clear BIT(engine) of JZ_REG_ADC_ENABLE register.

---
 drivers/mfd/jz4740-adc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/jz4740-adc.c +1 -1
index 3ad492c..9dd1b33 100644
@@ -153,7 +153,7 @@ static inline void jz4740_adc_set_enabled(struct jz4740_adc *adc, int engine,
 	if (enabled)
 		val |= BIT(engine);
 	else
-		val &= BIT(engine);
+		val &= ~BIT(engine);
 	writeb(val, adc->base + JZ_REG_ADC_ENABLE);
 
 	spin_unlock_irqrestore(&adc->lock, flags);
Signature · 1 line
1.7.2
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Axel Lin

When enabled is false, clear BIT(engine) of JZ_REG_ADC_ENABLE register.

Thanks
- Lars

Quoted 17 lines
---
 drivers/mfd/jz4740-adc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/jz4740-adc.c +1 -1
index 3ad492c..9dd1b33 100644
@@ -153,7 +153,7 @@ static inline void jz4740_adc_set_enabled(struct jz4740_adc *adc, int engine,
 	if (enabled)
 		val |= BIT(engine);
 	else
-		val &= BIT(engine);
+		val &= ~BIT(engine);
 	writeb(val, adc->base + JZ_REG_ADC_ENABLE);
 
 	spin_unlock_irqrestore(&adc->lock, flags);
#2 lore raw
In reply to Axel Lin

Hi Axel,

Quoted 1 line · Axel Lin

When enabled is false, clear BIT(engine) of JZ_REG_ADC_ENABLE register.

Patch applied, thanks.

Cheers,
Samuel.

Quoted 23 lines
---
 drivers/mfd/jz4740-adc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/jz4740-adc.c +1 -1
index 3ad492c..9dd1b33 100644
@@ -153,7 +153,7 @@ static inline void jz4740_adc_set_enabled(struct jz4740_adc *adc, int engine,
 	if (enabled)
 		val |= BIT(engine);
 	else
-		val &= BIT(engine);
+		val &= ~BIT(engine);
 	writeb(val, adc->base + JZ_REG_ADC_ENABLE);
 
 	spin_unlock_irqrestore(&adc->lock, flags);
Signature · 1 line
1.7.2
Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/