Skip to contentSkip to conversation

get_maintainer

DISCUSSION Johannes Berg 2 participants 3 messages Oct 11, 2010

lore
Share & tools
lore
#0 lore raw

Joe,

get_maintainer.pl has a huge amount of false positives, and as a net result people CC me on *all* wireless driver patches (when they use the script) because I've touched them all in commits like 97359d1235eaf634f.

Would it be possible to modify the script to actually look at the patches it found and not CC people if the changes to the file in question are, say, less than 20% of the overall patch?

If that turns out to not be possible, I think I'm going to have to cook up blacklist support for it ... :-)

johannes

#1 lore raw
Quoted 3 lines · Johannes Berg

Would it be possible to modify the script to actually look at the patches it found and not CC people if the changes to the file in question are, say, less than 20% of the overall patch?

Hi Johannes.

Pull this in some test branch and try it out.

git://repo.or.cz/linux-2.6/get_maintainer.git 20100922_gm

If you try this and find it less than adequate,
please tell me why.

Here's the patch series, which is in MM
http://lkml.org/lkml/2010/9/22/464

Here's a couple of recent longish threads about this.
http://lkml.org/lkml/2010/9/10/94
http://lkml.org/lkml/2010/9/25/184

#2 lore raw

Hi Joe,

Quoted 10 lines

Pull this in some test branch and try it out.

git://repo.or.cz/linux-2.6/get_maintainer.git 20100922_gm

If you try this and find it less than adequate,
please tell me why.

Here's a couple of recent longish threads about this.
http://lkml.org/lkml/2010/9/10/94
http://lkml.org/lkml/2010/9/25/184

Oh my, I missed that.

I tried it out, and it seems --git is no longer default. That in itself will probably help lots already, and somebody using non-default options will hopefully pay more attention.

Thanks!

Johannes