Skip to contentSkip to conversation

nfs-utils: fix default value for --enable-tirpc

PATCH In review Jeff Layton 3 participants 6 messages Oct 12, 2010 – Nov 1, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfs-utils: fix default value for --enable-tirpc

The patch I originally proposed to make --enable-tirpc the default had the default for $enable_tirpc as a blank string. When it was merged however, that value was changed to a 'yes'. This broke the ability for autoconf to detect and autodisable building with tirpc. When tirpc isn't present now, the configure step fails unless someone explicitly specifies --disable-libtirpc.

We need $enable_tirpc to be a tristate. 'yes' means that someone explicitly requested building with tirpc. 'no' means that it was explicitly disabled. Anything else means that no one specified a value.

Fix it by setting the value to a blank string so that the default is properly undefined.

---
 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
configure.ac +1 -1
index 3058be6..5408e85 100644
@@ -136,7 +136,7 @@ AC_ARG_ENABLE(tirpc,
 	[AC_HELP_STRING([--enable-tirpc],
 			[enable use of TI-RPC @<:@default=yes@:>@])],
 	enable_tirpc=$enableval,
-	enable_tirpc='yes')
+	enable_tirpc='')
 AC_ARG_ENABLE(ipv6,
 	[AC_HELP_STRING([--enable-ipv6],
                         [enable support for IPv6 @<:@default=no@:>@])],
Signature · 1 line
1.7.1
#1 lore raw
Quoted 7 lines · Jeff Layton

The patch I originally proposed to make --enable-tirpc the default had the default for $enable_tirpc as a blank string. When it was merged however, that value was changed to a 'yes'. This broke the ability for autoconf to detect and autodisable building with tirpc. When tirpc isn't present now, the configure step fails unless someone explicitly specifies --disable-libtirpc.

Quoted 6 lines

We need $enable_tirpc to be a tristate. 'yes' means that someone explicitly requested building with tirpc. 'no' means that it was explicitly disabled. Anything else means that no one specified a value.

Fix it by setting the value to a blank string so that the default is properly undefined.

Thanks for looking into that, it's FAQ #1 for people rolling their own these days....

--b.

Quoted 27 lines
---
 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
configure.ac +1 -1
index 3058be6..5408e85 100644
@@ -136,7 +136,7 @@ AC_ARG_ENABLE(tirpc,
 	[AC_HELP_STRING([--enable-tirpc],
 			[enable use of TI-RPC @<:@default=yes@:>@])],
 	enable_tirpc=$enableval,
-	enable_tirpc='yes')
+	enable_tirpc='')
 AC_ARG_ENABLE(ipv6,
 	[AC_HELP_STRING([--enable-ipv6],
                         [enable support for IPv6 @<:@default=no@:>@])],
Signature · 6 lines
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
In reply to Jeff Layton

Jeff,

Quoted 3 lines · Jeff Layton

The patch I originally proposed to make --enable-tirpc the default had the default for $enable_tirpc as a blank string. When it was merged however, that value was changed to a 'yes'.

Which commit or proposal are you talking about? I'm looking at commit 148503a which changed it for no to yes, but I can not seem to find the proposal you are talking about?

I'm just trying to figure how the merge broke it so it does not happen again...

steved.

Quoted 31 lines

This broke the ability for
autoconf to detect and autodisable building with tirpc. When tirpc isn't present now, the configure step fails unless someone explicitly specifies --disable-libtirpc.

We need $enable_tirpc to be a tristate. 'yes' means that someone explicitly requested building with tirpc. 'no' means that it was explicitly disabled. Anything else means that no one specified a value.

Fix it by setting the value to a blank string so that the default is properly undefined.

---
 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
configure.ac +1 -1
index 3058be6..5408e85 100644
@@ -136,7 +136,7 @@ AC_ARG_ENABLE(tirpc,
 	[AC_HELP_STRING([--enable-tirpc],
 			[enable use of TI-RPC @<:@default=yes@:>@])],
 	enable_tirpc=$enableval,
-	enable_tirpc='yes')
+	enable_tirpc='')
 AC_ARG_ENABLE(ipv6,
 	[AC_HELP_STRING([--enable-ipv6],
                         [enable support for IPv6 @<:@default=no@:>@])],
#3 lore raw
Quoted 6 lines · On Thu, 28 Oct 2010 09:24:00 -0400 Steve Dickson <[email protected]> wrote:

Jeff,

Quoted 3 lines · Jeff Layton

The patch I originally proposed to make --enable-tirpc the default had the default for $enable_tirpc as a blank string. When it was merged however, that value was changed to a 'yes'.

Quoted 9 lines

Which commit or proposal are you talking about? I'm looking at commit 148503a which changed it for no to yes, but I can not seem to find the proposal you are talking about?

I'm just trying to figure how the merge broke it so it does not happen again...

steved.

Here was the original patch posting:

http://www.spinics.net/lists/linux-nfs/msg07718.html

I checked my mail archives and didn't see emails where we discussed this patch specifically around that time. Maybe we did on IRC before you merged it and I misunderstood what you intended to change? Hard to remember since it was over a year ago...

Signature · 1 line
Jeff Layton <[email protected]>
#4 lore raw
Quoted 19 lines · Jeff Layton
Quoted 6 lines · On Thu, 28 Oct 2010 09:24:00 -0400 Steve Dickson <[email protected]> wrote:

Jeff,

Quoted 3 lines · Jeff Layton

The patch I originally proposed to make --enable-tirpc the default had the default for $enable_tirpc as a blank string. When it was merged however, that value was changed to a 'yes'.

Quoted 9 lines

Which commit or proposal are you talking about? I'm looking at commit 148503a which changed it for no to yes, but I can not seem to find the proposal you are talking about?

I'm just trying to figure how the merge broke it so it does not happen again...

steved.

Quoted 8 lines

Here was the original patch posting:

http://www.spinics.net/lists/linux-nfs/msg07718.html

I checked my mail archives and didn't see emails where we discussed this patch specifically around that time. Maybe we did on IRC before you merged it and I misunderstood what you intended to change? Hard to remember since it was over a year ago...

I generally just cut and paste the patches and if I make any changes I post them... So I'm wondering how that got changed... anyway... its fixed now...

steved.

#5 lore raw
In reply to Jeff Layton
Quoted 25 lines · Jeff Layton

The patch I originally proposed to make --enable-tirpc the default had the default for $enable_tirpc as a blank string. When it was merged however, that value was changed to a 'yes'. This broke the ability for autoconf to detect and autodisable building with tirpc. When tirpc isn't present now, the configure step fails unless someone explicitly specifies --disable-libtirpc.

We need $enable_tirpc to be a tristate. 'yes' means that someone explicitly requested building with tirpc. 'no' means that it was explicitly disabled. Anything else means that no one specified a value.

Fix it by setting the value to a blank string so that the default is properly undefined.

---
 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
configure.ac +0 -0
index 3058be6..5408e85 100644

configure.ac AC_ARG_ENABLE(tirpc, · line 142

Quoted 8 lines
configure.ac +1 -1
@@ -136,7 +136,7 @@ AC_ARG_ENABLE(tirpc,
 	[AC_HELP_STRING([--enable-tirpc],
 			[enable use of TI-RPC @<:@default=yes@:>@])],
 	enable_tirpc=$enableval,
-	enable_tirpc='yes')
+	enable_tirpc='')
 AC_ARG_ENABLE(ipv6,
 	[AC_HELP_STRING([--enable-ipv6],
                         [enable support for IPv6 @<:@default=no@:>@])],

Committed...

steved.