staging:ft1000:Use specific error return value.
PATCH 1/1 staging:ft1000:Use specific error return value.
Signed-off-by Marek Belisko <[email protected]>
--- drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 30 +++--------------------- 1 files changed, 4 insertions(+), 26 deletions(-)
drivers/staging/ft1000/ft1000-usb/ft1000_hw.c +4 -26
@@ -141,12 +141,12 @@ static int ft1000_control(struct ft1000_device *ft1000dev,unsigned int pipe,if (ft1000dev ==NULL ) {DEBUG ("NULL ft1000dev, failure\n" ); -return STATUS_FAILURE ; +return -ENODEV ; }else if ( ft1000dev->dev ==NULL ) {DEBUG ("NULL ft1000dev->dev, failure\n" ); -return STATUS_FAILURE ; +return -ENODEV ; } ret = usb_control_msg(ft1000dev->dev,
@@ -159,11 +159,8 @@ static int ft1000_control(struct ft1000_device *ft1000dev,unsigned int pipe, size, LARGE_TIMEOUT); -if (ret>0 ) - ret =STATUS_SUCCESS ; -else - ret =STATUS_FAILURE ; - +if (ret >0 ) + ret =0 ;return ret;
@@ -204,8 +201,6 @@ u16 ft1000_read_register(struct ft1000_device *ft1000dev, u16* Data, u16 nRegInd//DEBUG("ft1000_read_register: ret is %d \n", ret); //DEBUG("ft1000_read_register: data is %x \n", *Data); -if ( ret !=STATUS_SUCCESS ) -return STATUS_FAILURE ;return ret;
@@ -242,9 +237,6 @@ u16 ft1000_write_register(struct ft1000_device *ft1000dev, USHORT value, u16 nRe0 , LARGE_TIMEOUT ); -if ( ret !=STATUS_SUCCESS ) -return STATUS_FAILURE ; -return ret; }
@@ -283,8 +275,6 @@ u16 ft1000_read_dpram32(struct ft1000_device *ft1000dev, USHORT indx, PUCHAR buf//DEBUG("ft1000_read_dpram32: ret is %d \n", ret); //DEBUG("ft1000_read_dpram32: ret=%d \n", ret); -if ( ret !=STATUS_SUCCESS ) -return STATUS_FAILURE ;return ret;
@@ -324,11 +314,6 @@ u16 ft1000_write_dpram32(struct ft1000_device *ft1000dev, USHORT indx, PUCHAR bu cnt,//buffer size LARGE_TIMEOUT ); - -if ( ret !=STATUS_SUCCESS ) -return STATUS_FAILURE ; - -return ret; }
@@ -375,8 +360,6 @@ u16 ft1000_read_dpram16(struct ft1000_device *ft1000dev, USHORT indx, PUCHAR buf//DEBUG("ft1000_read_dpram16: data is %x \n", *buffer); -if ( ret !=STATUS_SUCCESS ) -return STATUS_FAILURE ;return ret;
@@ -424,11 +407,6 @@ u16 ft1000_write_dpram16(struct ft1000_device *ft1000dev, USHORT indx, USHORT va0 ,//buffer size LARGE_TIMEOUT ); - -if ( ret !=STATUS_SUCCESS ) -return STATUS_FAILURE ; - -return ret; }
Signature · 1 line
1.7.1