OMAP3: V4L2: Kconfig changes to enable V4L2 options on OMAP3

PATCH Superseded Samreen 2 participants 5 messages Oct 18, 2010 – Nov 4, 2010 Media (V4L/DVB)

lore

Share & tools

lore

Samreen

author

2010-10-18 04:06 UTC #0 lore raw

PATCH 1/1 OMAP3: V4L2: Kconfig changes to enable V4L2 options on OMAP3

The defconfig options for V4L2 are taken in the respective Kconfig to enable V4L2 by default on OMAP3 platforms

Signed-off-by Samreen <[email protected]>

---
 drivers/media/Kconfig            |    2 ++
 drivers/media/video/omap/Kconfig |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)

drivers/media/Kconfig +2 -0

index a28541b..2592d88 100644
@@ -5,6 +5,7 @@
 menuconfig MEDIA_SUPPORT
 	tristate "Multimedia support"
 	depends on HAS_IOMEM
+	default y if ARCH_OMAP2 || ARCH_OMAP3
 	help
 	  If you want to use Video for Linux, DVB for Linux, or DAB adapters,
 	  enable this option and other options below.

@@ -19,6 +20,7 @@ comment "Multimedia core support"
 
 config VIDEO_DEV
 	tristate "Video For Linux"
+	default y if ARCH_OMAP2 || ARCH_OMAP3
 	---help---
 	  V4L core support for video capture and overlay devices, webcams and
 	  AM/FM radio cards.

drivers/media/video/omap/Kconfig +1 -1

index e63233f..f3e33c3 100644
@@ -6,6 +6,6 @@ config VIDEO_OMAP2_VOUT
 	select OMAP2_DSS
 	select OMAP2_VRAM
 	select OMAP2_VRFB
-	default n
+	default y
 	---help---
 	  V4L2 Display driver support for OMAP2/3 based boards.

Signature · 1 line

1.5.6.3

Hiremath, Vaibhav

2010-10-19 04:10 UTC #1 lore raw

Quoted 22 lines

-----Original Message-----
From: Nilofer, Samreen
Sent: Monday, October 18, 2010 9:32 AM
To: Hiremath, Vaibhav
Cc: [email protected]; Nilofer, Samreen
Subject: [PATCH 1/1] OMAP3: V4L2: Kconfig changes to enable V4L2 options on OMAP3
The defconfig options for V4L2 are taken in the respective Kconfig to enable V4L2 by default on OMAP3 platforms
Signed-off-by Samreen <[email protected]>
---
 drivers/media/Kconfig            |    2 ++
 drivers/media/video/omap/Kconfig |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
drivers/media/Kconfig +0 -0
index a28541b..2592d88 100644

drivers/media/Kconfig line 8

Quoted 4 lines

drivers/media/Kconfig +1 -0

@@ -5,6 +5,7 @@
 menuconfig MEDIA_SUPPORT
 	tristate "Multimedia support"
 	depends on HAS_IOMEM
+	default y if ARCH_OMAP2 || ARCH_OMAP3

[Hiremath, Vaibhav] I am quite not sure whether this is right approach to do this, I think adding dependency of ARCH_ here will pollute the file.

Why not add this definition to omap2plus_defconfig, which is common defconfig file for all OMAP architecture.

Thanks,
Vaibhav

Quoted 28 lines

drivers/media/Kconfig +0 -0

 	help
 	  If you want to use Video for Linux, DVB for Linux, or DAB
 adapters,

drivers/media/Kconfig +1 -0

 	  enable this option and other options below.

@@ -19,6 +20,7 @@ comment "Multimedia core support"
 
 config VIDEO_DEV
 	tristate "Video For Linux"
+	default y if ARCH_OMAP2 || ARCH_OMAP3
 	---help---
 	  V4L core support for video capture and overlay devices, webcams

and

drivers/media/Kconfig +0 -0

 	  AM/FM radio cards.

drivers/media/video/omap/Kconfig +1 -2

index e63233f..f3e33c3 100644
@@ -6,6 +6,6 @@ config VIDEO_OMAP2_VOUT
 	select OMAP2_DSS
 	select OMAP2_VRAM
 	select OMAP2_VRFB
-	default n
+	default y
 	---help---
 	  V4L2 Display driver support for OMAP2/3 based boards.
--

1.5.6.3

Nilofer, Samreen

author

2010-10-19 12:07 UTC #2 lore raw

Quoted 41 lines

-----Original Message-----
From: Hiremath, Vaibhav
Sent: Tuesday, October 19, 2010 9:40 AM
To: Nilofer, Samreen
Cc: [email protected]
Subject: RE: [PATCH 1/1] OMAP3: V4L2: Kconfig changes to enable V4L2 options on OMAP3
Quoted 9 lines
-----Original Message-----
From: Nilofer, Samreen
Sent: Monday, October 18, 2010 9:32 AM
To: Hiremath, Vaibhav
Cc: [email protected]; Nilofer, Samreen
Subject: [PATCH 1/1] OMAP3: V4L2: Kconfig changes to enable V4L2 options on OMAP3
The defconfig options for V4L2 are taken in the respective
Kconfig to
Quoted 13 lines
enable V4L2 by default on OMAP3 platforms
Signed-off-by Samreen <[email protected]>
---
 drivers/media/Kconfig            |    2 ++
 drivers/media/video/omap/Kconfig |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
drivers/media/Kconfig index renamed from drivers/media/Kconfig +0 -0
a28541b..2592d88 100644
drivers/media/Kconfig line 8
Quoted 4 lines
drivers/media/Kconfig +1 -0
@@ -5,6 +5,7 @@
 menuconfig MEDIA_SUPPORT
 	tristate "Multimedia support"
 	depends on HAS_IOMEM
+	default y if ARCH_OMAP2 || ARCH_OMAP3
[Hiremath, Vaibhav] I am quite not sure whether this is right approach to do this, I think adding dependency of ARCH_ here will pollute the file.

Quoted 5 lines

Why not add this definition to omap2plus_defconfig, which is common defconfig file for all OMAP architecture.
Thanks,
Vaibhav

[Samreen]
I was not aware of the fact that the defconfig could be modified..
Will incorporate the changes and will post them soon. -Regards,
Samreen

Quoted 32 lines

drivers/media/Kconfig comment "Multimedia core support" · line 25

Quoted 12 lines

drivers/media/Kconfig +0 -0

 	help
 	  If you want to use Video for Linux, DVB for Linux, or DAB 
 adapters,

drivers/media/Kconfig +1 -0

 	  enable this option and other options below.

@@ -19,6 +20,7 @@ comment "Multimedia core support"
 
 config VIDEO_DEV
 	tristate "Video For Linux"
+	default y if ARCH_OMAP2 || ARCH_OMAP3
 	---help---
 	  V4L core support for video capture and overlay

devices, webcams

Quoted 17 lines

and

drivers/media/Kconfig +0 -0

 	  AM/FM radio cards.

drivers/media/video/omap/Kconfig +1 -2

index e63233f..f3e33c3 100644
@@ -6,6 +6,6 @@ config VIDEO_OMAP2_VOUT
 	select OMAP2_DSS
 	select OMAP2_VRAM
 	select OMAP2_VRFB
-	default n
+	default y
 	---help---
 	  V4L2 Display driver support for OMAP2/3 based boards.
--

1.5.6.3

Hiremath, Vaibhav

2010-10-19 12:28 UTC #3 lore raw

Quoted 49 lines

-----Original Message-----
From: Nilofer, Samreen
Sent: Tuesday, October 19, 2010 5:38 PM
To: Hiremath, Vaibhav
Cc: [email protected]
Subject: RE: [PATCH 1/1] OMAP3: V4L2: Kconfig changes to enable V4L2 options on OMAP3
Quoted 39 lines
-----Original Message-----
From: Hiremath, Vaibhav
Sent: Tuesday, October 19, 2010 9:40 AM
To: Nilofer, Samreen
Cc: [email protected]
Subject: RE: [PATCH 1/1] OMAP3: V4L2: Kconfig changes to enable V4L2 options on OMAP3
Quoted 9 lines
-----Original Message-----
From: Nilofer, Samreen
Sent: Monday, October 18, 2010 9:32 AM
To: Hiremath, Vaibhav
Cc: [email protected]; Nilofer, Samreen
Subject: [PATCH 1/1] OMAP3: V4L2: Kconfig changes to enable V4L2 options on OMAP3
The defconfig options for V4L2 are taken in the respective
Kconfig to
Quoted 13 lines
enable V4L2 by default on OMAP3 platforms
Signed-off-by Samreen <[email protected]>
---
 drivers/media/Kconfig            |    2 ++
 drivers/media/video/omap/Kconfig |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
drivers/media/Kconfig index renamed from drivers/media/Kconfig +0 -0
a28541b..2592d88 100644
drivers/media/Kconfig line 8
Quoted 4 lines
drivers/media/Kconfig +1 -0
@@ -5,6 +5,7 @@
 menuconfig MEDIA_SUPPORT
 	tristate "Multimedia support"
 	depends on HAS_IOMEM
+	default y if ARCH_OMAP2 || ARCH_OMAP3
[Hiremath, Vaibhav] I am quite not sure whether this is right approach to do this, I think adding dependency of ARCH_ here will pollute the file.

Quoted 8 lines

Quoted 5 lines
Why not add this definition to omap2plus_defconfig, which is common defconfig file for all OMAP architecture.
Thanks,
Vaibhav
[Samreen]
I was not aware of the fact that the defconfig could be modified..
Will incorporate the changes and will post them soon.

[Hiremath, Vaibhav] Please cc linux-omap mailing list, since all arch patches should go through it.

Thanks,
Vaibhav

Quoted 34 lines

-Regards,
Samreen

Quoted 32 lines

drivers/media/Kconfig comment "Multimedia core support" · line 25

Quoted 12 lines

drivers/media/Kconfig +0 -0

 	help
 	  If you want to use Video for Linux, DVB for Linux, or DAB
 adapters,

drivers/media/Kconfig +1 -0

 	  enable this option and other options below.

@@ -19,6 +20,7 @@ comment "Multimedia core support"
 
 config VIDEO_DEV
 	tristate "Video For Linux"
+	default y if ARCH_OMAP2 || ARCH_OMAP3
 	---help---
 	  V4L core support for video capture and overlay

devices, webcams

Quoted 17 lines

and

drivers/media/Kconfig +0 -0

 	  AM/FM radio cards.

drivers/media/video/omap/Kconfig +1 -2

index e63233f..f3e33c3 100644
@@ -6,6 +6,6 @@ config VIDEO_OMAP2_VOUT
 	select OMAP2_DSS
 	select OMAP2_VRAM
 	select OMAP2_VRFB
-	default n
+	default y
 	---help---
 	  V4L2 Display driver support for OMAP2/3 based boards.
--

1.5.6.3

Nilofer, Samreen

author

2010-11-04 05:37 UTC #4 lore raw

In reply to Hiremath, Vaibhav

Hi,

Quoted 39 lines · Samreen

Quoted 39 lines
-----Original Message-----
From: Hiremath, Vaibhav
Sent: Tuesday, October 19, 2010 9:40 AM
To: Nilofer, Samreen
Cc: [email protected]
Subject: RE: [PATCH 1/1] OMAP3: V4L2: Kconfig changes to enable V4L2 options on OMAP3
Quoted 21 lines
-----Original Message-----
From: Nilofer, Samreen
Sent: Monday, October 18, 2010 9:32 AM
To: Hiremath, Vaibhav
Cc: [email protected]; Nilofer, Samreen
Subject: [PATCH 1/1] OMAP3: V4L2: Kconfig changes to enable V4L2 options on OMAP3
The defconfig options for V4L2 are taken in the respective Kconfig to enable V4L2 by default on OMAP3 platforms
Signed-off-by Samreen <[email protected]>
---
 drivers/media/Kconfig            |    2 ++
 drivers/media/video/omap/Kconfig |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
drivers/media/Kconfig index renamed from drivers/media/Kconfig +0 -0
a28541b..2592d88 100644 --- a/drivers/media/Kconfig +++ b/drivers/media/Kconfig
drivers/media/Kconfig index line 8
Quoted 4 lines
drivers/media/Kconfig index renamed from drivers/media/Kconfig +1 -0
@@ -5,6 +5,7 @@
 menuconfig MEDIA_SUPPORT
 	tristate "Multimedia support"
 	depends on HAS_IOMEM
+	default y if ARCH_OMAP2 || ARCH_OMAP3
[Hiremath, Vaibhav] I am quite not sure whether this is right approach to do this, I think adding dependency of ARCH_ here will pollute the file.
Why not add this definition to omap2plus_defconfig, which is common defconfig file for all OMAP architecture.

Quoted 6 lines

Quoted 2 lines
Thanks,
Vaibhav
[Samreen]
I was not aware of the fact that the defconfig could be modified..
Will incorporate the changes and will post them soon. -Regards, Samreen

[Samreen]
Just to clarify, if this Kconfig patch would be fine. As defconfig
changes are not appreciated by the community.

Warm Regards,
Samreen

Quoted 26 lines

drivers/media/Kconfig index renamed from drivers/media/Kconfig +1 -0

 	help
 	  If you want to use Video for Linux, DVB for Linux, or DAB adapters,
 	  enable this option and other options below.

@@ -19,6 +20,7 @@ comment "Multimedia core support"
 
 config VIDEO_DEV
 	tristate "Video For Linux"
+	default y if ARCH_OMAP2 || ARCH_OMAP3
 	---help---
 	  V4L core support for video capture and overlay devices, webcams and
 	  AM/FM radio cards.

drivers/media/video/omap/Kconfig +1 -1

index e63233f..f3e33c3 100644
@@ -6,6 +6,6 @@ config VIDEO_OMAP2_VOUT
 	select OMAP2_DSS
 	select OMAP2_VRAM
 	select OMAP2_VRFB
-	default n
+	default y
 	---help---
 	  V4L2 Display driver support for OMAP2/3 based boards. --

1.5.6.3