time: jiffies.c: fix typos in comment
PATCH 1/1 time: jiffies.c: fix typos in comment
--- kernel/time/jiffies.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
kernel/time/jiffies.c +2 -2
@@ -30,8 +30,8 @@* the timer interrupt frequency HZ and it suffers * inaccuracies caused by missed or lost timer * interrupts and the inability for the timer -* interrupt hardware to accuratly tick at the -* requested HZ value. It is also not reccomended +* interrupt hardware to accurately tick at the +* requested HZ value. It is also not recommended * for "tick-less" systems. */ #define NSEC_PER_JIFFY ((u32)((((u64)NSEC_PER_SEC)<<8)/ACTHZ))
Signature · 1 line
1.7.1
Quoted 11 lines · Serafeim Zanikolas
Signed-off-by Serafeim Zanikolas <[email protected]>--- kernel/time/jiffies.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)kernel/time/jiffies.c +0
-0
kernel/time/jiffies.c line 35
Quoted 8 lines
kernel/time/jiffies.c +2
-2@@ -30,8 +30,8 @@* the timer interrupt frequency HZ and it suffers * inaccuracies caused by missed or lost timer * interrupts and the inability for the timer -* interrupt hardware to accuratly tick at the -* requested HZ value. It is also not reccomended +* interrupt hardware to accurately tick at the +* requested HZ value. It is also not recommended * for "tick-less" systems.
You are not only correcting a typo. You are changing the sense of the comment, unfortunately in the wrong way.
Why wouldn't it be recommended that the interrupt hardware ticks at the requested HZ value ?
The inability of it to tick accurately at the requested HZ value is one of the causes which make jiffies clocksource inaccurate. And that what the comment says.
Thanks,
tglx
Quoted 18 lines · Thomas Gleixner
kernel/time/jiffies.c line 35
Quoted 13 lines · Serafeim Zanikolas
kernel/time/jiffies.c +2
-2@@ -30,8 +30,8 @@ * the timer interrupt frequency HZ and it suffers * inaccuracies caused by missed or lost timer * interrupts and the inability for the timer - * interrupt hardware to accuratly tick at the - * requested HZ value. It is also not reccomended + * interrupt hardware to accurately tick at the + * requested HZ value. It is also not recommended * for "tick-less" systems.You are not only correcting a typo. You are changing the sense of the comment, unfortunately in the wrong way.
Quoted 6 lines
Why wouldn't it be recommended that the interrupt hardware ticks at the requested HZ value ?
The inability of it to tick accurately at the requested HZ value is one of the causes which make jiffies clocksource inaccurate. And that what the comment says.
Thomas,
Please reread the patch again, I think it does exactly what he said it did. Specifically, the old text is:
Quoted 6 lines
Quoted 6 lines
kernel/time/jiffies.c +0
-0* the timer interrupt frequency HZ and it suffers * inaccuracies caused by missed or lost timer * interrupts and the inability for the timer
* interrupt hardware to accuratly tick at the
* requested HZ value. It is also not reccomended
* for "tick-less" systems.
While the new text is:
Quoted 6 lines
Quoted 6 lines
* the timer interrupt frequency HZ and it suffers
* inaccuracies caused by missed or lost timer
* interrupts and the inability for the timer
* interrupt hardware to accurately tick at the
* requested HZ value. It is also not recommended
* for "tick-less" systems.
I misread it the first time myself, mentally combining the second line of the old text with the new text; what you probably saw was:
Quoted 3 lines
Quoted 3 lines
- * requested HZ value. It is also not reccomended
+ * interrupt hardware to accurately tick at the
+ * requested HZ value.
Cheers,
Kyle Moffett
Quoted 19 lines · Kyle Moffett
Thomas,
Please reread the patch again, I think it does exactly what he said it did. Specifically, the old text is:
Quoted 6 lines
Quoted 6 lines
* the timer interrupt frequency HZ and it suffers
* inaccuracies caused by missed or lost timer
* interrupts and the inability for the timer
* interrupt hardware to accuratly tick at the
* requested HZ value. It is also not reccomended
* for "tick-less" systems.While the new text is:
Quoted 6 lines
Quoted 6 lines
* the timer interrupt frequency HZ and it suffers
* inaccuracies caused by missed or lost timer
* interrupts and the inability for the timer
* interrupt hardware to accurately tick at the
* requested HZ value. It is also not recommended
* for "tick-less" systems.
Quoted 6 lines
I misread it the first time myself, mentally combining the second line of the old text with the new text; what you probably saw was:
Quoted 3 lines
Quoted 3 lines
- * requested HZ value. It is also not reccomended
+ * interrupt hardware to accurately tick at the
+ * requested HZ value.
Crap yes. I read it twice and still failed to parse it correctly.
Thanks,
tglx