Skip to contentSkip to conversation

shadow: Switch to getting libtool from PATH

PATCH In review Eric Bénard 3 participants 4 messages Oct 24, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 shadow: Switch to getting libtool from PATH

* with PAM enabled, shadow's libtool sets lt_sysroot to the machine's sysroot and not the arch's sysroot, thus it can't find libpam.
* by using libtool from PATH, this patch fix the problem.
* tested using angstrom-2010.x for an arvm5te target

---
 recipes/shadow/shadow.inc |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
recipes/shadow/shadow.inc +3 -0
index f1476b7..b8f1d2b 100644
@@ -52,6 +52,9 @@ EXTRA_OECONF_libc-uclibc += "\
     ${@base_contains('DISTRO_FEATURES', 'pam', '--with-libpam', '--without-libpam', d)} \
 "
 
+LIBTOOL = "${HOST_SYS}-libtool"
+EXTRA_OEMAKE = "'LIBTOOL=${LIBTOOL}'"
+
 CFLAGS += "-I../include"
 
 PACKAGES =+ "${PN}-group"
Signature · 1 line
1.6.3.3
#1 lore raw

2010/10/24 Eric Bénard <[email protected]>:

Quoted 6 lines

* with PAM enabled, shadow's libtool sets lt_sysroot to the machine's sysroot and not the arch's sysroot, thus it can't find libpam.
* by using libtool from PATH, this patch fix the problem.
* tested using angstrom-2010.x for an arvm5te target

I have fixed it in autotools class. Basically it should have takes care of setting
the sysroot correctly for arch and machine recipes equally. Should be fixed now please pull and retest.

Quoted 27 lines

---
 recipes/shadow/shadow.inc |    3 +++

 1 files changed, 3 insertions(+), 0 deletions(-)
recipes/shadow/shadow.inc +0 -0
index f1476b7..b8f1d2b 100644
@@ -52,6 +52,9 @@ EXTRA_OECONF_libc-uclibc += "\
     ${@base_contains('DISTRO_FEATURES', 'pam', '--with-libpam', '--without-libpam', d)} \

 "

recipes/shadow/shadow.inc +3 -0
+LIBTOOL = "${HOST_SYS}-libtool"
+EXTRA_OEMAKE = "'LIBTOOL=${LIBTOOL}'"
+

 CFLAGS += "-I../include"

 PACKAGES =+ "${PN}-group"
--
1.6.3.3

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#2 lore raw

Hi Khem,

Quoted 6 lines · Khem Raj

2010/10/24 Eric Bénard<[email protected]>:

Quoted 5 lines

* with PAM enabled, shadow's libtool sets lt_sysroot to the machine's sysroot and not the arch's sysroot, thus it can't find libpam.
* by using libtool from PATH, this patch fix the problem.
* tested using angstrom-2010.x for an arvm5te target

Quoted 7 lines
Quoted 1 line

I have fixed it in autotools class. Basically it should have takes care of setting
the sysroot correctly for arch and machine recipes equally. Should be fixed now please pull and retest.

you patch fixe the problem. Thanks

Eric

#3 lore raw

Dear Eric, dear Khem,

Am Sonntag, den 24.10.2010, 21:38 +0200 schrieb Eric Bénard:

Quoted 7 lines · Khem Raj
Quoted 6 lines

2010/10/24 Eric Bénard<[email protected]>:

Quoted 5 lines

* with PAM enabled, shadow's libtool sets lt_sysroot to the machine's sysroot and not the arch's sysroot, thus it can't find libpam.
* by using libtool from PATH, this patch fix the problem.
* tested using angstrom-2010.x for an arvm5te target

Quoted 6 lines
Quoted 6 lines
Quoted 1 line

I have fixed it in autotools class. Basically it should have takes care of setting
the sysroot correctly for arch and machine recipes equally. Should be fixed now please pull and retest.

That is commit 669ac1 [1].

Quoted 2 lines

you patch fixe the problem. Thanks

For me too with angstrom-2008.1 for MACHINE="beagleboard"!

Thanks,

Paul

[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=669ac121adeacd1850f67ab4aa758036f4599135