Skip to contentSkip to conversation

staging: dream: fix information leak to userland

PATCH In review Vasiliy Kulikov 1 participant 1 message Oct 28, 2010

Subsystems (2)
Staging Kernel janitors
lore
Share & tools
lore

Vasiliy Kulikov

author
#0 lore raw

PATCH 5/8 staging: dream: fix information leak to userland

Structure msm_audio_stats is copied to userland with some fields unitialized. It leads to leaking of contents of kernel stack memory.
Also struct msm_audio_config has field "unused" of type array of 3 elements, not 4. Instead of this, initialize field "type".

Signed-off-by Vasiliy Kulikov <[email protected]>
---
 drivers/staging/dream/qdsp5/audio_mp3.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/staging/dream/qdsp5/audio_mp3.c +2 -1
index 409a19c..694f1dd 100644
@@ -533,6 +533,7 @@ static long audio_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 
 	if (cmd = AUDIO_GET_STATS) {
 		struct msm_audio_stats stats;
+		memset(&stats, 0, sizeof(stats));
 		stats.byte_count = audpp_avsync_byte_count(audio->dec_id);
 		stats.sample_count = audpp_avsync_sample_count(audio->dec_id);
 		if (copy_to_user((void *) arg, &stats, sizeof(stats)))

@@ -602,10 +603,10 @@ static long audio_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 		} else {
 			config.channel_count = 2;
 		}
+		config.type = 0;
 		config.unused[0] = 0;
 		config.unused[1] = 0;
 		config.unused[2] = 0;
-		config.unused[3] = 0;
 		if (copy_to_user((void *) arg, &config, sizeof(config))) {
 			rc = -EFAULT;
 		} else {
Signature · 1 line
1.7.0.4