Skip to contentSkip to conversation

staging: vt6656: implement missing brackets

PATCH In review Vasiliy Kulikov 1 participant 1 message Oct 28, 2010

Subsystems (2)
Staging Kernel janitors
lore
Share & tools
lore

Vasiliy Kulikov

author
#0 lore raw

PATCH 8/8 staging: vt6656: implement missing brackets

Identation says that copy_to_user() should be called only iff wrq->u.essid.pointer is not zero. Also it is useless to call copy_to_user(0, ...).

Signed-off-by Vasiliy Kulikov <[email protected]>
---
 drivers/staging/vt6656/main_usb.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/staging/vt6656/main_usb.c +2 -1
index e992d5d..7cc3d24 100644
@@ -1675,13 +1675,14 @@ static int  device_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) {
 
 		{
 			char essid[IW_ESSID_MAX_SIZE+1];
-			if (wrq->u.essid.pointer)
+			if (wrq->u.essid.pointer) {
 				rc = iwctl_giwessid(dev, NULL,
 						    &(wrq->u.essid), essid);
 				if (copy_to_user(wrq->u.essid.pointer,
 						         essid,
 						         wrq->u.essid.length) )
 					rc = -EFAULT;
+			}
 		}
 		break;
Signature · 1 line
1.7.0.4