Skip to contentSkip to conversation

dma: imx-dma: fix imxdma_probe error path

PATCH Superseded Axel Lin 3 participants 5 messages Nov 2, 2010 – Dec 3, 2010

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 dma: imx-dma: fix imxdma_probe error path

otherwise, i will be -1 inside the latest iteration of the while loop.

---
 drivers/dma/imx-dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/dma/imx-dma.c +1 -1
index f629e49..e53d438 100644
@@ -379,7 +379,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
 	return 0;
 
 err_init:
-	while (i-- >= 0) {
+	while (--i >= 0) {
 		struct imxdma_channel *imxdmac = &imxdma->channel[i];
 		imx_dma_free(imxdmac->imxdma_channel);
 	}
Signature · 1 line
1.7.2
#1 lore raw
Quoted 2 lines · Axel Lin

otherwise, i will be -1 inside the latest iteration of the while loop.

nit: s/otherwise, i will be/Otherwise, it will be ?

author
#2 lore raw

2010/11/2 Thiago Farina <[email protected]>:

Quoted 4 lines · Axel Lin
Quoted 2 lines

otherwise, i will be -1 inside the latest iteration of the while loop.

nit: s/otherwise, i will be/Otherwise, it will be ?

I mean the i variable will become -1 inside the latest iteration of the while loop.

Should I resend the patch?

Regards,
Axel

#3 lore raw
Quoted 11 lines · Axel Lin

2010/11/2 Thiago Farina <[email protected]>:

Quoted 4 lines · Axel Lin
Quoted 2 lines

otherwise, i will be -1 inside the latest iteration of the while loop.

nit: s/otherwise, i will be/Otherwise, it will be ?

I mean the i variable will become -1 inside the latest iteration of the while loop.

Should I resend the patch?

Your call, as I got confused others can get confused too.