dma: imx-dma: fix imxdma_probe error path
Subsystems (2)
PATCH 1/1 dma: imx-dma: fix imxdma_probe error path
otherwise, i will be -1 inside the latest iteration of the while loop.
--- drivers/dma/imx-dma.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/dma/imx-dma.c +1 -1
@@ -379,7 +379,7 @@ static int __init imxdma_probe(struct platform_device *pdev)return 0 ; err_init: -while (i-- >=0 ) { +while (--i >=0 ) {struct imxdma_channel *imxdmac = &imxdma->channel[i];imx_dma_free (imxdmac->imxdma_channel); }
Signature · 1 line
1.7.2
Quoted 2 lines · Axel Lin
otherwise, i will be -1 inside the latest iteration of the while loop.
nit: s/otherwise, i will be/Otherwise, it will be ?
2010/11/2 Thiago Farina <[email protected]>:
Quoted 4 lines · Axel Lin
Quoted 2 lines
otherwise, i will be -1 inside the latest iteration of the while loop.
nit: s/otherwise, i will be/Otherwise, it will be ?
I mean the i variable will become -1 inside the latest iteration of the while loop.
Should I resend the patch?
Regards,
Axel
Quoted 11 lines · Axel Lin
2010/11/2 Thiago Farina <[email protected]>:
Quoted 4 lines · Axel Lin
Quoted 2 lines
otherwise, i will be -1 inside the latest iteration of the while loop.
nit: s/otherwise, i will be/Otherwise, it will be ?
I mean the i variable will become -1 inside the latest iteration of the while loop.
Should I resend the patch?
Your call, as I got confused others can get confused too.
Quoted 4 lines · Axel Lin
otherwise, i will be -1 inside the latest iteration of the while loop.
Signed-off-by Axel Lin <[email protected]>---
Catching up on the backlog... applied.