Skip to contentSkip to conversation

usb: misc: sisusbvga: fix information leak to userland

PATCH New Vasiliy Kulikov 1 participant 1 message Nov 6, 2010

Subsystems (3)
USB Kernel janitors Sis USB2VGA driver
lore
Share & tools
lore

Vasiliy Kulikov

author
#0 lore raw

PATCH 1/1 usb: misc: sisusbvga: fix information leak to userland

Structure sisusb_info is copied to userland with "sisusb_reserved" field uninitialized. It leads to leaking of contents of kernel stack memory.

Signed-off-by Vasiliy Kulikov <[email protected]>

---
Compile tested.

 drivers/usb/misc/sisusbvga/sisusb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/usb/misc/sisusbvga/sisusb.c +1 -0
index 70d00e9..dd573ab 100644
@@ -3008,6 +3008,7 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 #else
 			x.sisusb_conactive  = 0;
 #endif
+			memset(x.sisusb_reserved, 0, sizeof(x.sisusb_reserved));
 
 			if (copy_to_user((void __user *)arg, &x, sizeof(x)))
 				retval = -EFAULT;
Signature · 1 line
1.7.0.4