Drivers: dma: Makefile: Cleaned up Makefile
PATCH 1/2 Drivers: dma: Makefile: Cleaned up Makefile
Use the ccflag-y instead of EXTRA_CFLAGS.
Signed-off-by Tracey Dent <[email protected]>
--- drivers/dma/Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/dma/Makefile +2 -2
@@ -1,8 +1,8 @@ ifeq ($(CONFIG_DMADEVICES_DEBUG),y) - EXTRA_CFLAGS += -DDEBUG + ccflags-y += -DDEBUG endif ifeq ($(CONFIG_DMADEVICES_VDEBUG),y) - EXTRA_CFLAGS += -DVERBOSE_DEBUG + ccflags-y += -DVERBOSE_DEBUG endif obj-$(CONFIG_DMA_ENGINE) += dmaengine.o
Signature · 1 line
1.7.3.1.104.gc752e
PATCH 2/2 Drivers: dma: ioat: Makeile: Cleaned up Makefile
Changed Makefile to use <modules>-y instead of <modules>-objs.
Signed-off-by Tracey Dent <[email protected]>
--- drivers/dma/ioat/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/dma/ioat/Makefile +1 -1
@@ -1,2 +1,2 @@ obj-$(CONFIG_INTEL_IOATDMA) += ioatdma.o -ioatdma-objs := pci.o dma.o dma_v2.o dma_v3.o dca.o +ioatdma-y := pci.o dma.o dma_v2.o dma_v3.o dca.o
Signature · 1 line
1.7.3.1.104.gc752e
Quoted 1 line · Tracey Dent
Use the ccflag-y instead of
EXTRA_CFLAGS.
Thanks for the patch.
Please make the subject line: "drivers/dma/: Use the ccflag-y instead of EXTRA_CFLAGS", and the description say why it is preferable to use ccflag-y over EXTRA_CFLAGS.
That would make easy for me to judge why I should apply this.
Ditto for [PATCH 2/2]
--
Dan
Quoted 3 lines · Tracey Dent
Use the ccflag-y instead of
EXTRA_CFLAGS.Signed-off-by Tracey Dent <[email protected]>
Acked-by Linus Walleij <[email protected]>
Linus Walleij