Skip to contentSkip to conversation

manpage: change port option description

PATCH In review Pavel Shilovsky 2 participants 4 messages Nov 18, 2010 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 manpage: change port option description

Provide changes according to new ip/port connection logic in CIFS.

---
 mount.cifs.8 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
mount.cifs.8 +1 -1
index 7d2bf69..b7fe2ad 100644
@@ -132,7 +132,7 @@ instructs the client to ignore any gid provided by the server for files and dire
 .PP
 port=\fIarg\fR
 .RS 4
-sets the port number on the server to attempt to contact to negotiate CIFS support\&. If the CIFS server is not listening on this port or if it is not specified, the default ports will be tried i\&.e\&. port 445 is tried and if no response then port 139 is tried\&.
+sets the port number on the server to attempt to contact to negotiate CIFS support\&. If this value is specified, looking for an existing connection with this port and try to connect if no such a connection\&. Return an error if it fails\&. If this value isn't specified, looking for an existing connection with 445 or 139 port\&. If no such a connection, try to connect with 445 port and if it fails - with 139 port\&. Return an error if both fail\&.
 .RE
 .PP
 servern=\fIarg\fR
Signature · 1 line
1.7.3.2

A message that is not in the archive (sent off-list or not yet received): 1290066485-2618-1-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw
Quoted 12 lines · On Thu, 18 Nov 2010 10:48:05 +0300 Pavel Shilovsky…

Provide changes according to new ip/port connection logic in CIFS.

---
 mount.cifs.8 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
mount.cifs.8 +0 -0
index 7d2bf69..b7fe2ad 100644

mount.cifs.8 instructs the client to ignore any gid provided by the server for files and dire · line 135

Quoted 5 lines
mount.cifs.8 +1 -1
@@ -132,7 +132,7 @@ instructs the client to ignore any gid provided by the server for files and dire
 .PP
 port=\fIarg\fR
 .RS 4
-sets the port number on the server to attempt to contact to negotiate CIFS support\&. If the CIFS server is not listening on this port or if it is not specified, the default ports will be tried i\&.e\&. port 445 is tried and if no response then port 139 is tried\&.
+sets the port number on the server to attempt to contact to negotiate CIFS support\&.

The sentence above is rather awkward. Maybe:

"sets the port number on which the client will attempt to contact the CIFS server".

If this value is specified, looking for an existing connection with this port and try to connect if no such a connection\&. If this value is specified, looking for an existing connection with this port and try to connect if no such a connection\&. Return an error if it fails\&. I

"If this value is specified, look for an existing connection with this port, and use that if one exists. If one doesn't exist, try to create a new connection on that port. If that connection fails, return an error."

If this value isn't specified, looking for an existing connection with 445 or 139 port\&. If no such a connection, try to connect with 445 port and if it fails - with 139 port\&. Return an error if both fail\&.

"If this value isn't specified, look for an existing connection on port 445 or 139. If no such connection exists, try to connect on port 445 first and then port 139 if that fails. Return an error if both fail.

Quoted 6 lines
mount.cifs.8 +0 -0
 .RE
 .PP
 servern=\fIarg\fR
Signature · 1 line
1.7.3.2

If my edits look good to you, I'll plan to merge them after Steve merges the kernel patches.

Thanks,

Signature · 1 line
Jeff Layton <[email protected]>

A message that is not in the archive (sent off-list or not yet received): 20101118085444.2801721a-xSBYVWDuneFaJnirhKH9O4GKTjYczspe@public.gmane.org

#4 lore raw

2010/11/18 Jeff Layton <[email protected]>:

Quoted 2 lines

If my edits look good to you, I'll plan to merge them after Steve merges the kernel patches.

Yes, they are ok. Should I resend patch with your changes to the list?

Signature · 2 lines
Best regards,
Pavel Shilovsky.

A message that is not in the archive (sent off-list or not yet received): AANLkTi=V3ijG5zEVshzdmpbc-FmCMcm2UUOuC6CceBrM-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#6 lore raw
Quoted 9 lines · On Thu, 18 Nov 2010 21:14:27 +0300 Pavel Shilovsky…

2010/11/18 Jeff Layton <[email protected]>:

Quoted 2 lines

If my edits look good to you, I'll plan to merge them after Steve merges the kernel patches.

Yes, they are ok. Should I resend patch with your changes to the list?

Signature · 2 lines
Best regards,
Pavel Shilovsky.

That might be easiest, if you don't mind.

Thanks,

Signature · 1 line
Jeff Layton <[email protected]>