misc/isl29020: Remove incorrect kfree in isl29020_remove()
PATCH 1/1 misc/isl29020: Remove incorrect kfree in isl29020_remove()
struct als_data *data is not used in this driver at all.
Also add a missing ">" character for MODULE_AUTHOR.
Signed-off-by Axel Lin <[email protected]>
--- drivers/misc/isl29020.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/misc/isl29020.c +1 -3
@@ -183,9 +183,7 @@ static int isl29020_probe(struct i2c_client *client,static int isl29020_remove (struct i2c_client *client) { -struct als_data *data =i2c_get_clientdata (client);sysfs_remove_group (&client->dev.kobj, &m_als_gr); -kfree (data);return 0 ; }
@@ -245,6 +243,6 @@ static void __exit sensor_isl29020_exit(void)module_init (sensor_isl29020_init);module_exit (sensor_isl29020_exit); -MODULE_AUTHOR ("Kalhan Trisal <[email protected]" ); +MODULE_AUTHOR ("Kalhan Trisal <[email protected]>" );MODULE_DESCRIPTION ("Intersil isl29020 ALS Driver" );MODULE_LICENSE ("GPL v2" );
Signature · 1 line
1.7.2
Quoted 5 lines · On Fri, 19 Nov 2010 13:27:17 +0800 Axel Lin <[email protected]> wrote:
struct
als_data*data is not used in this driver at all.Also add a missing ">" character for
MODULE_AUTHOR.Signed-off-by Axel Lin <[email protected]>
Acked-by Alan Cox <[email protected]>
It stayed as NULL so the kfree was fine but it definitely wants removing