Skip to contentSkip to conversation

ehci: disable LPM and PPCD for nVidia MCP89 chips

PATCH New Brian J. Tarricone 1 participant 1 message Nov 21, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ehci: disable LPM and PPCD for nVidia MCP89 chips

From: Brian Tarricone <[email protected]>

Tested on MacBookAir3,1. Without this, we get EPROTO errors when fetching device config descriptors.

---
 drivers/usb/host/ehci-pci.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
drivers/usb/host/ehci-pci.c +12 -0
index a1e8d27..aa79f98 100644
@@ -148,6 +148,18 @@ static int ehci_pci_setup(struct usb_hcd *hcd)
 			if (pdev->revision < 0xa4)
 				ehci->no_selective_suspend = 1;
 			break;
+
+		/* MCP89 chips on the MacBookAir3,1 give EPROTO when
+		 * fetching device descriptors unless LPM is disabled.
+		 * There are also intermittent problems enumerating
+		 * devices with PPCD enabled.
+		 */
+		case 0x0d9d:
+			ehci_info(ehci, "disable lpm/ppcd for nvidia mcp89");
+			ehci->has_lpm = 0;
+			ehci->has_ppcd = 0;
+			ehci->command &= ~(CMD_PPCEE);
+			break;
 		}
 		break;
 	case PCI_VENDOR_ID_VIA:
Signature · 1 line
1.7.2.2