Skip to contentSkip to conversation

CIFS: Make cifsFileInfo_put work with strict cache mode (try #2)

PATCH In review Pavel Shilovsky 1 participant 2 messages Nov 21, 2010 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CIFS: Make cifsFileInfo_put work with strict cache mode (try #2)

On strict cache mode when we close the last file handle of the inode we should set invalid_mapping flag on the inode to prevent data coherency problem when we open it again but it has been modified by other clients.

---
 fs/cifs/file.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
fs/cifs/file.c +8 -0
index 08bd364..aeda334 100644
@@ -217,6 +217,7 @@ void cifsFileInfo_put(struct cifsFileInfo *cifs_file)
 	struct inode *inode = cifs_file->dentry->d_inode;
 	struct cifsTconInfo *tcon = tlink_tcon(cifs_file->tlink);
 	struct cifsInodeInfo *cifsi = CIFS_I(inode);
+	struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb);
 	struct cifsLockInfo *li, *tmp;
 
 	spin_lock(&cifs_file_list_lock);
@@ -232,6 +233,13 @@ void cifsFileInfo_put(struct cifsFileInfo *cifs_file)
 	if (list_empty(&cifsi->openFileList)) {
 		cFYI(1, "closing last open instance for inode %p",
 			cifs_file->dentry->d_inode);
+
+		/* in strict cache mode we need invalidate mapping on the last
+		   close  because it may cause a error when we open this file
+		   again and get at least level II oplock */
+		if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_STRICT_IO)
+			CIFS_I(inode)->invalid_mapping = true;
+
 		cifs_set_oplock_level(cifsi, 0);
 	}
 	spin_unlock(&cifs_file_list_lock);
Signature · 1 line
1.7.3.2

A message that is not in the archive (sent off-list or not yet received): 1290367937-11170-1-git-send-email-piastryyy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw

2010/11/21 Pavel Shilovsky <[email protected]>:

Quoted 4 lines

On strict cache mode when we close the last file handle of the inode we should set invalid_mapping flag on the inode to prevent data coherency problem when we open it again but it has been modified by other clients.

Missed CIFS_MOUNT_STRICT_IO definition here - let's consider this version as invalid.

Signature · 2 lines
Best regards,
Pavel Shilovsky.