KVM: Fix fs/gs reload oops with invalid ldt
Quoted 1 line · Greg KH
2.6.32-stable review patch. If anyone has any objections, please let us know.
Obviously it's a bit late now, but...
Quoted 10 lines
------------------
From: Avi Kivity <[email protected]>
commit
9581d442b9058d3699b4be568b6e5eae38a41493upstreamkvm reloads the host's fs and gs blindly, however the underlying segment descriptors may be invalid due to the user modifying the ldt after loading them.
Quoted 8 lines
Fix by using the safe accessors (
loadsegment()andload_gs_index()) instead of home grown unsafe versions.This is CVE-2010-3698.
Signed-off-by Avi Kivity <[email protected]>Signed-off-by Marcelo Tosatti <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
[...]
Avi, you surely knew this commit was buggy (specifically for i386 userland on an amd64 kernel) since you also committed:
commit c8770e7ba63bb5dd8fe5f9d251275a8fa717fb78
Author: Avi Kivity <[email protected]> Date: Thu Nov 11 12:37:26 2010 +0200
KVM: VMX: Fix host userspace gsbase corruption
I realise it wasn't ready for stable as Linus only pulled it in 2.6.37-rc3, but surely that means this neither of the changes should have gone into 2.6.32.26. Why didn't you respond to the review??
Ben.
Signature · 2 lines
Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse.
Quoted 29 lines · Ben Hutchings
Quoted 1 line · Greg KH
2.6.32-stable review patch. If anyone has any objections, please let us know.
Obviously it's a bit late now, but...
Quoted 10 lines
------------------
From: Avi Kivity<[email protected]>
commit
9581d442b9058d3699b4be568b6e5eae38a41493upstreamkvm reloads the host's fs and gs blindly, however the underlying segment descriptors may be invalid due to the user modifying the ldt after loading them.
Quoted 8 lines
Fix by using the safe accessors (
loadsegment()andload_gs_index()) instead of home grown unsafe versions.This is CVE-2010-3698.
Signed-off-by Avi Kivity<[email protected]>Signed-off-by Marcelo Tosatti<[email protected]>Signed-off-by Greg Kroah-Hartman<[email protected]>[...]
Avi, you surely knew this commit was buggy (specifically for i386 userland on an amd64 kernel) since you also committed:
commit
c8770e7ba63bb5dd8fe5f9d251275a8fa717fb78
Quoted 9 lines
Author: Avi Kivity<[email protected]> Date: Thu Nov 11 12:37:26 2010 +0200KVM: VMX: Fix host userspace gsbase corruption
I realise it wasn't ready for stable as Linus only pulled it in 2.6.37-rc3, but surely that means this neither of the changes should have gone into 2.6.32.26. Why didn't you respond to the review??
I don't actually read those review emails, there are too many of them.
The fix will go into 2.6.32.stable in time. Fixing the vulnerability was more important than i386-on-x86_64 anyway.
Signature · 2 lines
I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
Quoted 33 lines · Avi Kivity
Quoted 32 lines · Ben Hutchings
Quoted 1 line · Greg KH
2.6.32-stable review patch. If anyone has any objections, please let us know.
Obviously it's a bit late now, but...
Quoted 10 lines
------------------
From: Avi Kivity<[email protected]>
commit
9581d442b9058d3699b4be568b6e5eae38a41493upstreamkvm reloads the host's fs and gs blindly, however the underlying segment descriptors may be invalid due to the user modifying the ldt after loading them.
Quoted 8 lines
Fix by using the safe accessors (
loadsegment()andload_gs_index()) instead of home grown unsafe versions.This is CVE-2010-3698.
Signed-off-by Avi Kivity<[email protected]>Signed-off-by Marcelo Tosatti<[email protected]>Signed-off-by Greg Kroah-Hartman<[email protected]>[...]
Avi, you surely knew this commit was buggy (specifically for i386 userland on an amd64 kernel) since you also committed:
commit
c8770e7ba63bb5dd8fe5f9d251275a8fa717fb78Author: Avi Kivity<[email protected]> Date: Thu Nov 11 12:37:26 2010 +0200
Quoted 8 lines
Quoted 6 lines
KVM: VMX: Fix host userspace gsbase corruption
I realise it wasn't ready for stable as Linus only pulled it in 2.6.37-rc3, but surely that means this neither of the changes should have gone into 2.6.32.26. Why didn't you respond to the review??
I don't actually read those review emails, there are too many of them.
Please read the ones that are cc:ed to you, otherwise it's pretty pointless for me to send them out :(
thanks,
greg k-h