staging: msm: tvenc: fix error handling

PATCH New Vasiliy Kulikov 1 participant 1 message Nov 26, 2010

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Vasiliy Kulikov

author

2010-11-26 17:06 UTC #0 lore raw

PATCH 1/1 staging: msm: tvenc: fix error handling

Driver init() function should return error code.
Also fix tvenc_clk leak.

Signed-off-by Vasiliy Kulikov <[email protected]>

---
Cannot compile this driver, so it is not tested at all.

 drivers/staging/msm/tvenc.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

drivers/staging/msm/tvenc.c +3 -2

index f41c5ac..4fbb77b 100644
@@ -279,12 +279,13 @@ static int __init tvenc_driver_init(void)
 
 	if (IS_ERR(tvenc_clk)) {
 		printk(KERN_ERR "error: can't get tvenc_clk!\n");
-		return IS_ERR(tvenc_clk);
+		return PTR_ERR(tvenc_clk);
 	}
 
 	if (IS_ERR(tvdac_clk)) {
 		printk(KERN_ERR "error: can't get tvdac_clk!\n");
-		return IS_ERR(tvdac_clk);
+		clk_put(tvenc_clk);
+		return PTR_ERR(tvdac_clk);
 	}
 
 //	pm_qos_add_requirement(PM_QOS_SYSTEM_BUS_FREQ , "tvenc",

Signature · 1 line

1.7.0.4