Skip to contentSkip to conversation

megaraid_sas: Declare poll_aen_lock as static

PATCH In review Ben Hutchings 2 participants 2 messages Nov 27, 2010 – Nov 30, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 megaraid_sas: Declare poll_aen_lock as static

There is no reason for this to be extern.

---
 drivers/scsi/megaraid/megaraid_sas.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/megaraid/megaraid_sas.c +1 -1
index 7451bc0..7050a88 100644
@@ -115,7 +115,7 @@ static u32 megasas_dbg_lvl;
 static u32 support_device_change;
 
 /* define lock for aen poll */
-spinlock_t poll_aen_lock;
+static spinlock_t poll_aen_lock;
 
 static void
 megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd,
Signature · 6 lines
1.7.2.3


-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
#1 lore raw

Ben,

I also don't find out the negative for the original define.

Thanks,

Bo Yang

-----Original Message-----
From: Ben Hutchings [mailto:[email protected]]
Sent: Saturday, November 27, 2010 4:37 PM
To: James E.J. Bottomley
Cc: DL-MegaRAID Linux; [email protected]
Subject: [PATCH] [SCSI] megaraid_sas: Declare poll_aen_lock as static

There is no reason for this to be extern.

---
 drivers/scsi/megaraid/megaraid_sas.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/megaraid/megaraid_sas.c +1 -1
index 7451bc0..7050a88 100644
@@ -115,7 +115,7 @@ static u32 megasas_dbg_lvl;
 static u32 support_device_change;
 
 /* define lock for aen poll */
-spinlock_t poll_aen_lock;
+static spinlock_t poll_aen_lock;
 
 static void
 megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd,
Signature · 6 lines
1.7.2.3


-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.