Skip to contentSkip to conversation

module-init-tools: fix multiple runtime providers

PATCH In review Martin Jansa 3 participants 4 messages Dec 1, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 module-init-tools: fix multiple runtime providers

* NOTE: multiple providers are available for runtime module-init-tools-depmod (module-init-tools, module-init-tools-cross)
NOTE: consider defining a PREFERRED_PROVIDER entry to match module-init-tools-depmod

---
 recipes/module-init-tools/module-init-tools.inc |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
recipes/module-init-tools/module-init-tools.inc +5 -5
index 3cfaf11..247b39a 100644
@@ -3,13 +3,13 @@ removing kernel modules for Linux (versions 2.5.48 and above). It serves \
 the same function that the modutils package serves for Linux 2.4."
 LICENSE = "GPLv2"
 SECTION = "base"
-PR = "r5"
+PR = "r6"
 
-PACKAGES =+ "module-init-tools-insmod-static module-init-tools-depmod"
-RDEPENDS_${PN} += "module-init-tools-depmod"
+PACKAGES =+ "${PN}-insmod-static ${PN}-depmod"
+RDEPENDS_${PN} += "${PN}-depmod"
 
-FILES_module-init-tools-depmod = "${sbindir}/depmod.26"
-FILES_module-init-tools-insmod-static = "${sbindir}/insmod.static"
+FILES_${PN}-depmod = "${sbindir}/depmod.26"
+FILES_${PN}-insmod-static = "${sbindir}/insmod.static"
 
 SRC_URI = "${KERNELORG_MIRROR}/pub/linux/utils/kernel/module-init-tools/module-init-tools-${PV}.tar.bz2 \
 	   file://ignore_arch_directory;apply=yes \
Signature · 1 line
1.7.3.2
Acked-by on v1 1/1
#1 lore raw

2010/12/1 Martin Jansa <[email protected]>:

Quoted 27 lines

* NOTE: multiple providers are available for runtime module-init-tools-depmod (module-init-tools, module-init-tools-cross)
 NOTE: consider defining a PREFERRED_PROVIDER entry to match module-init-tools-depmod
---
 recipes/module-init-tools/module-init-tools.inc |   10 +++++-----

 1 files changed, 5 insertions(+), 5 deletions(-)
recipes/module-init-tools/module-init-tools.inc +0 -0
index 3cfaf11..247b39a 100644
@@ -3,13 +3,13 @@ removing kernel modules for Linux (versions 2.5.48 and above). It serves \

 the same function that the modutils package serves for Linux 2.4." LICENSE = "GPLv2"
 SECTION = "base"

recipes/module-init-tools/module-init-tools.inc +5 -5
-PR = "r5"
+PR = "r6"
 
-PACKAGES =+ "module-init-tools-insmod-static module-init-tools-depmod"
-RDEPENDS_${PN} += "module-init-tools-depmod"
+PACKAGES =+ "${PN}-insmod-static ${PN}-depmod"
+RDEPENDS_${PN} += "${PN}-depmod"
 
-FILES_module-init-tools-depmod = "${sbindir}/depmod.26"
-FILES_module-init-tools-insmod-static = "${sbindir}/insmod.static"
+FILES_${PN}-depmod = "${sbindir}/depmod.26"
+FILES_${PN}-insmod-static = "${sbindir}/insmod.static"
Quoted 3 lines

 SRC_URI = "${KERNELORG_MIRROR}/pub/linux/utils/kernel/module-init-tools/module-init-tools-${PV}.tar.bz2 \
          file://ignore_arch_directory;apply=yes \
--

Thanks for the patch!

still not really sure why we have module-init-tools-cross though. A quick search did not give me a user (but maybe the search was too quick) And still unsure why a cross recipe should produce a package. And maybe it should be module-init-tools-native ?

Frans (puzzled)

#2 lore raw
Quoted 33 lines · Frans Meulenbroeks

2010/12/1 Martin Jansa<[email protected]>:

Quoted 20 lines

* NOTE: multiple providers are available for runtime module-init-tools-depmod (module-init-tools, module-init-tools-cross)
NOTE: consider defining a PREFERRED_PROVIDER entry to match module-init-tools-depmod

---
  recipes/module-init-tools/module-init-tools.inc |   10 +++++-----
  1 files changed, 5 insertions(+), 5 deletions(-)
recipes/module-init-tools/module-init-tools.inc +2 -3
index 3cfaf11..247b39a 100644
@@ -3,13 +3,13 @@ removing kernel modules for Linux (versions 2.5.48 and above). It serves \
  the same function that the modutils package serves for Linux 2.4."
  LICENSE = "GPLv2"
  SECTION = "base"
-PR = "r5"
+PR = "r6"
 
-PACKAGES =+ "module-init-tools-insmod-static module-init-tools-depmod"
-RDEPENDS_${PN} += "module-init-tools-depmod"
+PACKAGES =+ "${PN}-insmod-static ${PN}-depmod"

recipes/module-init-tools/module-init-tools.inc removing kernel modules for Linux (versions 2.5.48 and above). It serves \

Quoted 10 lines
recipes/module-init-tools/module-init-tools.inc +3 -3
+RDEPENDS_${PN} += "${PN}-depmod"
 
-FILES_module-init-tools-depmod = "${sbindir}/depmod.26"
-FILES_module-init-tools-insmod-static = "${sbindir}/insmod.static"
+FILES_${PN}-depmod = "${sbindir}/depmod.26"
+FILES_${PN}-insmod-static = "${sbindir}/insmod.static"
 
  SRC_URI = "${KERNELORG_MIRROR}/pub/linux/utils/kernel/module-init-tools/module-init-tools-${PV}.tar.bz2 \
           file://ignore_arch_directory;apply=yes \
--

Thanks for the patch!

Quoted 6 lines

still not really sure why we have module-init-tools-cross though. A quick search did not give me a user (but maybe the search was too quick) And still unsure why a cross recipe should produce a package. And maybe it should be module-init-tools-native ?

It's used for running depmod on images during creation, iirc.

Signature · 2 lines
Tom Rini
Mentor Graphics Corporation
#3 lore raw

2010/12/1 Tom Rini <[email protected]>:

Quoted 9 lines · Frans Meulenbroeks
Quoted 6 lines

still not really sure why we have module-init-tools-cross though. A quick search did not give me a user (but maybe the search was too quick) And still unsure why a cross recipe should produce a  package. And maybe it should be module-init-tools-native ?

It's used for running depmod on images during creation, iirc.

Do these produce packages (apart from packaged staging).
I would expect it to install its stuff in cross or sysroots or so and be done.

Frans