Skip to contentSkip to conversation

kconfig: do not define AUTOCONF_INCLUDED

PATCH In review Arnaud Lacombe 2 participants 3 messages Dec 5, 2010 – Dec 15, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kconfig: do not define AUTOCONF_INCLUDED

AUTOCONF_INCLUDED is not checked is not used within the tree and its parent header, `autoconf.h', is safe to be re-included.

---
 scripts/kconfig/confdata.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
scripts/kconfig/confdata.c +1 -2
index 9df8011..f349bdc 100644
@@ -833,8 +833,7 @@ int conf_write_autoconf(void)
 		       " * Automatically generated C config: don't edit\n"
 		       " * %s\n"
 		       " * %s"
-		       " */\n"
-		       "#define AUTOCONF_INCLUDED\n",
+		       " */\n",
 		       rootmenu.prompt->text, ctime(&now));
 
 	for_all_symbols(i, sym) {
Signature · 1 line
1.7.2.30.gc37d7.dirty
#1 lore raw

Hi,

Quoted 8 lines · Arnaud Lacombe

AUTOCONF_INCLUDED is not checked is not used within the tree and its parent header, `autoconf.h', is safe to be re-included.

---
 scripts/kconfig/confdata.c |    3 +--

 1 files changed, 1 insertions(+), 2 deletions(-)

ping ?

- Arnaud

Quoted 18 lines
scripts/kconfig/confdata.c +0 -0
index 9df8011..f349bdc 100644
@@ -833,8 +833,7 @@ int conf_write_autoconf(void)

                      " * Automatically generated C config: don't edit\n" " * %s\n"
                      " * %s"
-                      " */\n"
-                      "#define AUTOCONF_INCLUDED\n",
+                      " */\n",
                      rootmenu.prompt->text, ctime(&now));

       for_all_symbols(i, sym) {
--
1.7.2.30.gc37d7.dirty

#2 lore raw
In reply to Arnaud Lacombe
Quoted 2 lines · Arnaud Lacombe

AUTOCONF_INCLUDED is not checked is not used within the tree and its parent header, `autoconf.h', is safe to be re-included.

It could be used by external modules that try to be compatible with pre-2.6.15 kernels, but the fix is trivial in such case (and I guess most of them dropped the #include of autoconf.h after it moved from linux/ to generated/ recently). So I applied this to kbuild-2.6.git#kconfig, thanks.

Michal