ACPI processor: remove processor throttling control procfs I/F
PATCH 2/7 ACPI processor: remove processor throttling control procfs I/F
Remove deprecated ACPI process procfs I/F for throttling control.
This is because the t-state control should only be done in kernel, when system is in a overheating state.
Now users can only change the processor t-state indirectly, by poking the cooling device sysfs I/F of the processor.
Signed-off-by Zhang Rui <[email protected]>
--- drivers/acpi/processor_driver.c | 75 ----------------------- drivers/acpi/processor_throttling.c | 114 ------------------------------------ 2 files changed, 1 insertion(+), 188 deletions(-)
drivers/acpi/processor_driver.c +1 -74
@@ -40,10 +40,6 @@#include <linux/pm.h> #include <linux/cpufreq.h> #include <linux/cpu.h> -#ifdef CONFIG_ACPI_PROCFS -#include <linux/proc_fs.h> -#include <linux/seq_file.h> -#endif #include <linux/dmi.h> #include <linux/moduleparam.h> #include <linux/cpuidle.h>
@@ -246,53 +242,6 @@ static int acpi_processor_errata(structreturn result; } -#ifdef CONFIG_ACPI_PROCFS -static struct proc_dir_entry *acpi_processor_dir =NULL ; - -static int __cpuinit acpi_processor_add_fs (struct acpi_device *device) -{ -struct proc_dir_entry *entry =NULL ; - - -if (!acpi_device_dir (device)) { -acpi_device_dir (device) =proc_mkdir (acpi_device_bid (device), - acpi_processor_dir); -if (!acpi_device_dir (device)) -return -ENODEV ; - } - -/* 'throttling' [R/W] */ - entry =proc_create_data (ACPI_PROCESSOR_FILE_THROTTLING , -S_IFREG |S_IRUGO |S_IWUSR , -acpi_device_dir (device), - &acpi_processor_throttling_fops, -acpi_driver_data (device)); -if (!entry) -return -EIO ; -return 0 ; -} -static int acpi_processor_remove_fs (struct acpi_device *device) -{ - -if (acpi_device_dir (device)) { -remove_proc_entry (ACPI_PROCESSOR_FILE_THROTTLING , -acpi_device_dir (device)); -remove_proc_entry (acpi_device_bid (device), acpi_processor_dir); -acpi_device_dir (device) =NULL ; - } - -return 0 ; -} -#else -static inline int acpi_processor_add_fs (struct acpi_device *device) -{ -return 0 ; -} -static inline int acpi_processor_remove_fs (struct acpi_device *device) -{ -return 0 ; -} -#endif /* -------------------------------------------------------------------------- Driver Interface -------------------------------------------------------------------------- */
@@ -537,14 +486,10 @@ static int __cpuinit acpi_processor_add(per_cpu (processors, pr->id) = pr; - result =acpi_processor_add_fs (device); -if (result) - goto err_free_cpumask; - sysdev =get_cpu_sysdev (pr->id);if (sysfs_create_link (&device->dev.kobj, &sysdev->kobj,"sysdev" )) { result = -EFAULT ; - goto err_remove_fs; + goto err_free_cpumask; }#ifdef CONFIG_CPU_FREQ
@@ -590,8 +535,6 @@ err_thermal_unregister:thermal_cooling_device_unregister (pr->cdev); err_power_exit:acpi_processor_power_exit (pr, device); -err_remove_fs: -acpi_processor_remove_fs (device); err_free_cpumask:free_cpumask_var (pr->throttling.shared_cpu_map);
@@ -620,8 +563,6 @@ static int acpi_processor_remove(structsysfs_remove_link (&device->dev.kobj,"sysdev" ); -acpi_processor_remove_fs (device); -if (pr->cdev) {sysfs_remove_link (&device->dev.kobj,"thermal_cooling" );sysfs_remove_link (&pr->cdev->device.kobj,"device" );
@@ -854,12 +795,6 @@ static int __init acpi_processor_init(vomemset (&errata,0 ,sizeof (errata)); -#ifdef CONFIG_ACPI_PROCFS - acpi_processor_dir =proc_mkdir (ACPI_PROCESSOR_CLASS , acpi_root_dir); -if (!acpi_processor_dir) -return -ENOMEM ; -#endif -if (!cpuidle_register_driver (&acpi_idle_driver)) {printk (KERN_DEBUG "ACPI: %s registered with cpuidle\n" , acpi_idle_driver.name);
@@ -885,10 +820,6 @@ static int __init acpi_processor_init(vo out_cpuidle:cpuidle_unregister_driver (&acpi_idle_driver); -#ifdef CONFIG_ACPI_PROCFS -remove_proc_entry (ACPI_PROCESSOR_CLASS , acpi_root_dir); -#endif -return result; }
@@ -907,10 +838,6 @@ static void __exit acpi_processor_exit(vcpuidle_unregister_driver (&acpi_idle_driver); -#ifdef CONFIG_ACPI_PROCFS -remove_proc_entry (ACPI_PROCESSOR_CLASS , acpi_root_dir); -#endif -return ; }
drivers/acpi/processor_throttling.c +0 -114
123 lines not on this page · raw message
applied
thanks,
Len Brown, Intel Open Source Technology Center