Skip to contentSkip to conversation

poll: fix a typo in comment

PATCH In review Namhyung Kim 3 participants 6 messages Dec 9, 2010 – Dec 10, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 poll: fix a typo in comment

---
 include/linux/poll.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/poll.h +1 -1
index 56e76af78102..afd3375e58ee 100644
@@ -57,7 +57,7 @@ struct poll_table_entry {
 };
 
 /*
- * Structures and helpers for sys_poll/sys_poll
+ * Structures and helpers for sys_select/sys_poll
  */
 struct poll_wqueues {
 	poll_table pt;
Signature · 1 line
1.7.3.3.400.g93cef
#1 lore raw
Quoted 10 lines
---
 include/linux/poll.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/poll.h +0 -0
index 56e76af78102..afd3375e58ee 100644

include/linux/poll.h struct poll_table_entry { · line 61

Quoted 6 lines
include/linux/poll.h +1 -1
@@ -57,7 +57,7 @@ struct poll_table_entry {
 };
 
 /*
- * Structures and helpers for sys_poll/sys_poll
+ * Structures and helpers for sys_select/sys_poll
  */

Now we don't have sys_poll() and sys_poll() function. At least they are hidden by SYSCALL_DEFINEx() macro.

so probably, "for select/poll syscall" is better explanation?

Quoted 10 lines
include/linux/poll.h +0 -0
 struct poll_wqueues {
 	poll_table pt;
Signature · 7 lines
1.7.3.3.400.g93cef

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
#2 lore raw
Quoted 20 lines · KOSAKI Motohiro
Quoted 10 lines

---
 include/linux/poll.h |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/poll.h +0 -0
index 56e76af78102..afd3375e58ee 100644

include/linux/poll.h struct poll_table_entry { · line 61

Quoted 6 lines
include/linux/poll.h +1 -1
@@ -57,7 +57,7 @@ struct poll_table_entry {
  };
 
  /*
- * Structures and helpers for sys_poll/sys_poll
+ * Structures and helpers for sys_select/sys_poll
   */

Now we don't have sys_poll() and sys_poll() function. At least they are hidden by SYSCALL_DEFINEx() macro.

Quoted 2 lines

so probably, "for select/poll syscall" is better explanation?

Good point. Will resend.
Thanks.

Signature · 2 lines
Regards,
Namhyung Kim
#3 lore raw

PATCH 1/1 poll: fix a typo in comment

Convert duplicated sys_poll to select. As Kosaki suggests, sys_poll() and sys_select() are now hidden by SYSCALL_DEFINEx() macros so it would be better to use plain select/poll syscall name.

---
 include/linux/poll.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/poll.h +1 -1
index 56e76af78102..afd3375e58ee 100644
@@ -57,7 +57,7 @@ struct poll_table_entry {
 };
 
 /*
- * Structures and helpers for sys_poll/sys_poll
+ * Structures and helpers for select/poll syscall
  */
 struct poll_wqueues {
 	poll_table pt;
Signature · 1 line
1.7.3.3.400.g93cef
Reviewed-by on v1 1/1
#4 lore raw
Quoted 5 lines

Convert duplicated sys_poll to select. As Kosaki suggests, sys_poll() and sys_select() are now hidden by SYSCALL_DEFINEx() macros so it would be better to use plain select/poll syscall name.

Thank you.

Quoted 20 lines
---
 include/linux/poll.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/poll.h +1 -1
index 56e76af78102..afd3375e58ee 100644
@@ -57,7 +57,7 @@ struct poll_table_entry {
 };
 
 /*
- * Structures and helpers for sys_poll/sys_poll
+ * Structures and helpers for select/poll syscall
  */
 struct poll_wqueues {
 	poll_table pt;
Signature · 1 line
1.7.3.3.400.g93cef
Applied
#5 lore raw
Quoted 8 lines · KOSAKI Motohiro
Quoted 5 lines

Convert duplicated sys_poll to select. As Kosaki suggests, sys_poll() and sys_select() are now hidden by SYSCALL_DEFINEx() macros so it would be better to use plain select/poll syscall name.

Thank you.

Applied.

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.