usb: otg: Kconfig: Add Kconfig option for TWL6030 transceiver.

PATCH In review Hema HK 4 participants 5 messages Dec 10, 2010 2 messages not in the archive USB

lore

Share & tools

lore

Hema HK

author

2010-12-10 07:04 UTC #0 lore raw

PATCH v2 3/7 usb: otg: Kconfig: Add Kconfig option for TWL6030 transceiver.

Added the TWL6030-usb transceiver option in the Kconfig

Signed-off-by Hema HK <[email protected]>

Cc Felipe Balbi <[email protected]>

Cc David Brownell <[email protected]>

---
 drivers/usb/otg/Kconfig |   12 ++++++++++++
 1 file changed, 12 insertions(+)

drivers/usb/otg/Kconfig +12 -0

Index: usb/drivers/usb/otg/Kconfig
===================================================================
@@ -59,6 +59,18 @@ config TWL4030_USB
 	  This transceiver supports high and full speed devices plus,
 	  in host mode, low speed.
 
+config TWL6030_USB
+	tristate "TWL6030 USB Transceiver Driver"
+	depends on TWL4030_CORE
+	select USB_OTG_UTILS
+	help
+	  Enable this to support the USB OTG transceiver on TWL6030
+	  family chips. This TWL6030 transceiver has the VBUS and ID GND
+	  and OTG SRP events capabilities. For all other transceiver functionality
+	  UTMI PHY is embedded in OMAP4430. The internal PHY configurations APIs
+	  are hooked to this driver through platform_data structure.
+	  The definition of internal PHY APIs are in the mach-omap2 layer.
+
 config NOP_USB_XCEIV
 	tristate "NOP USB Transceiver Driver"
 	select USB_OTG_UTILS

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1291964675-7114-1-git-send-email-hemahk-l0cyMroinI0@public.gmane.org

drivers/usb/otg/twl6030-usb.c: In function 'twl6030_set_phy_clk':
drivers/usb/otg/twl6030-usb.c:145: error: 'struct twl4030_usb_data' has no member named 'phy_set_clock' drivers/usb/otg/twl6030-usb.c: In function 'twl6030_phy_init':
drivers/usb/otg/twl6030-usb.c:166: error: 'struct twl4030_usb_data' has no member named 'phy_power' drivers/usb/otg/twl6030-usb.c:168: error: 'struct twl4030_usb_data' has no member named 'phy_power'
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_phy_shutdown':
drivers/usb/otg/twl6030-usb.c:182: error: 'struct twl4030_usb_data' has no member named 'phy_power'
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_usb_probe':
drivers/usb/otg/twl6030-usb.c:440: error: 'struct twl4030_usb_data' has no member named 'phy_init'
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_usb_remove':
drivers/usb/otg/twl6030-usb.c:462: error: 'struct twl4030_usb_data' has no member named 'phy_exit'
make[2]: *** [drivers/usb/otg/twl6030-usb.o] Error 1 make[1]: *** [drivers/usb/otg] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
make: *** Waiting for unfinished jobs....

please fix ASAP or we will loose the merge window.

Signature · 5 lines

balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20101210084126.GE2576-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org

Kalliguddi, Hema

author

2010-12-10 11:26 UTC #4 lore raw

Quoted 59 lines · Felipe Balbi

Quoted 18 lines · Hema HK
Added the TWL6030-usb transceiver option in the Kconfig
Signed-off-by Hema HK <[email protected]>
Cc Felipe Balbi <[email protected]>
Cc David Brownell <[email protected]>
---
drivers/usb/otg/Kconfig | 12 ++++++++++++
1 file changed, 12 insertions(+)
Index: usb/drivers/usb/otg/Kconfig
===================================================================
drivers/usb/otg/Kconfig +0 -0
@@ -59,6 +59,18 @@ config TWL4030_USB
          This transceiver supports high and full speed devices plus,
in host mode, low speed.
Quoted 14 lines
+config TWL6030_USB
+ tristate "TWL6030 USB Transceiver Driver"
+ depends on TWL4030_CORE
+ select USB_OTG_UTILS
+ help
+ Enable this to support the USB OTG transceiver on TWL6030
+ family chips. This TWL6030 transceiver has the VBUS and ID GND
+ and OTG SRP events capabilities. For all other transceiver functionality
+ UTMI PHY is embedded in OMAP4430. The internal PHY configurations APIs
+ are hooked to this driver through platform_data structure.
+ The definition of internal PHY APIs are in the mach-omap2 layer. +
When compiling with this patch:
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_set_phy_clk':
drivers/usb/otg/twl6030-usb.c:145: error: 'struct twl4030_usb_data' has no member named 'phy_set_clock' drivers/usb/otg/twl6030-usb.c: In function 'twl6030_phy_init':
drivers/usb/otg/twl6030-usb.c:166: error: 'struct twl4030_usb_data' has no member named 'phy_power' drivers/usb/otg/twl6030-usb.c:168: error: 'struct twl4030_usb_data' has no member named 'phy_power'
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_phy_shutdown':
drivers/usb/otg/twl6030-usb.c:182: error: 'struct twl4030_usb_data' has no member named 'phy_power'
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_usb_probe':
drivers/usb/otg/twl6030-usb.c:440: error: 'struct twl4030_usb_data' has no member named 'phy_init'
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_usb_remove':
drivers/usb/otg/twl6030-usb.c:462: error: 'struct twl4030_usb_data' has no member named 'phy_exit'
make[2]: *** [drivers/usb/otg/twl6030-usb.o] Error 1 make[1]: *** [drivers/usb/otg] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
make: *** Waiting for unfinished jobs....

Quoted 1 line

please fix ASAP or we will loose the merge window.

With this patch twl6030_usb file still not added for build, I am wondering how are
you getting How are you getting build error?

Regards,
Hema

Quoted 4 lines

--
balbi

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Felipe Balbi

2010-12-10 11:43 UTC #5 lore raw

Quoted 60 lines · Hema

Quoted 59 lines · Felipe Balbi
Quoted 18 lines · Hema HK
Added the TWL6030-usb transceiver option in the Kconfig
Signed-off-by Hema HK <[email protected]>
Cc Felipe Balbi <[email protected]>
Cc David Brownell <[email protected]>
---
drivers/usb/otg/Kconfig | 12 ++++++++++++
1 file changed, 12 insertions(+)
Index: usb/drivers/usb/otg/Kconfig
===================================================================
drivers/usb/otg/Kconfig +0 -0
@@ -59,6 +59,18 @@ config TWL4030_USB
          This transceiver supports high and full speed devices plus,
in host mode, low speed.
Quoted 14 lines
+config TWL6030_USB
+ tristate "TWL6030 USB Transceiver Driver"
+ depends on TWL4030_CORE
+ select USB_OTG_UTILS
+ help
+ Enable this to support the USB OTG transceiver on TWL6030
+ family chips. This TWL6030 transceiver has the VBUS and ID GND
+ and OTG SRP events capabilities. For all other transceiver functionality
+ UTMI PHY is embedded in OMAP4430. The internal PHY configurations APIs
+ are hooked to this driver through platform_data structure.
+ The definition of internal PHY APIs are in the mach-omap2 layer. +
When compiling with this patch:
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_set_phy_clk':
drivers/usb/otg/twl6030-usb.c:145: error: 'struct twl4030_usb_data' has no member named 'phy_set_clock' drivers/usb/otg/twl6030-usb.c: In function 'twl6030_phy_init':
drivers/usb/otg/twl6030-usb.c:166: error: 'struct twl4030_usb_data' has no member named 'phy_power' drivers/usb/otg/twl6030-usb.c:168: error: 'struct twl4030_usb_data' has no member named 'phy_power'
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_phy_shutdown':
drivers/usb/otg/twl6030-usb.c:182: error: 'struct twl4030_usb_data' has no member named 'phy_power'
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_usb_probe':
drivers/usb/otg/twl6030-usb.c:440: error: 'struct twl4030_usb_data' has no member named 'phy_init'
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_usb_remove':
drivers/usb/otg/twl6030-usb.c:462: error: 'struct twl4030_usb_data' has no member named 'phy_exit'
make[2]: *** [drivers/usb/otg/twl6030-usb.o] Error 1 make[1]: *** [drivers/usb/otg] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
make: *** Waiting for unfinished jobs....

Quoted 5 lines

Quoted 1 line
please fix ASAP or we will loose the merge window.
With this patch twl6030_usb file still not added for build, I am wondering how are
you getting How are you getting build error?

This is *the* patch that adds it to Kbuild :-) the previous patch already added Makefile change.

Signature · 5 lines

balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Kalliguddi, Hema

2010-12-10 11:44 UTC #6 lore raw

Quoted 64 lines · Felipe Balbi

Quoted 63 lines · Hema
Quoted 61 lines · Felipe Balbi
Quoted 18 lines · Hema HK
Added the TWL6030-usb transceiver option in the Kconfig
Signed-off-by Hema HK <[email protected]>
Cc Felipe Balbi <[email protected]>
Cc David Brownell <[email protected]>
---
drivers/usb/otg/Kconfig | 12 ++++++++++++
1 file changed, 12 insertions(+)
Index: usb/drivers/usb/otg/Kconfig
===================================================================
drivers/usb/otg/Kconfig +0 -0
@@ -59,6 +59,18 @@ config TWL4030_USB
          This transceiver supports high and full speed devices plus,
in host mode, low speed.
Quoted 15 lines
+config TWL6030_USB
+ tristate "TWL6030 USB Transceiver Driver"
+ depends on TWL4030_CORE
+ select USB_OTG_UTILS
+ help
+ Enable this to support the USB OTG transceiver on TWL6030
+ family chips. This TWL6030 transceiver has the VBUS and ID GND
+ and OTG SRP events capabilities. For all other transceiver functionality
+ UTMI PHY is embedded in OMAP4430. The internal PHY configurations APIs
+ are hooked to this driver through platform_data structure.
+ The definition of internal PHY APIs are in the mach-omap2 layer.
+
When compiling with this patch:
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_set_phy_clk':
drivers/usb/otg/twl6030-usb.c:145: error: 'struct twl4030_usb_data' has no member named 'phy_set_clock' drivers/usb/otg/twl6030-usb.c: In function 'twl6030_phy_init':
drivers/usb/otg/twl6030-usb.c:166: error: 'struct twl4030_usb_data' has no member named 'phy_power' drivers/usb/otg/twl6030-usb.c:168: error: 'struct twl4030_usb_data' has no member named 'phy_power'
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_phy_shutdown':
drivers/usb/otg/twl6030-usb.c:182: error: 'struct twl4030_usb_data' has no member named 'phy_power'
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_usb_probe':
drivers/usb/otg/twl6030-usb.c:440: error: 'struct twl4030_usb_data' has no member named 'phy_init'
drivers/usb/otg/twl6030-usb.c: In function 'twl6030_usb_remove':
drivers/usb/otg/twl6030-usb.c:462: error: 'struct twl4030_usb_data' has no member named 'phy_exit'
make[2]: *** [drivers/usb/otg/twl6030-usb.o] Error 1 make[1]: *** [drivers/usb/otg] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
make: *** Waiting for unfinished jobs....

Quoted 9 lines

Quoted 5 lines
Quoted 1 line
please fix ASAP or we will loose the merge window.
With this patch twl6030_usb file still not added for build, I am wondering how are
you getting How are you getting build error?
This is *the* patch that adds it to Kbuild :-) the previous patch already added Makefile change.

Agree. Got confused with omap_phy_internal.c file. I am fixing it. I will send you the patches. Regards,
Hema

Quoted 3 lines

--
balbi

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html