netfilter: ctnetlink: fix loop in ctnetlink_get_conntrack()
Subsystems (2)
[email protected]
maintainerPATCH 1/1 netfilter: ctnetlink: fix loop in ctnetlink_get_conntrack()
From: Pablo Neira Ayuso <[email protected]>
This patch fixes a loop in ctnetlink_get_conntrack() that can be triggered if you use the same socket to receive events and to perform a GET operation. Under heavy load, netlink_unicast() may return -EAGAIN, this error code is reserved in nfnetlink for the module load-on-demand. Instead, we return -ENOBUFS which is the appropriate error code that has to be propagated to user-space.
Reported-by Holger Eitzenberger <[email protected]>
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- net/netfilter/nf_conntrack_netlink.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
net/netfilter/nf_conntrack_netlink.c +2 -1
@@ -972,7 +972,8 @@ ctnetlink_get_conntrack(struct sock *ctnl, struct sk_buff *skb, free:kfree_skb (skb2); out: -return err; +/* this avoids a loop in nfnetlink. */ +return err == -EAGAIN ? -ENOBUFS : err; }#ifdef CONFIG_NF_NAT_NEEDED
Signature · 1 line
1.7.2.3