Skip to contentSkip to conversation

drm/i915/execbuffer: Reorder binding of objects to favour restrictions

regression Alexey Fisher 2 participants 5 messages Jan 14, 2011 – Jan 16, 2011

lore
Share & tools
lore
#0 lore raw

Hi Chris,

i have new regression after this patch. Like usual, artifakts, disappearing icons, with only one difference gl seems to work ok.

see screencast in attachment.

My HW:
board Intel DG45ID, graphic:
Vendor: 0x8086, Device: 0x2e22, Revision: 0x03 (A3)

xserver-xorg-video-intel 2:2.14.0+git20110110.fd9235eb-0ubuntu0sarvatt~maverick

xserver-xorg
1:7.5+6+xserver1.9

commit 6fe4f14044f181e146cdc15485428f95fa541ce8
Author: Chris Wilson <[email protected]>
Date: Mon Jan 10 17:35:37 2011 +0000

drm/i915/execbuffer: Reorder binding of objects to favour restrictions

As the mappable portion of the aperture is always a small subset at the start of the GTT, it is allocated preferentially by drm_mm. This is useful in case we ever need to map an object later. However, if you have a large object that can consume the entire mappable region of the GTT this prevents the batchbuffer from fitting and so causing an error. Instead allocate all those that require a mapping up front in order to improve the likelihood of finding sufficient space to bind them.

Signature · 2 lines
Regards,
        Alexey

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#1 lore raw

Hi Chris,
did you got my regression report?

Am Freitag, den 14.01.2011, 16:11 +0100 schrieb Alexey Fisher:

Quoted 36 lines

Hi Chris,

i have new regression after this patch. Like usual, artifakts, disappearing icons, with only one difference gl seems to work ok.

see screencast in attachment.

My HW:
board Intel DG45ID, graphic:
Vendor: 0x8086, Device: 0x2e22, Revision: 0x03 (A3)

xserver-xorg-video-intel 2:2.14.0+git20110110.fd9235eb-0ubuntu0sarvatt~maverick

xserver-xorg
1:7.5+6+xserver1.9

commit 6fe4f14044f181e146cdc15485428f95fa541ce8
Author: Chris Wilson <[email protected]>
Date: Mon Jan 10 17:35:37 2011 +0000

drm/i915/execbuffer: Reorder binding of objects to favour restrictions

As the mappable portion of the aperture is always a small subset at the start of the GTT, it is allocated preferentially by drm_mm. This is useful in case we ever need to map an object later. However, if you have a large object that can consume the entire mappable region of the GTT this prevents the batchbuffer from fitting and so causing an error. Instead allocate all those that require a mapping up front in order to improve the likelihood of finding sufficient space to bind them.

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 2 lines
Regards,
        Alexey
#2 lore raw
Quoted 2 lines · Alexey Fisher

Hi Chris,
did you got my regression report?

It appears you didn't get my response saying Linus had already pulled the fix.
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#3 lore raw

Am Sonntag, den 16.01.2011, 14:53 +0000 schrieb Chris Wilson:

Quoted 8 lines · Alexey Fisher
Quoted 2 lines

Hi Chris,
did you got my regression report?

It appears you didn't get my response saying Linus had already pulled the fix.
-Chris

Ah, ok.

Then the fix is not in drm-intel-next

Signature · 2 lines
Regards,
        Alexey
#4 lore raw
Quoted 5 lines · Alexey Fisher

Am Sonntag, den 16.01.2011, 14:53 +0000 schrieb Chris Wilson:

Quoted 4 lines · Alexey Fisher
Quoted 2 lines

Hi Chris,
did you got my regression report?

Quoted 8 lines
Quoted 4 lines

It appears you didn't get my response saying Linus had already pulled the fix.
-Chris

Ah, ok.

Then the fix is not in drm-intel-next

No, I haven't started pulling in stuff for -next just yet. I've a few tagged but my focus is currently on making sure -fixes/rc1 has no further regressions. Once -rc1 is released, I'll sync up.
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre