Skip to contentSkip to conversation

insane bbclass: extend RPATH check to cover sysroots as well

PATCH NAK Koen Kooi 5 participants 12 messages Jan 19, 2011 – Jan 26, 2011

lore
Share & tools
lore

Koen Kooi

author
#0 lore raw

PATCH 1/1 insane bbclass: extend RPATH check to cover sysroots as well

* Having rpath to sysroot is just as bad as one to workdir

Based on insane.bbclass from yocto

---
 classes/insane.bbclass |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)
classes/insane.bbclass +6 -5
index 677db27..50752b5 100644
@@ -160,20 +160,21 @@ def package_qa_check_rpath(file,name,d, elf):
     import bb, os
     sane = True
     scanelf = os.path.join(bb.data.getVar('STAGING_BINDIR_NATIVE',d,True),'scanelf')
-    bad_dir = bb.data.getVar('TMPDIR', d, True) + "/work"
+    bad_dirs = [bb.data.getVar('TMPDIR', d, True) + "/work", bb.data.getVar('STAGING_DIR_TARGET', d, True)]
     bad_dir_test = bb.data.getVar('TMPDIR', d, True)
     if not os.path.exists(scanelf):
         bb.fatal("Can not check RPATH, scanelf (part of pax-utils-native) not found")
 
-    if not bad_dir in bb.data.getVar('WORKDIR', d, True):
+    if not bad_dirs[0] in bb.data.getVar('WORKDIR', d, True):
         bb.fatal("This class assumed that WORKDIR is ${TMPDIR}/work... Not doing any check")
 
     output = os.popen("%s -B -F%%r#F '%s'" % (scanelf,file))
     txt    = output.readline().split()
     for line in txt:
-        if bad_dir in line:
-            error_msg = "package %s contains bad RPATH %s in file %s" % (name, line, file)
-            sane = package_qa_handle_error(1, error_msg, name, file, d)
+        for dir in bad_dirs:
+            if dir in line:
+                error_msg = "package %s contains bad RPATH %s in file %s" % (name, line, file)
+                sane = sane + package_qa_handle_error(1, error_msg, name, file, d)
 
     return sane
 
Signature · 1 line
1.6.6.1
#1 lore raw
Quoted 1 line · Koen Kooi

* Having rpath to sysroot is just as bad as one to workdir

When you do a build with this, how many recipes have issues?

Philip

Quoted 39 lines

Based on insane.bbclass from yocto

---
  classes/insane.bbclass |   11 ++++++-----
  1 files changed, 6 insertions(+), 5 deletions(-)
classes/insane.bbclass +6 -5
index 677db27..50752b5 100644
@@ -160,20 +160,21 @@ def package_qa_check_rpath(file,name,d, elf):
      import bb, os
      sane = True
      scanelf = os.path.join(bb.data.getVar('STAGING_BINDIR_NATIVE',d,True),'scanelf')
-    bad_dir = bb.data.getVar('TMPDIR', d, True) + "/work"
+    bad_dirs = [bb.data.getVar('TMPDIR', d, True) + "/work", bb.data.getVar('STAGING_DIR_TARGET', d, True)]
      bad_dir_test = bb.data.getVar('TMPDIR', d, True)
      if not os.path.exists(scanelf):
          bb.fatal("Can not check RPATH, scanelf (part of pax-utils-native) not found")
 
-    if not bad_dir in bb.data.getVar('WORKDIR', d, True):
+    if not bad_dirs[0] in bb.data.getVar('WORKDIR', d, True):
          bb.fatal("This class assumed that WORKDIR is ${TMPDIR}/work... Not doing any check")
 
      output = os.popen("%s -B -F%%r#F '%s'" % (scanelf,file))
      txt    = output.readline().split()
      for line in txt:
-        if bad_dir in line:
-            error_msg = "package %s contains bad RPATH %s in file %s" % (name, line, file)
-            sane = package_qa_handle_error(1, error_msg, name, file, d)
+        for dir in bad_dirs:
+            if dir in line:
+                error_msg = "package %s contains bad RPATH %s in file %s" % (name, line, file)
+                sane = sane + package_qa_handle_error(1, error_msg, name, file, d)
 
      return sane
 
#2 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 4 lines · Philip Balister
Quoted 1 line · Koen Kooi

* Having rpath to sysroot is just as bad as one to workdir

When you do a build with this, how many recipes have issues?

At least udev:

ERROR: QA Issue with udev: package udev contains bad RPATH /OE/angstrom-setup-scripts/build/tmp-angstrom_2008_1/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib
in file /OE/angstrom-setup-scripts/build/tmp-angstrom_2008_1/work/armv7a-angstrom-linux-gnueabi/udev-165-r0/packages-split/udev/lib/udev/udev-acl
ERROR: QA Issue with udev: package udev contains bad RPATH /OE/angstrom-setup-scripts/build/tmp-angstrom_2008_1/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib
in file /OE/angstrom-setup-scripts/build/tmp-angstrom_2008_1/work/armv7a-angstrom-linux-gnueabi/udev-165-r0/packages-split/udev/lib/udev/hid2hci
ERROR: QA Issue with udev: package udev contains bad RPATH /OE/angstrom-setup-scripts/build/tmp-angstrom_2008_1/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib
in file /OE/angstrom-setup-scripts/build/tmp-angstrom_2008_1/work/armv7a-angstrom-linux-gnueabi/udev-165-r0/packages-split/udev/lib/udev/mobile-action-modeswitch

I'm doing a build from scratch now to see what will fail first.
Richard and Scott have fixed a number of those in yocto, so I'll be working with them and Khem to 'port' those over to OE.

This patch is merely here to have people realize how buggered OE currently is with stray RPATHs

regards,

Koen

Quoted 48 lines

Philip

Quoted 44 lines

Based on insane.bbclass from yocto

---
  classes/insane.bbclass |   11 ++++++-----
  1 files changed, 6 insertions(+), 5 deletions(-)
classes/insane.bbclass +1 -1
index 677db27..50752b5 100644
@@ -160,20 +160,21 @@ def package_qa_check_rpath(file,name,d, elf):
      import bb, os
      sane = True
      scanelf =
 os.path.join(bb.data.getVar('STAGING_BINDIR_NATIVE',d,True),'scanelf')
-    bad_dir = bb.data.getVar('TMPDIR', d, True) + "/work"
+    bad_dirs = [bb.data.getVar('TMPDIR', d, True) + "/work",

bb.data.getVar('STAGING_DIR_TARGET', d, True)]
bad_dir_test = bb.data.getVar('TMPDIR', d, True) if not os.path.exists(scanelf):
bb.fatal("Can not check RPATH, scanelf (part of
pax-utils-native) not found")

classes/insane.bbclass +1 -1
-    if not bad_dir in bb.data.getVar('WORKDIR', d, True):
+    if not bad_dirs[0] in bb.data.getVar('WORKDIR', d, True):
          bb.fatal("This class assumed that WORKDIR is

${TMPDIR}/work... Not doing any check")

output = os.popen("%s -B -F%%r#F '%s'" % (scanelf,file))
txt = output.readline().split()
for line in txt:

classes/insane.bbclass +0 -2
-        if bad_dir in line:
-            error_msg = "package %s contains bad RPATH %s in file %s"

% (name, line, file)

classes/insane.bbclass +3 -1
-            sane = package_qa_handle_error(1, error_msg, name, file, d)
+        for dir in bad_dirs:
+            if dir in line:
+                error_msg = "package %s contains bad RPATH %s in file

%s" % (name, line, file)
+ sane = sane + package_qa_handle_error(1, error_msg,
name, file, d)

Quoted 2 lines
Quoted 2 lines

return sane

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNN0JLMkyGM64RGpERAlmoAKC4ydMPfud8DpW5RZOEtiB+z+o0DACeO2jb dmskeJB73C+waA899CHri2w=
=q33T
-----END PGP SIGNATURE-----

#3 lore raw
In reply to Philip Balister

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 4 lines · Philip Balister
Quoted 1 line · Koen Kooi

* Having rpath to sysroot is just as bad as one to workdir

When you do a build with this, how many recipes have issues?

Console-image is clean now :)

Quoted 48 lines

Philip

Quoted 44 lines

Based on insane.bbclass from yocto

---
  classes/insane.bbclass |   11 ++++++-----
  1 files changed, 6 insertions(+), 5 deletions(-)
classes/insane.bbclass +1 -1
index 677db27..50752b5 100644
@@ -160,20 +160,21 @@ def package_qa_check_rpath(file,name,d, elf):
      import bb, os
      sane = True
      scanelf =
 os.path.join(bb.data.getVar('STAGING_BINDIR_NATIVE',d,True),'scanelf')
-    bad_dir = bb.data.getVar('TMPDIR', d, True) + "/work"
+    bad_dirs = [bb.data.getVar('TMPDIR', d, True) + "/work",

bb.data.getVar('STAGING_DIR_TARGET', d, True)]
bad_dir_test = bb.data.getVar('TMPDIR', d, True) if not os.path.exists(scanelf):
bb.fatal("Can not check RPATH, scanelf (part of
pax-utils-native) not found")

classes/insane.bbclass +1 -1
-    if not bad_dir in bb.data.getVar('WORKDIR', d, True):
+    if not bad_dirs[0] in bb.data.getVar('WORKDIR', d, True):
          bb.fatal("This class assumed that WORKDIR is

${TMPDIR}/work... Not doing any check")

output = os.popen("%s -B -F%%r#F '%s'" % (scanelf,file))
txt = output.readline().split()
for line in txt:

classes/insane.bbclass +0 -2
-        if bad_dir in line:
-            error_msg = "package %s contains bad RPATH %s in file %s"

% (name, line, file)

classes/insane.bbclass +3 -1
-            sane = package_qa_handle_error(1, error_msg, name, file, d)
+        for dir in bad_dirs:
+            if dir in line:
+                error_msg = "package %s contains bad RPATH %s in file

%s" % (name, line, file)
+ sane = sane + package_qa_handle_error(1, error_msg,
name, file, d)

Quoted 2 lines
Quoted 2 lines

return sane

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNN9/tMkyGM64RGpERAn11AJ9sK9ogzEj85I4/K9GQcuVv5H/3fwCggcuh yC7f8pPrDqqbunzVJtESnAg=
=W2AG
-----END PGP SIGNATURE-----

#4 lore raw
In reply to Philip Balister

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 7 lines · Koen Kooi
Quoted 4 lines · Philip Balister
Quoted 1 line · Koen Kooi

* Having rpath to sysroot is just as bad as one to workdir

When you do a build with this, how many recipes have issues?

Console-image is clean now :)

And angstrom-gnome-image as well, so can I get some Acks or tested-bys please?

Quoted 49 lines
Quoted 49 lines

Philip

Quoted 44 lines

Based on insane.bbclass from yocto

---
  classes/insane.bbclass |   11 ++++++-----
  1 files changed, 6 insertions(+), 5 deletions(-)
classes/insane.bbclass +1 -1
index 677db27..50752b5 100644
@@ -160,20 +160,21 @@ def package_qa_check_rpath(file,name,d, elf):
      import bb, os
      sane = True
      scanelf =
 os.path.join(bb.data.getVar('STAGING_BINDIR_NATIVE',d,True),'scanelf')
-    bad_dir = bb.data.getVar('TMPDIR', d, True) + "/work"
+    bad_dirs = [bb.data.getVar('TMPDIR', d, True) + "/work",

bb.data.getVar('STAGING_DIR_TARGET', d, True)]
bad_dir_test = bb.data.getVar('TMPDIR', d, True) if not os.path.exists(scanelf):
bb.fatal("Can not check RPATH, scanelf (part of
pax-utils-native) not found")

classes/insane.bbclass +1 -1
-    if not bad_dir in bb.data.getVar('WORKDIR', d, True):
+    if not bad_dirs[0] in bb.data.getVar('WORKDIR', d, True):
          bb.fatal("This class assumed that WORKDIR is

${TMPDIR}/work... Not doing any check")

output = os.popen("%s -B -F%%r#F '%s'" % (scanelf,file))
txt = output.readline().split()
for line in txt:

classes/insane.bbclass +0 -2
-        if bad_dir in line:
-            error_msg = "package %s contains bad RPATH %s in file %s"

% (name, line, file)

classes/insane.bbclass +3 -1
-            sane = package_qa_handle_error(1, error_msg, name, file, d)
+        for dir in bad_dirs:
+            if dir in line:
+                error_msg = "package %s contains bad RPATH %s in file

%s" % (name, line, file)
+ sane = sane + package_qa_handle_error(1, error_msg,
name, file, d)

Quoted 3 lines
Quoted 2 lines
Quoted 2 lines

return sane

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNPtMWMkyGM64RGpERAoWvAKC2+GgE7rmeUXUClmBBlAx5WB1dNgCgjGlf IkvPXdAoZ6J072F/YSctiyE=
=Pndr
-----END PGP SIGNATURE-----

Acked-by
#5 lore raw
Quoted 6 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 2 lines · Koen Kooi
Quoted 1 line · Philip Balister

On 01/19/2011 11:21 AM, Koen Kooi wrote:

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

* Having rpath to sysroot is just as bad as one to workdir

When you do a build with this, how many recipes have issues?

Console-image is clean now :)

And angstrom-gnome-image as well, so can I get some Acks or tested-bys please?

Regards,

#6 lore raw
In reply to Koen Kooi

2011/1/25 Koen Kooi <[email protected]>:

Quoted 6 lines

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 2 lines · Koen Kooi
Quoted 1 line · Philip Balister

On 01/19/2011 11:21 AM, Koen Kooi wrote:

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

* Having rpath to sysroot is just as bad as one to workdir

When you do a build with this, how many recipes have issues?

Console-image is clean now :)

And angstrom-gnome-image as well, so can I get some Acks or tested-bys please?

NAK, I feel other distro's like shr and minimal should be given some time to test this too. (and fix their issues)
Will try to set something up tonight or tomorrow.

Frans

Quoted 67 lines
Quoted 50 lines
Quoted 50 lines

Philip

Quoted 44 lines

Based on insane.bbclass from yocto

---
  classes/insane.bbclass |   11 ++++++-----

  1 files changed, 6 insertions(+), 5 deletions(-)
classes/insane.bbclass +0 -0
index 677db27..50752b5 100644
@@ -160,20 +160,21 @@ def package_qa_check_rpath(file,name,d, elf):

      import bb, os
      sane = True
      scanelf = os.path.join(bb.data.getVar('STAGING_BINDIR_NATIVE',d,True),'scanelf')
-    bad_dir = bb.data.getVar('TMPDIR', d, True) + "/work"
+    bad_dirs = [bb.data.getVar('TMPDIR', d, True) + "/work", bb.data.getVar('STAGING_DIR_TARGET', d, True)]
      bad_dir_test = bb.data.getVar('TMPDIR', d, True)
      if not os.path.exists(scanelf):
          bb.fatal("Can not check RPATH, scanelf (part of pax-utils-native) not found")

-    if not bad_dir in bb.data.getVar('WORKDIR', d, True):
+    if not bad_dirs[0] in bb.data.getVar('WORKDIR', d, True):
          bb.fatal("This class assumed that WORKDIR is ${TMPDIR}/work... Not doing any check")

      output = os.popen("%s -B -F%%r#F '%s'" % (scanelf,file)) txt    = output.readline().split()
      for line in txt:
-        if bad_dir in line:
-            error_msg = "package %s contains bad RPATH %s in file %s" % (name, line, file)
-            sane = package_qa_handle_error(1, error_msg, name, file, d)
+        for dir in bad_dirs:
+            if dir in line:
+                error_msg = "package %s contains bad RPATH %s in file %s" % (name, line, file)
+                sane = sane + package_qa_handle_error(1, error_msg, name, file, d)

Quoted 3 lines
Quoted 2 lines
Quoted 2 lines

      return sane

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNPtMWMkyGM64RGpERAoWvAKC2+GgE7rmeUXUClmBBlAx5WB1dNgCgjGlf IkvPXdAoZ6J072F/YSctiyE=
=Pndr
-----END PGP SIGNATURE-----

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#7 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 4 lines · Frans Meulenbroeks

2011/1/25 Koen Kooi <[email protected]>:

Quoted 2 lines · Koen Kooi
Quoted 2 lines
Quoted 2 lines · Philip Balister
Quoted 1 line · Koen Kooi
Quoted 11 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

* Having rpath to sysroot is just as bad as one to workdir

When you do a build with this, how many recipes have issues?

Console-image is clean now :)

And angstrom-gnome-image as well, so can I get some Acks or tested-bys please?

Quoted 2 lines

NAK, I feel other distro's like shr and minimal should be given some time to test this too.

Martin has already Acked it, fwiw
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNPuMoMkyGM64RGpERAqb6AJ4kMGJ1alDw/I5JZQ4ktQ8R6tT3+wCfQgDJ DW0T7/k96XHQKeqGGS+5WXQ=
=QlxQ
-----END PGP SIGNATURE-----

#8 lore raw

2011/1/25 Koen Kooi <[email protected]>:

Quoted 14 lines

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 10 lines · Frans Meulenbroeks

2011/1/25 Koen Kooi <[email protected]>:

Quoted 7 lines · Koen Kooi
Quoted 7 lines
Quoted 7 lines · Philip Balister
Quoted 4 lines · Koen Kooi
Quoted 1 line

* Having rpath to sysroot is just as bad as one to workdir

When you do a build with this, how many recipes have issues?

Console-image is clean now :)

Quoted 7 lines
Quoted 5 lines

And angstrom-gnome-image as well, so can I get some Acks or tested-bys please?

Quoted 2 lines

NAK, I feel other distro's like shr and minimal should be given some time to test this too.

Martin has already Acked it, fwiw tr

Yeah, saw it. Came in at my site just after I pressed send, but timewise it seems to be 2 minutes earlier.
I'll try to kick off a minimal build this evening (can't do that from here) and report the results (that'll probably be tomorrow because the build takes some time). Note that I am not an official minimal maintainer though, so I cannot ack on behalf of minimal, I can only give a tested-by

Not sure if other distro's need to have a say too. The only other ones that seem to have activity are kaeilos (which follows angstrom fairly closely) and slugos.

Frans

Quoted 14 lines

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNPuMoMkyGM64RGpERAqb6AJ4kMGJ1alDw/I5JZQ4ktQ8R6tT3+wCfQgDJ DW0T7/k96XHQKeqGGS+5WXQ=
=QlxQ
-----END PGP SIGNATURE-----

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#9 lore raw

2011/1/25 Frans Meulenbroeks <[email protected]>:

Quoted 31 lines

2011/1/25 Koen Kooi <[email protected]>:

Quoted 14 lines

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 10 lines · Frans Meulenbroeks

2011/1/25 Koen Kooi <[email protected]>:

Quoted 7 lines · Koen Kooi
Quoted 7 lines
Quoted 7 lines · Philip Balister
Quoted 4 lines · Koen Kooi
Quoted 1 line

* Having rpath to sysroot is just as bad as one to workdir

When you do a build with this, how many recipes have issues?

Console-image is clean now :)

Quoted 7 lines
Quoted 5 lines

And angstrom-gnome-image as well, so can I get some Acks or tested-bys please?

Quoted 2 lines

NAK, I feel other distro's like shr and minimal should be given some time to test this too.

Martin has already Acked it, fwiw tr

Yeah, saw it. Came in at my site just after I pressed send, but timewise it seems to be 2 minutes earlier.
I'll try to kick off a minimal build this evening (can't do that from here) and report the results (that'll probably be tomorrow because the build takes some time). Note that I am not an official minimal maintainer though, so I cannot ack on behalf of minimal, I can only give a tested-by

Quoted 5 lines

Not sure if other distro's need to have a say too. The only other ones that seem to have activity are kaeilos (which follows angstrom fairly closely) and slugos.

Frans

Wrt the test: bumped into a few issues with tzcode/tzdata geing out of date and the git pull needed to push the patches (so I could use them on the autobuilder) triggered a rebuild of gcc, so didn't get to starting the test yet.
Will retry tomorrow. Frans.

#10 lore raw
In reply to Koen Kooi
Quoted 14 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 10 lines · Frans Meulenbroeks

2011/1/25 Koen Kooi <[email protected]>:

Quoted 7 lines · Koen Kooi
Quoted 7 lines
Quoted 7 lines · Philip Balister
Quoted 4 lines · Koen Kooi
Quoted 1 line

* Having rpath to sysroot is just as bad as one to workdir

When you do a build with this, how many recipes have issues?

Console-image is clean now :)

Quoted 7 lines
Quoted 5 lines

And angstrom-gnome-image as well, so can I get some Acks or tested-bys please?

Quoted 2 lines

NAK, I feel other distro's like shr and minimal should be given some time to test this too.

Martin has already Acked it, fwiw

Yes, I think that if it says something it's broken then it's broken and needs to be fixed, haven't seen any false positives with it, that's why I Acked it.

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#11 lore raw
In reply to Koen Kooi

2011/1/25 Koen Kooi <[email protected]>:

Quoted 6 lines

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 2 lines · Koen Kooi
Quoted 1 line · Philip Balister

On 01/19/2011 11:21 AM, Koen Kooi wrote:

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

* Having rpath to sysroot is just as bad as one to workdir

When you do a build with this, how many recipes have issues?

Console-image is clean now :)

And angstrom-gnome-image as well, so can I get some Acks or tested-bys please?

Wanted to start testing but apparently this was already pushed 4 days ago by Khem.
http://cgit.openembedded.org/cgit.cgi/openembedded/commit/classes/insane.bbclass?id=6aa31074adaccffcfd3080e8390065ab5abda2a6

Frans

Quoted 67 lines
Quoted 50 lines
Quoted 50 lines

Philip

Quoted 44 lines

Based on insane.bbclass from yocto

---
  classes/insane.bbclass |   11 ++++++-----

  1 files changed, 6 insertions(+), 5 deletions(-)
classes/insane.bbclass +0 -0
index 677db27..50752b5 100644
@@ -160,20 +160,21 @@ def package_qa_check_rpath(file,name,d, elf):

      import bb, os
      sane = True
      scanelf = os.path.join(bb.data.getVar('STAGING_BINDIR_NATIVE',d,True),'scanelf')
-    bad_dir = bb.data.getVar('TMPDIR', d, True) + "/work"
+    bad_dirs = [bb.data.getVar('TMPDIR', d, True) + "/work", bb.data.getVar('STAGING_DIR_TARGET', d, True)]
      bad_dir_test = bb.data.getVar('TMPDIR', d, True)
      if not os.path.exists(scanelf):
          bb.fatal("Can not check RPATH, scanelf (part of pax-utils-native) not found")

-    if not bad_dir in bb.data.getVar('WORKDIR', d, True):
+    if not bad_dirs[0] in bb.data.getVar('WORKDIR', d, True):
          bb.fatal("This class assumed that WORKDIR is ${TMPDIR}/work... Not doing any check")

      output = os.popen("%s -B -F%%r#F '%s'" % (scanelf,file)) txt    = output.readline().split()
      for line in txt:
-        if bad_dir in line:
-            error_msg = "package %s contains bad RPATH %s in file %s" % (name, line, file)
-            sane = package_qa_handle_error(1, error_msg, name, file, d)
+        for dir in bad_dirs:
+            if dir in line:
+                error_msg = "package %s contains bad RPATH %s in file %s" % (name, line, file)
+                sane = sane + package_qa_handle_error(1, error_msg, name, file, d)

Quoted 3 lines
Quoted 2 lines
Quoted 2 lines

      return sane

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNPtMWMkyGM64RGpERAoWvAKC2+GgE7rmeUXUClmBBlAx5WB1dNgCgjGlf IkvPXdAoZ6J072F/YSctiyE=
=Pndr
-----END PGP SIGNATURE-----

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel