Skip to contentSkip to conversation

wrs_meta: turn on OHCI USB config option

PATCH In review Tom Zanussi 3 participants 4 messages Jan 20, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wrs_meta: turn on OHCI USB config option

Allow crownbay to recognize low-speed devices such as mouse and keyboard.

Pull URL: git://git.pokylinux.org/linux-2.6-windriver-contrib.git
Branch: tzanussi/crownbay-usb-fix
Browse:
http://git.pokylinux.org/cgit.cgi/linux-2.6-windriver-contrib/log/?h=tzanussi/crownbay-usb-fix

Please pull...

Thanks,
Tom Zanussi <[email protected]>

---
 wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg +1 -0
index a516dc9..864e1dc 100644
@@ -21,6 +21,7 @@ CONFIG_USB_EHCI_HCD=y
 CONFIG_PCIEPORTBUS=y
 CONFIG_NET=y
 CONFIG_USB_UHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_CHR_DEV_SG=y
 CONFIG_SOUND=y
Signature · 1 line
1.7.0.4
#1 lore raw
Quoted 23 lines · Tom Zanussi

Allow crownbay to recognize low-speed devices such as mouse and keyboard.

Pull URL: git://git.pokylinux.org/linux-2.6-windriver-contrib.git
Branch: tzanussi/crownbay-usb-fix
Browse:
http://git.pokylinux.org/cgit.cgi/linux-2.6-windriver-contrib/log/?h=tzanussi/crownbay-usb-fix

Please pull...

Thanks,
Tom Zanussi<[email protected]>

---
  wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg +0 -0
index a516dc9..864e1dc 100644

wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg CONFIG_USB_EHCI_HCD=y · line 27

Quoted 7 lines
wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg +1 -0
@@ -21,6 +21,7 @@ CONFIG_USB_EHCI_HCD=y
  CONFIG_PCIEPORTBUS=y
  CONFIG_NET=y
  CONFIG_USB_UHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y
  CONFIG_BLK_DEV_SD=y
  CONFIG_CHR_DEV_SG=y
  CONFIG_SOUND=y

This seems like the sort of thing we should push to standard. Or do BSPs like the crownbay start from an empty config?

Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
#2 lore raw
Quoted 19 lines · Darren Hart
Quoted 18 lines · Tom Zanussi

Allow crownbay to recognize low-speed devices such as mouse and keyboard.

Pull URL: git://git.pokylinux.org/linux-2.6-windriver-contrib.git
Branch: tzanussi/crownbay-usb-fix
Browse:
http://git.pokylinux.org/cgit.cgi/linux-2.6-windriver-contrib/log/?h=tzanussi/crownbay-usb-fix

Please pull...

Thanks,
Tom Zanussi<[email protected]>

---
  wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 16 lines

wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg CONFIG_USB_EHCI_HCD=y · line 27

Quoted 12 lines
wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg +1 -0
index a516dc9..864e1dc 100644
@@ -21,6 +21,7 @@ CONFIG_USB_EHCI_HCD=y
  CONFIG_PCIEPORTBUS=y
  CONFIG_NET=y
  CONFIG_USB_UHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y
  CONFIG_BLK_DEV_SD=y
  CONFIG_CHR_DEV_SG=y
  CONFIG_SOUND=y

This seems like the sort of thing we should push to standard. Or do BSPs like the crownbay start from an empty config?

Yeah, I remember awhile back discussing that we wanted to factor the things in the base configs out into e.g. standard, which of course would still be a good thing to do.

But for now, I went with the existing flow and put it alongside other similar options in that BSP...

Tom

#3 lore raw
Quoted 37 lines · Tom Zanussi
Quoted 19 lines · Darren Hart
Quoted 18 lines · Tom Zanussi

Allow crownbay to recognize low-speed devices such as mouse and keyboard.

Pull URL: git://git.pokylinux.org/linux-2.6-windriver-contrib.git
   Branch: tzanussi/crownbay-usb-fix
   Browse:
http://git.pokylinux.org/cgit.cgi/linux-2.6-windriver-contrib/log/?h=tzanussi/crownbay-usb-fix

Please pull...

Thanks,
     Tom Zanussi<[email protected]>

---
  wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    1 +

  1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 16 lines
Quoted 5 lines
wrs/cfg/kernel-cache/bsp/crownbay/crownbay.cfg +0 -0
index a516dc9..864e1dc 100644
@@ -21,6 +21,7 @@ CONFIG_USB_EHCI_HCD=y
Quoted 7 lines

  CONFIG_PCIEPORTBUS=y
  CONFIG_NET=y
  CONFIG_USB_UHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y
  CONFIG_BLK_DEV_SD=y
  CONFIG_CHR_DEV_SG=y
  CONFIG_SOUND=y

This seems like the sort of thing we should push to standard. Or do BSPs like the crownbay start from an empty config?

Quoted 3 lines

Yeah, I remember awhile back discussing that we wanted to factor the things in the base configs out into e.g. standard, which of course would still be a good thing to do.

Agreed.

Quoted 3 lines

But for now, I went with the existing flow and put it alongside other similar options in that BSP...

Also fine for now, but having a "usb" config that we could just include and push out to all BSPs, makes adding a sane set of options much easier.

As to pushing it down. Can anyone think of side effects of this on boards that don't have the hardware ? i.e. slower boot, devices detected in the slower format, or anything like that ? If there aren't any side effects, and we agree that increasing the base config (which should be as small/lean as possible) size a bit is fine, then we can absolutely push it down and at the flick of a switch enable all supported BSPs with the functionality.

Cheers,

Bruce

Quoted 5 lines

Tom

Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"